zostay/bolts

An Inversion of Control framework for Perl

bolts's Issues

lib/Bolts.pm: typos and grammatical suggestions

s/might now know/might not know/
s/a programs lifetime/a program's lifetime/
s/see if returned artifact/see if the returned artifact/
s/which will be applid/which will be applied/
s/This is variable likely/This variable is likely/

builder called twice

I tried to use Bolts in a simple script and found a case where builder is apparently called twice.

use strict;
use warnings;

package Bar {
    use Bolts;

    artifact foobar => (
        builder => sub {
            warn "BUILDER CALLED with ", join( ' ', map {"$_"} @_), "\n";
            return 'built';
        }
    );
}

package Foo {
    use Bolts;

    has bar => ( is => 'ro', required => 1 );
}

my $foo = Foo->new(bar=>Bar->new);
warn $foo->acquire('bar', 'foobar');

I tried to trace the code, and the following lines in Bolts::Role::RootLocator::acquire seems quite suspicious to me (missing return inside condition?):

# If the $item is a locator, pass control of the process to that
if (@path && $item->$_can('does') && $item->$_does('Bolts::Role::Locator')) {
       $item->acquire(@path, $options);
}