Comments (3)
This is failing because we don't implement SetClassName. I have a hackish solution in mind.
from v8monkey.
Hmm, nevermind. This is rather tricky to support.
from v8monkey.
This no longer crashes, but does fail:
TEST-INFO | (c:/Code/v8monkey/js/src/v8api/test/test_api.cpp) | Running test_ObjectProtoToString.
TEST-UNEXPECTED-FAIL | c:/Code/v8monkey/js/src/v8api/test/test_api.cpp | Expected true, got false at line 3242
TEST-UNEXPECTED-FAIL | c:/Code/v8monkey/js/src/v8api/test/test_api.cpp | Expected true, got false at line 3246
TEST-UNEXPECTED-FAIL | c:/Code/v8monkey/js/src/v8api/test/test_api.cpp | Expected true, got false at line 3250
TEST-UNEXPECTED-FAIL | c:/Code/v8monkey/js/src/v8api/test/test_api.cpp | Expected true, got false at line 3255
The failure at line 3242 looks to be the case that the replaced toString function is not being called (probably because we don't set the prototype of our function properly?)
The failure at line 3246 is because we don't have the right name. We could work around the lack of a JS API here by doing a memcpy with a new object with the right name. Scary, but doable. The failure on line 3250 is likely related.
I do not understand what the failure at line 3255 is.
from v8monkey.
Related Issues (20)
- Implement RegExp HOT 2
- Fix test_api.cpp's test_ConversionException failures HOT 3
- Test failure in test_DefinePropertyOnAPIAccessor HOT 2
- Test failure in test_DefinePropertyOnDefineGetterSetter HOT 3
- Crash in test_IndexedInterceptorWithGetOwnPropertyDescriptor
- Fix test_api.cpp's test_CallbackFunctionName failures
- Object::GetConstructor is wrong (test_ObjectGetConstructorName) HOT 2
- FunctionTemplate related test failures HOT 1
- don't use vanilla new/delete
- Move FunctionTemplate::IsFunctionTemplate and ObjectTemplate::IsObjectTemplate to v8::internal HOT 2
- Fix test_api.cpp's test_DescriptorInheritance failures & crash
- Fix test_api.cpp's test_NamedPropertyHandlerGetter failures
- Fix test_api.cpp's test_FunctionTemplate failure HOT 1
- Test failure in test_PreInterceptorHolders
- Implement ObjectTemplate::MarkAsUndetectable
- test_StackTrace fails
- Fix TypedArray/ArrayBuffer post-merge
- Fix Script/ScriptData post-merge HOT 1
- Test IsFunction from test_value.cpp is invalid
- Getting target of empty Handle causes NPE HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v8monkey.