Giter Site home page Giter Site logo

rclient's People

Contributors

zpatrick avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

rclient's Issues

error parsing should be easier

Right now, you need to totally override the request reader if you want to read custom error types. It should be more simple to try and marshal into errors. Perhaps a request option:

var resp int
var myerr *MyCustomError
client.Get("/path", &resp, rclient.Error(&myerr))

Another option could map status codes to types:

client.Get("/path", &resp, rclient.StatusMap(
    series.Ints(200, 299): &someType,
    series.Ints(400, 499): &someError,
    series.Ints(500, 599): &someOtherError,
))

Add http.Response to ReadJSONResponse error

The current error in ReadJSONResponse isn't very useful when trying to handle errors:

return fmt.Errorf("Invalid status code: %d", resp.StatusCode)

This should return a custom error type that has the http.Response as a public field.

readme should be less verbose

Instead of going over each request/client option, I should have a slimmed down version in the readme and examples of each option in godoc, e.g.:

# Request Options
* [Header](#link-to-example) - Add a header to a request
* [Basic Auth](#link-to-example) - Add basic auth  to a request

# Client Options
* [Doer](#) - Specify which object performs the http.Request (the default is http.DefaultClient)

# Error Handling
## using rcilent.ResponseError
## using ResponseReader() option

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.