Giter Site home page Giter Site logo

Comments (13)

rightaway avatar rightaway commented on June 12, 2024 1

@sunaku Could you take a look at this issue so that it's possible to upgrade to the latest zsh? Stuck on 5.8.

from zsh-history-substring-search.

Koston-0xDEADBEEF avatar Koston-0xDEADBEEF commented on June 12, 2024 1

I've pushed a new version of the patch, which also explains what it does and why.

from zsh-history-substring-search.

webartifex avatar webartifex commented on June 12, 2024

On my machine, I have the exact same issue with zsh 5.8.1 !

If someone tells me how I could be of helf (I am a Python dev), I will gladly look into this.

from zsh-history-substring-search.

StaticESC avatar StaticESC commented on June 12, 2024

I have the same issue on zsh 5.9-1

from zsh-history-substring-search.

danielshahaf avatar danielshahaf commented on June 12, 2024

See #135 and compare my comments at zsh-users/zsh-syntax-highlighting#872 (comment).

from zsh-history-substring-search.

rightaway avatar rightaway commented on June 12, 2024

@danielshahaf Is it something you can fix in this plugin so we can upgrade to 5.9?

from zsh-history-substring-search.

danielshahaf avatar danielshahaf commented on June 12, 2024

@rightaway I neither use nor maintain this plugin. (My comment says "Member" because, being a z-sy-h maintainer, I am a member of https://github.com/zsh-users/; however, I don't have any special permissions on this repository.)

Fortunately, #135 which I linked to is a PR against this plugin. There's nothing stopping you from merging it locally — on the proviso that if it breaks anything, you get to keep both pieces.

Good luck.

from zsh-history-substring-search.

rightaway avatar rightaway commented on June 12, 2024

@sunaku is the maintainer but not sure if this package is still maintained because no activity in the last year and half. Anyone know of alternatives that can be used with the latest zsh?

from zsh-history-substring-search.

rightaway avatar rightaway commented on June 12, 2024

@guidovansteen @jirutka Could you take a look at this issue so that it's possible to upgrade to the latest zsh? Stuck on 5.8.

from zsh-history-substring-search.

Koston-0xDEADBEEF avatar Koston-0xDEADBEEF commented on June 12, 2024

The commit above fixes the immediate issue, but I don't understand the code nearly well enough to say if it's an appropriate fix or just haphazardly masking a problem elsewhere.

from zsh-history-substring-search.

rightaway avatar rightaway commented on June 12, 2024

It can be the zstyle or region_highlight changes from https://zsh.sourceforge.io/releases.html that broke highlighting.

from zsh-history-substring-search.

deponian avatar deponian commented on June 12, 2024

@Koston-0xDEADBEEF Thank you!

from zsh-history-substring-search.

Koston-0xDEADBEEF avatar Koston-0xDEADBEEF commented on June 12, 2024

Patch is now merged, as @sunaku kindly trusted me with merge permission to this repository. Thank you!

from zsh-history-substring-search.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.