zsoldosp/django-performance-testing

Performance testing for Django through your automated tests!

django-performance-testing's Issues

Django 2 support

Hi, is there any plan to support Django 2.0?

I'm getting this error:

Invalid template library specified. ImportError raised when trying to load 'django_performance_testing.templatetags.djpt_limits': cannot import name 'getargspec'

Thx

new flak8 fails the build

flake8 django_performance_testing tests proof-of-concepts
tests/testapp/sixmock.py:2:80: E501 line too long (86 > 79 characters)
make: *** [lint] Error 1
ERROR: InvocationError: '/usr/bin/make test lint docs'

warn/fail when a limit is specified for an unknown settings based limit

e.g.: due to typo, upper-lowercase, etc.

WorstReport shouldn't include ad hoc limits with heading 'None'

only the settings_based limits

support setting_changed test signal for settings.DJPT_KNOWN_LIMITS_DOTTED_PATHS

as currently it's initialized once

the difficulty why it wasn't done as part of #4 is that

• there are many different registries created during testing and they all might be effected. Some might mock out the actual class loading (as good unit tests should), but some might not, and thus it would cause issues when the mocked tests change it to ['blah', 'no.such.module']
• also, this could get even more complicated after #11

allow adding a unique name/context to Limits to aid context manager based ad-hoc debugging

e.g.:

def my_function(*a, **kw):
    with SomeLimit(name='first', total=4): 
        ....
    with SomeLimit(name='second', total=4): 
        ....

so from the error message it's clear which one failed

allow the usage of the limits in the template as tags

so that template debugging becomes possible. Something along the lines of

{% block foo %}
  {% TimeLimit total=0.1 %}
    {{ block.super }}
  {% EndTimeLimit %}
{% endblock %}

support combining multiple result files into a single one a'la coverage

it was out of scope for #21 which already turned out to be quite big

the suggestion is to have a djpt_combine_result_files command that takes filepaths as *args (LabelCommand) and reads all of them to memory, then write it out into a single file named django_performance_testing.serializer.get_datafile_path

The idea behind using labels instead of accepting file patterns and then converting them to filepaths based on glob or re or similar is to keep things simple here.

people running things in parallel would be expected to have different file names for each run in their settings (e.g.: djpt.results_collected.$$ to get the running process's id), and then do the bash magic themselves (e.g.: manage.py $(ls djpt.results_collected*)). Probably this should be documented :)

use the registry for setting up the collectors with id_

for consistency and simplicity sake

allow end user to control whether the report is printed or not

support displaying the actual queries that failed the limit

current workaround to achieve this is

            from django_performance_testing.signals import results_collected
            def dump_queries(sender, results, context, **kwargs):
                try:
                    write_result, = (r for r in results if r.name =='write')
                    if write_result.queries:
                        print '\n'.join(q['sql'] for q in  write_result.queries)
                except ValueError:
                    pass
            results_collected.connect(dump_queries)
            with QueryBatchLimit(write=0):
                ....

timing limits don't work with pytest-django

Hello, I use pytest-django to be able to run tests with pytest runner. Query limits work well, timing doesn't. Pytest is a popular test runner (2500 github stars) and allows for more comfortable asserting (assert 1 < 2 vs. self.assertGreaterThan(2,1))

Please look at possibility of supporting pytest.

$ pip freeze | egrep '(test|Django)'
Django==1.11.9
django-performance-testing==0.7.3
pytest==3.2.5
pytest-cov==2.5.1
pytest-django==3.1.2