Comments (5)
Thanks for the report. I'll take a look.
On first glance it feels like it would have been smarter for CMake to just set CMAKE_C_COMPILER_ID
to MSVC
when Clang is invoked in MSVC emulation mode, but they will probably have had their reasons.
from zycore-c.
Which version of CMake are you using, by the way?
from zycore-c.
I switched the compiler detection to use the MSVC
variable instead of CMAKE_C_COMPILER_ID
. According to the documentation, this should also be set for other compilers pretending to be MSVC. I however noticed that this part mentioning compiler emulation was only added to the documentation in CMake 3.10, so you will have to make sure that you have a rather recent version of CMake.
Since I don't really feel like setting up clang-cl I would appreciate it if you could check out this branch and see if it resolves the issue.
from zycore-c.
I just tried it and that new branch works fine. 👍
I'm using the CMake shipped via Visual Studio 2019's "C++ CMake tools for Windows" component which is cmake version 3.15.19080502-MSVC_2
.
Thank you!
from zycore-c.
Excellent -- I merged it into master!
from zycore-c.
Related Issues (16)
- Inconsistent naming scheme (`ZYCORE_` vs `ZYAN_`)
- Implement LRU cache
- WDK compatibility
- Don't use floating-point types to provide kernel-mode support
- Coverity complains about likely NPE in zycore HOT 1
- Tag/release zycore-c? HOT 1
- typo in ifdef in Types.h HOT 1
- Support in linux kernel 5.4 HOT 5
- Potential security issue
- Please consider tagging releases HOT 6
- Build error ZycoreExportConfig.h HOT 2
- CMake Error HOT 1
- add support for riscv64 HOT 4
- Support running on big-endian architectures HOT 3
- Implement more basic containers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zycore-c.