zzzfelix/wbmalert

Takes a list of websites, makes a request to each website every 30 seconds, and plays a notification sound when the contents of a website have changed.

wbmalert's Issues

Replace audio library

The script currently makes use of github.com/faiface/beep to play a notification sound.

To reduce external dependencies, the library could be reduced with something else. All it needs to do is get the user's attention. A full blown audio library might be overkill.

Ineffectual assignments to err

• there are some ineffectual assignments to err (about 6)
• make sure other assignments aren't overwritten, too
• e.g. https://github.com/zzzfelix/wbmalert/blob/54278fe2e2c1/wbmalert.go#L77

Properly embed sound file

The success.mp3 file is embedded but not used for playback in sound_darwin.go. Sound only plays when the file exists in the current path lol.

Better error handling

In case of an error, the snapshot updates with the string error. The alert is fired when the error occurs and it fires again when it doesn't occur anymore. This results in two, unnecessary success notifications. Errors should be either ignored or result in a different notification.

Get "https://www.wbm.de/wohnungen-berlin/angebote/": net/http: TLS handshake timeout
An error occurred! The website could not be reached!
========= WBM =========
Content changed: https://www.wbm.de/wohnungen-berlin/angebote/
=======================

Create a release pipeline

Replace HTML Sanitization library

The script uses github.com/microcosm-cc/bluemonday to sanitize the retrieved HTML. This is only done because some websites contain generated strings/tokens (e.g. for Google Analytics or as references to dynamically created JS/CSS) that need to be removed.

To reduce external dependencies, an internal solution to remove these strings is required. Doesn't have to be HTML sanitation.

External configuration

The configuration (websites, interval) is currently hard-coded in the go program code. This could be in an external file.

Sound for Windows

Currently, sound only works on macOS. It's implemented using the operating system's afplay command. I would prefer not to pull in any libraries.

Add regex remove feature

• Some websites have ever-changing parts (like date/time)
• An additional property in configuration.json should allow for a regular expression that removes those parts

Write some tests

For:

• config.go
• sound.go

Sound for Linux

Currently, sound only works on macOS. It's implemented using the operating system's afplay command. Linux has a similar aplay command. I would prefer not to pull in any libraries.