aarongough/ruby-tmdb

[DEPRECATED] An ActiveRecord-style API wrapper for TheMovieDB.org

ruby-tmdb's Issues

Searching for title that contains a slash

Searching for a movie with a slash in the title results in RuntimeError 404:

Tmdb.api_call("Movie.search", "Face/Off")

When escaping the search string it works as expected:

Tmdb.api_call("Movie.search", CGI::escape("Face/Off"))

Would it be safe to change Tmdb.api_call to run CGI::escape twice on the params instead of only once as it is now?

TmdbMovie.find(:title) should return a collection

Hi Aaron,

Look, I was stubbing requests to api.themoviedb.org in my acceptance tests when I realized that if I returned one element array as the response body, then I couldn't iterate over the results of my call to TmdbMovie.find(title: 'Movie Title').

Why? Because this method returns a single object whenever the api.themoviedb.org response returns a json array of one single element.

I cannot know how many movies I will be returned in advance, so I must check before I can iterate over the results of TmdbMovie.find(:title).

Wouldn't it be better to always return a collection? In case we were only interested in one movie we could pass in limit: 1 option and then get the first element of that collection.

Thanks for your job!

TMDb API 2.1 will be down soon

TMDb updated their API to version 3, and will shut down v2.1 soon. Any plan updating the gem?

Add a deprecated notice to repo

Hi @aarongough,

Thanks for the repo :) Would it be possible to add a deprecated warning (ie, a note that this does not currently work) to the top of the README? Might save future peoples some time