Giter Site home page Giter Site logo

all-contributors / app Goto Github PK

View Code? Open in Web Editor NEW
553.0 17.0 143.0 2.58 MB

πŸ€– A GitHub App to automate acknowledging contributors to your open source projects

Home Page: https://allcontributors.org

License: MIT License

JavaScript 99.27% HTML 0.73%
contributors all-contributors opensource opensource-management open-source-tooling acknowledgements recognition probot-app github-apps

app's Introduction

Call for translators! We're looking for translators to help translate this spec for everyone!

Read this documentation in the following languages
ν•œκ΅­μ–΄ δΈ­ζ–‡ Bahasa Indonesia Deutsch Polski
English PortuguΓͺs do Brasil EspaΓ±ol FranΓ§ais Русский ζ—₯本θͺž

Build Status Crowdin All Contributors Netlify Status Star on GitHub

This is a specification for recognizing contributors to an open-source project in a way that rewards every contribution, not just code.

The basic idea is this:

Use the project README (or another prominent public documentation page in the project) to recognize the contributions of members of the project community.

People are giving themselves and their free time to contribute to open source projects in so many ways, so we believe everyone should be praised for their contributions (code or not).

The All Contributors Table

Below is an example of how using the all-contributors spec table can recognize all contributors

All Contributors Table Screenshot

You can use the @all-contributors bot πŸ€– to automate acknowledging contributors to your open source projects

Specification

The specification is detailed on allcontributors.org

Emoji key

The Emoji Key ✨ (and Contribution Types) can be found on allcontributors.org

Contributing

If you've ever wanted to contribute to open source, and a great cause, now is your chance!

See the contributing docs for more information

Contributors ✨

Thanks go to these wonderful people (emoji key):

Kent C. Dodds
Kent C. Dodds

πŸ’¬ πŸ“– πŸ‘€ πŸ“’
Jeroen Engels
Jeroen Engels

πŸ“– πŸ‘€ πŸ”§
Jake Bolam
Jake Bolam

πŸ“– πŸ”§ πŸš‡ 🚧 πŸ‘€ πŸ’¬
Tyler Benning
Tyler Benning

🚧 πŸ’» 🎨
Jeff Wen
Jeff Wen

🚧 πŸ‘€
Maximilian Berkmann
Maximilian Berkmann

🌍 πŸ“– 🚧 πŸ‘€ πŸ“’
Matheus Rocha Vieira
Matheus Rocha Vieira

🌍 πŸ’» πŸ“–
Robert Lluberes
Robert Lluberes

🌍
이쒅진
이쒅진

πŸ“– 🌍
Wenqing Xue
Wenqing Xue

🌍
Divjot Singh
Divjot Singh

πŸ“– πŸ‘€
Ben Briggs
Ben Briggs

πŸ“– πŸ‘€
James Monger
James Monger

πŸ“–
Chris Simpkins
Chris Simpkins

πŸ“– πŸ‘€
F. Hemberger
F. Hemberger

πŸ“–
Daniel Kraft
Daniel Kraft

πŸ“–
Mayank Badola
Mayank Badola

πŸ“– πŸ”§
Marco Biedermann
Marco Biedermann

🎨
Itai Steinherz
Itai Steinherz

πŸ“–
Patrick Connolly
Patrick Connolly

πŸ“–
Nikola Đuza
Nikola Đuza

πŸ“–
Demian Dekoninck
Demian Dekoninck

πŸ’»
Michael Peyper
Michael Peyper

πŸ“–
David Sima
David Sima

πŸ“– 🌍
allcontributors[bot]
allcontributors[bot]

πŸ“–
Greenkeeper[bot]
Greenkeeper[bot]

πŸš‡
Maryam Pazirandeh
Maryam Pazirandeh

πŸ“–
Cassandra Venere
Cassandra Venere

πŸ“–
codimiracle
codimiracle

πŸ“–
Sung Kim
Sung Kim

🌍 πŸ“–
Thomas Brok
Thomas Brok

🌍
robertgrzonka
robertgrzonka

🌍
Megumi Aliya
Megumi Aliya

🌍
Yule
Yule

🌍
Sylvain Pace
Sylvain Pace

πŸ”Œ
Peter HΓΌrlimann
Peter HΓΌrlimann

🌍
Thiago Delgado Pinto
Thiago Delgado Pinto

🌍
Rogerio Prado de Jesus
Rogerio Prado de Jesus

🌍
Tobias Andersen
Tobias Andersen

🌍
danielbronder
danielbronder

🌍
JoΓ£o Pedro Raskopf
JoΓ£o Pedro Raskopf

🌍
Edwin Vargas
Edwin Vargas

🌍
Faisal KANOUT
Faisal KANOUT

🌍
John Murphy
John Murphy

πŸ“–
Kirstie Whitaker
Kirstie Whitaker

πŸ€”
Patryk Peas
Patryk Peas

πŸ“– 🌍 πŸ’»
Ivan.Nginx
Ivan.Nginx

🌍
levy
levy

πŸ“–
nils mΓ₯sΓ©n
nils mΓ₯sΓ©n

πŸ“–
Masato Urai (@uraway_)
Masato Urai (@uraway_)

🌍
Kyle Holmberg
Kyle Holmberg

πŸ“–
Simon Aronsson
Simon Aronsson

🌍
Cem
Cem

🌍
JΓ©rΓ©mie Astor
JΓ©rΓ©mie Astor

πŸ“–
Rachel M. Carmena
Rachel M. Carmena

🌍
SnOβ‚‚WMaN
SnOβ‚‚WMaN

πŸ“–
CΓ©sar Richard
CΓ©sar Richard

πŸ“– πŸ““
kharaone
kharaone

πŸ“–
Mudassar Ali
Mudassar Ali

πŸ“–
Andrew Mason
Andrew Mason

πŸ“–
Mauro M.
Mauro M.

πŸ“–
Nicolas Goutay
Nicolas Goutay

πŸ“–
William Entriken
William Entriken

πŸ’»
Amine
Amine

πŸ“–
Stefano Moia
Stefano Moia

πŸ“–
Adam Tuttle
Adam Tuttle

πŸ“–
Moni
Moni

πŸš‡
IlaΓ― Deutel
IlaΓ― Deutel

πŸ“–
Hendrik Brummermann
Hendrik Brummermann

πŸ“–
Sang Lostrie
Sang Lostrie

πŸ›
xinbenlv
xinbenlv

πŸ“–
Ivan Paulovich
Ivan Paulovich

πŸ“–
Jake Wiesler
Jake Wiesler

πŸ“–
Micael Jarniac
Micael Jarniac

πŸ›
Markus LΓΆning
Markus LΓΆning

πŸ“–
Austin Huang
Austin Huang

πŸ“–
Nils Andresen
Nils Andresen

πŸ“–
LaChapeliere
LaChapeliere

πŸ“–
Michal
Michal

🌍
Ali Torki
Ali Torki

πŸ“–
Josh Soref
Josh Soref

πŸ“–
Taiizor
Taiizor

πŸ’»
Ikko Ashimine
Ikko Ashimine

πŸ“–
Matthew
Matthew

πŸ“–
Cornelius Roemer
Cornelius Roemer

🎨
JohnnySD
JohnnySD

πŸ–‹ πŸ“–
mwaitzman
mwaitzman

πŸ“–
Kenichi Kamiya
Kenichi Kamiya

πŸ“–
Angel Aviel Domaoan
Angel Aviel Domaoan

πŸ“– πŸ’» 🚧 πŸ› πŸ‘€
Allan Bowe
Allan Bowe

πŸ“–
E - Coders (Aasheesh Agarwal)
E - Coders (Aasheesh Agarwal)

πŸ“–
Fernando
Fernando

πŸ“–
Vedant Mohan Goyal
Vedant Mohan Goyal

πŸ“–
Muhammad Hanis Irfan Mohd Zaid
Muhammad Hanis Irfan Mohd Zaid

πŸ“–
Abe Hanoka
Abe Hanoka

πŸ“–
Roshan Jossy
Roshan Jossy

πŸ“– πŸ’»
SΓ©bastien Lavoie
SΓ©bastien Lavoie

πŸ›
Nicolas Girondi
Nicolas Girondi

🌍
Federico Grandi
Federico Grandi

πŸ“–
Henry Bley-Vroman
Henry Bley-Vroman

πŸ“–
LBF38
LBF38

πŸ“–
Yoon Hyeseong
Yoon Hyeseong

πŸ›

This project follows the all-contributors specification. Contributions of any kind are welcome!

LICENSE

MIT

app's People

Contributors

ahonn avatar allcontributors[bot] avatar baikho avatar berkmann18 avatar dependabot[bot] avatar fennecdjay avatar fjdufou avatar frederickfogerty avatar gr2m avatar greenkeeper[bot] avatar jakebolam avatar jaydosunmu avatar js-kyle avatar jsoref avatar knorpelsenf avatar mfix22 avatar michaeldeboey avatar mloning avatar mralwin avatar mstomar698 avatar nschonni avatar oscard0m avatar ouuan avatar pgrimaud avatar phacks avatar rluvaton avatar sinchang avatar tenshiamd avatar tobiasbueschel avatar yakkomajuri avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

app's Issues

The bot incorrectly respects the config file for options it should know

Describe the bug
The bot incorrectly respects the config file for options it should know.

Click the πŸ’»icon on a contributor in the Contributors section

See that it incorrectly links to an invalid URL: https://github.com/all-contribtuors/bot/commits?author=jakebolam

This URL is determined based on the config in .all-contributorsrc which is miss-configured.

The bot should ignore the following config options (when running in bot mode):

  "projectName": "bot",
  "projectOwner": "all-contribtuors",
  "repoType": "github",
  "repoHost": "https://github.com",

Expected behavior
We know the repo and server, let's ignore the config and go with what we know

Screenshots
screen shot 2019-01-24 at 6 03 26 pm

screen shot 2019-01-24 at 6 03 33 pm

Add APM monitoring such as datadog

Is your feature request related to a problem? Please describe.
It's difficult to gain visibility into the instance running in production.

Describe the solution you'd like
Add APM monitoring to have visibility into production. (CloudWatch is not enough)

Describe alternatives you've considered
NewRelic etc

Additional context

Better error handling when the configuration file data structure is incorrect

Is your feature request related to a problem? Please describe.
When the configuration file datastructure is incorrect,the bot fails in weird and wonderful ways. e.g.

{
    "projectName": "coding_challenge-13",
    "projectOwner": "zeroDevs",
    "repoType": "github",
    "repoHost": "https://github.com",
    "files": [
        "README.md"
    ],
    "imageSize": 100,
    "commit": true,
    "contributors": [
        {
            "login": "The24thDS",
            "name": "David Sima",
            "avatar_url": "https://avatars0.githubusercontent.com/u/26633429?v=4",
            "profile": "https://github.com/The24thDS",
            "contributions": [
                "code",
                "bug",
                "review"
            ]
        },
        {
            "login": "mikeattara",
            "name": "Mike Perry Y Attara",
            "avatar_url": "https://avatars1.githubusercontent.com/u/31483629?v=4",
            "profile": "https://mikeattara.com",
            "contributions": [
                "ideas",
                "code",
                "review",
                "test"
            ]
        },
        {
            "login": "AkinAguda",
            "name": "Akinwunmi Aguda",
            "avatar_url": "https://avatars0.githubusercontent.com/u/39712415?v=4",
            "profile": "https://github.com/AkinAguda",
            "contributions": [
                "bug"
            ]
        },
        {
            "login": "jakebolam",
            "name": "Jake Bolam",
            "avatar_url": "https://avatars2.githubusercontent.com/u/3534236?v=4",
            "profile": "https://jakebolam.com",
            "contributions": [
                "question"
            ]
        },
        {
            "login": "aneagoie",
            "name": "Andrei Neagoie",
            "avatar_url": "https://avatars3.githubusercontent.com/u/10776230?v=4",
            "profile": "https://github.com/aneagoie",
            "contributions": [
                "bug",
                "code",
                "ideas",
                "review"
            ]
        },
        {
            "login": "MattCSmith",
            "name": "Matt Smith",
            "avatar_url": "https://avatars3.githubusercontent.com/u/6190356?v=4",
            "profile": "https://github.com/MattCSmith",
            "contributions": [
                "question",
                "bug",
                "code",
                "ideas",
                "review"
            ]
        },
        {
            "contributions": [
                "ideas"
            ]
        },
      ]
}

Technically valid JSON but the schema is busted.

Describe the solution you'd like
Provide great error messages, so users no whats wrong with the schema.

Even better: Auto fix it!

Additional context
See: https://sentry.io/all-contributors/github-bot/issues/859146506/?query=is%3Aunresolved

Also issues: zeroDevs/FullstackTrends_Challenge-13#182

Add status up-time

Is your feature request related to a problem? Please describe.
Public visibility into up time

Describe the solution you'd like
Add status uptime, something like https://stats.uptimerobot.com/Dq46zf6PY

This can also be added to our marketplace listing

Describe alternatives you've considered

Additional context

Bot currently overwrites contributions if user exists (does not add to them)

Is your feature request related to a problem? Please describe.
The bot's PR currently overwrites previous contributions (does not add to them)

Describe the solution you'd like
When a user already exists merge the contributions, instead of replacing them.

Describe alternatives you've considered

Additional context
#9

Invalid Code contribution URL

Describe the bug
When I click on the πŸ’» on the emoji key it uses what appears to be an invalid URL: https://github.com/all-contribtuors/bot/.
Which in fact is caused by the typo in all-contributors.

To Reproduce
Click on any πŸ’», ⚠️ or πŸ“– emojis and it will be using the typoed URL.

Expected behaviour
The URL should be working.

Screenshots
Not needed

Additional context
This doesn't seem to be happening on the CLI and I couldn't found thus far where the typo was on both repos (using master up-to-date).

In some cases, seeing two responses from the bot

Describe the bug
In some cases seeing two responses from the bot:
screen shot 2019-01-21 at 2 45 17 pm

To Reproduce
Steps to reproduce the behavior:

  1. @all-contributors please add @tbenning for design
    Repeat until seen

Expected behavior
One response per comment

Screenshots
See above

Additional context
The second error message is relating to: https://sentry.io/all-contributors/github-bot/issues/844367677/. I.e. the method is being invoked twice, and the second time fails on creating the branch. This is being fixed as part of #48. In this case tho it will still result in 2 comments to the users.

Looking at deliveries from GitHub there are 'service timeouts' at the time (with payload relating to this message), causing the double delivery.
screen shot 2019-01-21 at 2 50 11 pm

AllContributorsBot should be able to setup repo's initially

Is your feature request related to a problem? Please describe.
When you type @all-contributors please add jakebolam for code and the repository is not setup. The bot responds and says use the CLI tool to setup the repo.

tldr: Remove project dependence on cli tool!

Describe the solution you'd like
It would be good if the bot could open an initial PR in these cases (or direct the user to say some other specific words for the bot to put up an init PR).
e.g.
@AllContributorsBot setup project
-> Puts up initial pull request for README.md and .all-contributorsrc

Describe alternatives you've considered
Keeping setup restricted to using the cli tool

Additional context

An easy way to refresh a pull-request adding a contributor

Is your feature request related to a problem? Please describe.
When multiple contributors are being added, a PR could become stale (i.e not up to date with master/conflicts with the master branch). We should have a way to auto resolve this.

Describe the solution you'd like
@all-contributors please refresh this PR

Describe alternatives you've considered
Alternatively, we could watch for merge event son pull requests opened by the bot, and refresh the PR:
screen shot 2019-01-26 at 3 17 09 pm

Additional context

Support adding multiple users in a single message (Use NLP parsing per sentence, not on an entire message)

Is your feature request related to a problem? Please describe.
It would be great to have a way to bulk add users in a single request.

Describe the solution you'd like
Implementing per sentence parsing instead of per-message will allow us to do this. It will also help the NLP to be more effective in determining intentions.

Describe alternatives you've considered

Additional context
Case of a user adding lots of users: zeroDevs/FullstackTrends_Challenge-13#161

Broken case on message too big:
https://github.com/zeroDevs/coding_challenge-13/issues/132#issuecomment-457773736
screen shot 2019-01-25 at 6 48 53 pm

Case of not working:
See freecodecamp-ibadan/freecodecamp-ibadan#4

@all-contributors please add @stevoo24 for code,content

screen shot 2019-02-10 at 11 30 04 am

Just a test

I just want to see this in action! This is sooooo cool!

@AllContributorBot please add kentcdodds for infrastructure

Commit convention agnosticism

Is your feature request related to a problem? Please describe.
A feature

Describe the solution you'd like
The bot should be aware of the commit convention a repo, it was installed on, uses in order to write valid commits and valid PRs.

Describe alternatives you've considered
Allowing repo maintainers to set/specify the commit convention whether it's via a CZ config or via a commitConvention (or commitStyle) field in the .all-contributorsrc file.

Additional context
Here's an example of PR using the angular one on a repo set to ESLint with commit linters.

Improve development experience

Is your feature request related to a problem? Please describe.
Local development experience is currently confusing with probot and serverless runners.

Describe the solution you'd like
Just use serverless:

  • Run lambdas in serverless (see #86)
  • Create a serverless plugin to allow use of smee proxy in development -> Now in #188
  • Document development experience
  • Remove yarn start-probot
  • Update yarn start to use yarn start-serverless

Setup sandbox environment we can sanity test against before shipping to production

Is your feature request related to a problem? Please describe.
Shipping some changes straight to production is risky

Describe the solution you'd like
A sandbox environment we can run sanities against before heading to production

Describe alternatives you've considered
Keeping as is

Additional context
This should stay as part of the master branch, and if possible the sanities should be automated

Bot links to incorrect pull request when updating

Describe the bug
Bot links to wrong pull request when updating

To Reproduce
Steps to reproduce the behaviour:

  1. Mention: @all-contributors please add @tbenning for design, leave the PR open
  2. Mention: `@all-contributors please add @jakebolam for design, leave the PR open
  3. Mention: @all-contributors please add @tbenning for design, see that comment links to jakebolam PR, (tbenning PR was updated tho)

Expected behavior
Links to the correct pull request

Screenshots
screen shot 2019-02-13 at 8 06 23 am

Additional Context
See comment in sandbox: all-contributors-sandbox/test-all-contributors#1 (comment)

Receive messages if only for bot name

Is your feature request related to a problem? Please describe.
Messages for the bot should only be processed if it starts with @AllContributorsBot.
Currently, the bot will respond to names such as @AllContributorsBotDev, and anywher in the message

Describe the solution you'd like
Just respond to bot name, if the entire message is directed at said bot.

Describe alternatives you've considered

Additional context

When a user is found, but the bot cannot determine contributions, tell the user

Is your feature request related to a problem? Please describe.
Sometimes when asking the bot to add contributions it won't be able to determine the types of contributions, this does not stop the bot opening a PR with an empty array of contributions see https://github.com/all-contributors/all-contributors-bot/pull/29/files#diff-c47fb5a6d4fde805d2706fc934e8d354R38

Describe the solution you'd like
When a user is found, but the bot cannot determine contributions, tell the user. A PR should not be opened.

Describe alternatives you've considered

Additional context

Add basic CloudWatch alarms

Is your feature request related to a problem? Please describe.
If users start depending on the bot, they want it to work. Let's ensure we know when it's not.

Describe the solution you'd like
Cloud watch alarms on error rate increases etc.
Measuring timing would be important too, too fast and something is wrong, same as too slow.

Describe alternatives you've considered

Additional context
Something like https://github.com/ACloudGuru/serverless-plugin-aws-alerts could help, instead of pure cloud formation

screen shot 2019-01-15 at 12 30 45 am

Support adding people with mentions

Is your feature request related to a problem? Please describe.
Adding a user using @all-contributors please add @tbenning for design results in a fail
screen shot 2019-01-15 at 1 00 33 am

While non-mentions succeed:
screen shot 2019-01-15 at 1 00 58 am

Describe the solution you'd like
Adding them for their contributions!

Describe alternatives you've considered

Additional context

Write article about the new bot!

Is your feature request related to a problem? Please describe.
Promote the new bot

Describe the solution you'd like
Write a blog article about the new bot

Describe alternatives you've considered

Additional context

Support default branches other than master

Is your feature request related to a problem? Please describe.
Currently only supports pull-requests again master

Describe the solution you'd like
Should look at default branch, and base pull-reuqest against that branch

Describe alternatives you've considered

Additional context

Support @allcontributors when requesting additions

Is your feature request related to a problem? Please describe.
@allcontributors add @The24thDS for code without a dash doesn't work

Describe the solution you'd like
To see the non dash version work!

error.code deprecation

Describe the bug
Since @octokit/[email protected], deprecation warnings pops up so it would be ideal to update the relevant code snippet.

To Reproduce
Steps to reproduce the behaviour:

  1. yarn test or npm test
  2. Wait for the following test suites to finish: test/utils/getUserDetails.test.js, test/index-e2e.test.js
  3. Look out for console.warn outputs.

Expected behaviour
This shouldn't be happening

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

console.warn node_modules/@octokit/request/lib/http-error.js:15
`error.code` is deprecated, use `error.status`. 

Additions in batches (or docs for this)

This bot is so awesome!!! πŸ™Œ πŸ‘ πŸŽ‰ πŸ€–

We often have more than one new contributor per day, so:

We are interested in running this in a batch each week to reduce PR churn and maintenance burden.

If this is already possible, apologies, and could you point us at the docs?

Otherwise we'd love to install and use this app if such a feature were eventually added. Thanks a million!

Add analytics

Is your feature request related to a problem? Please describe.
It would be good to have insight into how users are using the bot

  • How many messages result in a PR (effective % rate)
  • Common usage terms.
  • What messages fall down (note we should only record this for PUBLIC repositories)

Describe the solution you'd like
Some analytic tracking solution

Describe alternatives you've considered

Additional context

Consider adding CI check (when all-contributors rc is manually changed)

Is your feature request related to a problem? Please describe.
When a user manually adjusts the all-contributors file its possible it could be broken.

Describe the solution you'd like
Add a CI check which says (this PR is all contributors good to go)

Describe alternatives you've considered

Additional context
See #102

screen shot 2019-01-26 at 2 03 19 pm

An in-range update of serverless is breaking the build 🚨

The devDependency serverless was updated from 1.36.3 to 1.37.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

serverless is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • βœ… ci/circleci: node_modules: Your tests passed on CircleCI! (Details).
  • ❌ ci/circleci: test: CircleCI is running your tests (Details).
  • βœ… ci/circleci: lint: Your tests passed on CircleCI! (Details).
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).

Release Notes for 1.37.0 (2019-02-06)

Meta

Commits

The new version differs by 114 commits.

  • 2cf96e0 Merge pull request #5803 from serverless/release-1-37
  • 1b8252d releasing v1.37.0
  • 3b9957f Merge pull request #5794 from serverless/fix-tests-debug
  • c551abf fixed cli tests when running in debug mode
  • 4a64f4a Merge pull request #5793 from serverless/fix-yml-race-condition
  • 5896f0c fix race condition when loading config file
  • 04a2a65 Merge pull request #5788 from serverless/secrets-via-ssm
  • cefe6f0 Add aws secrets mgr to TOC of aws vars
  • 74a1260 Update docs/providers/aws/guide/variables.md
  • 2e49692 Update docs/providers/aws/guide/variables.md
  • ff82197 Document how to use Secrets Manager
  • 61d3af3 Merge pull request #5785 from pchynoweth/master
  • 4c935d1 Fixed up linting issues
  • 9a25ade Added unit tests
  • 73d95c2 Fixed linting issue

There are 114 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Analytics: Track bot installs and uninstalls

Describe the solution you'd like
Track bot installs and uninstalls.

Could also track additional metadata with these (e.g. repository stars), uninstaller?

Additional context
Looking to gain more insight into how users are using the platform./

cc @tbenning @gr2m

Support plurals when adding contributions e.g. docs (and doc)

Is your feature request related to a problem? Please describe.
@AllContributorsBot please add jakebolam for docs, infra and code results in the additions of infra and code (not doc as well)

Describe the solution you'd like
The bot should be able to understand plurals. And add doc as well.

Describe alternatives you've considered

Additional context

Convert code base to typescript or add JSDoc comments

Is your feature request related to a problem? Please describe.
Bugss

Describe the solution you'd like
Implement typescript to reduce type related bugs

Describe alternatives you've considered

Additional context

Lock down security on bot repo to allow write access to contributors

Is your feature request related to a problem? Please describe.
Maintainers should have write access to all repos, they currently do not have write access to the bot (due to security concerns).

Describe the solution you'd like
Lock down CI to only inject AWS secrets on master pushes.
Lock down AWS credentials to have the minimum credentials required for deployment.

Additional context
We don't pass environment variables (Secrets) to forked builds. Which is how we can currently have users fork the repo, put up pull requests and run the test builds.

Handle case where branch already exists

Describe the bug
Bot currently crashes with `We had trouble processing your request. Please try again later. When the contributor branch already exists

To Reproduce
Steps to reproduce the behavior:

  1. Comment and say @AllContributorsBot please add jakebolam for code, doc and infra
  2. Wait for pull reuqest to be created
  3. Comment again and say @AllContributorsBotDev please add jakebolam for code, doc and infra
  4. See crash

Expected behavior
Should return and say a branch/PR is already open.

Screenshots

Additional context
After we fix this bug, it is likely we will expose the bug branch exist, but PR is not open. We should be wary of this case too.

sentry error of one such case: Error: Reference already exists
https://sentry.io/all-contributors/github-bot/issues/844367677/?query=is%3Aunresolved

First bot PR changed our table layout

(Thanks so much for building this!)

On first use with an existing contributors list (generated via the command-line tool), the bot sets contributorsPerLine to 7 in our config file. This is undesirable as the 7th column in each row is squished smaller than the others:

2019-01-17 at 8 40 am

PR here

An in-range update of all-contributors-cli is breaking the build 🚨

The dependency all-contributors-cli was updated from 5.9.1 to 5.10.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

all-contributors-cli is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • βœ… ci/circleci: node_modules: Your tests passed on CircleCI! (Details).
  • βœ… ci/circleci: lint: Your tests passed on CircleCI! (Details).
  • ❌ ci/circleci: test: Your tests failed on CircleCI (Details).

Release Notes for v5.10.0

5.10.0 (2019-01-16)

Features

Commits

The new version differs by 1 commits.

  • 292d400 feat(contribution-type): added maintenance type (#142)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Probot is using octokit/rest 15, which is missing some features e.g. git.getRef

Is your feature request related to a problem? Please describe.
AllContributorsBot requires some features not available in the current version of octokit/rest in the latest version of probot (7.4.0)
Error: Cannot read property 'getRef' of undefined")

Describe the solution you'd like
We need to bump the version of the octokit/rest api in probot

Describe alternatives you've considered
Cloning the repo locally and using git directly (instead of via github).

Additional context
Looks like the probot team is on it: probot/probot#774

Usernames with brackets crash the bot

Describe the bug
@allcontributors[bot] add allcontributors[bot] for doc

To Reproduce
screen shot 2019-01-15 at 1 37 23 am

Expected behavior
To add a PR to add the user with brackets

Additional context
From sentry:
HttpError: refs/heads/all-contributors/add-allcontributors[bot] is not a valid ref name.

Looks like its trying to create the branch/ref with invalid semantics. The name for the branch will need to be escaped.

The bot is spamming when asked a question

Describe the bug
The bot is spamming when asked a question
Expected behavior
No spam

Screenshots
screen shot 2019-01-21 at 2 45 17 pm

Additional context
Recently switched to sync worker on webhooks, passing all tasks to long run lambda πŸ€”

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.