Add support for `commitTemplate` configuration

[AnandChowdhary]

Add support for `commitTemplate` configuration

[Berkmann18]

This is the one arguing about not having proper Angular conventional commits inside my PR and I think that this is no longer the case with this change.

Ah, I see, so more of a GH Action issue then 🤔.

Though adding a scope to the bot commit like docs(contributors): ... does not seem to be a bad idea but I am not well placed to know if there is a possible drawback.

AFAIK, there won't be any issues caused by adding the scope especially when SR-maintained changelogs usually omit docs changes.

[C0ZEN]

Ah, I see, so more of a GH Action issue then 🤔.

Exactly.

AFAIK, there won't be any issues caused by adding the scope especially when SR-maintained changelogs usually omit docs changes.

Very nice then. 💯

[AnandChowdhary]

I now see that commitTemplate is a CLI argument, which may be used for this. However, this is not documented anywhere.

[AnandChowdhary]

Quick update: Adding commitTemplate to .all-contributorsrc does not change the commit message done by the bot. Perhaps because this option is not passed to the CLI config?

[AnandChowdhary]

Some quick Sourcegraph that might help with debugging:

1. In all-contributors-cli/src/util/git.js#L65, options.commitTemplate || commitTemplate is used, so if commitTemplate is part of the passed options, it should work.
2. This function is called by the CLI in all-contributors-cli/src/cli.js#L76, using the arguments provided by yargv in all-contributors-cli/src/cli.js#L176.
3. Now we just need to make sure that the bot passes commitTemplate to the CLI as an argument that yargv can pick up.

[Berkmann18]

Thanks for raising the issue.
Have you had the chance to look into fixing that in a PR?

[C0ZEN]

+1.

This would be awesome because I use Semantic Pull Request action and the bot's commit are not validated.
See for example this PR failing.

[Berkmann18]

@C0ZEN Even with commitConvention set to the right commit convention (e.g. angular)?

[C0ZEN]

@Berkmann18 yes, my project is configured with the Angular commit convention.
I think that the issue here is the absence of scope even if it is optional inside the Commit Message Format.
So this has nothing to do with this repository - even if adding a scope to the commits would be better from my point of view and would fix my issue also -.

[C0ZEN]

@Berkmann18 I was about to open an issue inside Semantic Pull Request repository then I just remembered that I did override the default prefixes... 😞
And the docs prefix is not allowed.
I will make the changes but I am confident about resolving the issue.
Sorry for the wrong lead.

[Berkmann18]

even if adding a scope to the commits would be better from my point of view and would fix my issue also -.

Yeah, that's a good point.

docs prefix is not allowed.

Not allowed where? It works with SR in projects with the Angular commit convention.

[C0ZEN]

@Berkmann18 I did not test it yet but I changed the configuration of my project to allow the type docs for the Semantic Pull Request action installed.
This is the one arguing about not having proper Angular conventional commits inside my PR and I think that this is no longer the case with this change.
So I think that I do not have a problem anymore and no need to change anything on this repository.

Though adding a scope to the bot commit like docs(contributors): ... does not seem to be a bad idea but I am not well placed to know if there is a possible drawback.