ana06/get-changed-files

Get all of the files changed/modified in a pull request or push's commits.

get-changed-files's Issues

File contains a space

I'm moving a repo from a custom cookiecutter hook to the native support for jinja in filenames. Hopefully eventually to move from cookiecutter to copier. And ninja in filenames == required spaces. Things like if ... must have a space in it. The end result doesn't have spaces, but the files do. How hard would it be to add support for spaces (and pretty much all other windows-supported characters)?

[Feature] Filter : include/exclude

Hello @Ana06 ,

I've looked at the code already and I see that the filtering implementation is leveraging regex to filter files.
I have a particular case that would require include a certain type of files but also exclude specific paths at the same time.
ie:

• blah/test/something.yml
• blah/not_at_test/something_else.yml
• blah/another_folder/something.yml
• blah/another_folder/something_not_a_yaml.j2

So I need to match all *.yml, but not *.yml that are in a test folder for example.
Now, while I undertsand I could make a convoluted regex to do that, I would also want to keep it simple.

Would you welcome a change where we change the filter by include and exclude both supporting regex, and add a bit more code logic?

I'd be willing to have a poke at it.

Thanks,

`set-output` is deprecated

Hello @Ana06,

First of all, thanks for this awesome Action, we are using it actively.

We realized that Github Actions is going to deprecate some features used by your action, so I would like to know if you could adapt to theuir proposed changes.

Check:

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I would open a PR, but I have little experience with JavaScript or how this works.

Thanks a lot

Node.js 12 actions are deprecated.

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: Ana06/get-changed-files

Node.js 16 actions are now deprecated. Should be updated to Node.js 20

Node.js 16 actions are deprecated, when running this action, a warning is now displayed.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Ana06/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

A suggestion on unsupported events

Hello !

First thanks for adapting this from the original code much appreciated !

I've run into cases where I use this action in a workflow that can run on events other than push and pull_request and it makes the whole workflow fail.

I have an other action which just indicates it does not support the event in the log and skips the execution of the code.

Do you think it's something that could be added to the code ?

Cheers

Filter does not appear to use GitHub action syntax

I'm sorry that I can't give a detailed description, but it appears as though the filter "*.rs" matches the file errors.py (with emphasis: erro rs .py), which shouldn't happen with the GitHub action syntax. Am I missing something here? The only solution to achieve what I wanted was to use "*.rs$" instead.

Error: "Not Found" when pushing a new branch

Hi @Ana06, do you think it's possible to have a solution for this issue?
jitterbit#10

It also appears on this fork as well

Please update to use Node.js 20 (otherwise you get warnings when executing it)

merge_job
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Ana06/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Could you please fix it?

"Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: Ana06/[email protected]" + "The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files."

When using this action, you now get these two error messages:

Via jitterbit#65 it seems that https://github.com/masesgroup/retrieve-changed-files updated the original action to make these go away - so maybe this here can be "rebased" on that one.