Giter Site home page Giter Site logo

Comments (4)

antfu avatar antfu commented on August 24, 2024

The reason we were doing this is because we want to be compatible with the ThemedToken interface (altering color from string to object will break the other tool), while merging all colors into color as a flat string might not be flexible enough.

Can you elaborate more about your usage? If it's a valid concern, we could introduce an additional utility for it maybe.

from shikiji.

fuma-nama avatar fuma-nama commented on August 24, 2024

Since the codeToHast and codeToHtml methods both support multiple(light/dark) themes, codeToThemedTokens should have supported it too, for a better API consistency.

Takes an example of a custom code block in React.js:

export function CodeBlock({ code, lang, className, ...props }: CodeBlockProps) {
  const tokens = useMemo(
    () =>
      highlighter.codeToThemedTokens(code, {
        lang
      }),
    [code]
  )

  return (
    <Pre className={cn('bg-black', className)} {...props}>
      <code className="grid">
        {tokens.map((token, i) => (
          <span data-line key={i}>
            {token.map((s, j) => (
              <span key={j} style={{ color: s.color }}>
                {s.content}
              </span>
            ))}
          </span>
        ))}
      </code>
    </Pre>
  )
}

Obviously if we use codeToTokensWithThemes here, we must preprocess the returned array on our own, to combine to all variants of a node into one. Otherwise, the simplest solution is to render a code block for individual themes, which is not ideal in terms of bundle size.

Although I ended up implementing my own function to flatten nodes, the codeToTokensWithThemes API itself is not well-documented and straightforward enough (feels like a hacky way to me). Would appreciate it if thereโ€™s an additional utility to make it more convenience.

from shikiji.

antfu avatar antfu commented on August 24, 2024

I wonder what prevents you from using codeToHast directly for rendering the nodes?

from shikiji.

fuma-nama avatar fuma-nama commented on August 24, 2024

That would be a great solution, I initially missed it because codeToThemedTokens seemed to be more straightforward for me when comes to be rendering and animating it. Hast nodes are not typed and I was unsure of its properties, they are pretty enough for normal code blocks though

from shikiji.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.