ThemeRegistration type isn't compatible with VS Code theme schema

[antfu]

ThemeRegistration type isn't compatible with VS Code theme schema

[antfu]

Most of them are not required. TextMeta theme does not usually care about background and default foreground color; colors are for VS-Code-specific colors (the color of panels, borders etc); name and displayName are just metadata; When bg and fg are not provided, we will try to look from settings, otherwise will fallback to default value. The other types are there to be compatible with other integrations but are not used by Shikiji itself.

[gdomingu]

Here is an example of the type error.

is missing the following properties from type 'ThemeRegistration': name, settings, fg, bg ts(2739)

If name and displayName are just metadata and bg and fg have fallbacks could we mark those properties as optional in the shikiji type?

[antfu]

You should use ThemeRegistrationRaw for that

[gdomingu]

It doesn't look like ThemeRegistrationRaw has properties type, $schema, or colors.