Comments (23)
maybe should provide a message in that empty space: Analysis on this grant is not available
from researchmap.
Should it scroll down and show the message down there?
In that case, the user has to scroll up again to choose another award proposal.
from researchmap.
I don't think it really matters. Whatever is easiest. It's just for the demo. We'll tell Kamran to click only on the black squares anyway.
from researchmap.
Ok I will disable Non-analyzable awards, but I guess it will slow the double-click reaction because for each dbl-click I should check if the selected grant is analyzable or not.
from researchmap.
If it is possible to assign two classes, or something like that, then once the first function is called and returned, we can assign a class to all those awards and solve this issue this way.
Otherwise, we can add a boolean flag and set it to 1 once that award is analyzable (based on the result of the first function).
Hence dbclick checks for flag==1.
from researchmap.
OK I will do it after loading treemaps (it increase the loading time around 4sec in my laptop but it happen only at the beginning)
from researchmap.
I think a lot of objects that are loading at the beginning are not necessary, and thus creating that lag at the start. Maybe those should also go.
About the first function call, also maybe we can call it when the page is loaded (at the end of the page load) and run the code in background to find those awards that need to be highlighted as black. Then once the user clicks the checkbox, we do not need to wait anymore.
from researchmap.
That is true but the problem is java-script works in parallel way and I really do not know when the treemap loading finish. And I cannot start this process before loading treemap.
We can find end of loading by making a callback functions but it requires to change large parts of code. So I cannot do it after loading treemaps (my previous comment does not work). I have to handle it in double-click.
Also, it cannot run in background because it freeze the screen.
from researchmap.
Done, but I could not test it.
from researchmap.
We still don't show that message, and the previous analysis is not cleared from the page:
from researchmap.
I think it is not necessary to show a message for Non-analyzable awards. I just deactivated the double-click. And we should not clean the screen after double-click on inactive award.
from researchmap.
but the user should have some way to know what's going on. otherwise it is confusing...
from researchmap.
When you choose an award (that is non-analyzable, as you can see in the picture), that award also gets yellow-highlighted. If you have not yet selected a black award, then you are not scrolled down yet and everything is fine. However the user dbclicks and nothing happens (no feedback).
On the other hand, if you have previously selected a black award, and hence are scrolled down, if you select a non-black award now, it again gets yellow, but nothing happens and the result of an analysis is on the screen.
There should be something that informs the user that this award returns no analysis. Otherwise, performing the same action in these two scenarios leaves the user with two different screens, which is confusing.
from researchmap.
Ok it makes sence. now I have two option to handle it in my mind.
1- Goto analysis panel and show a message there.
2- pop out a message on double-click which state that selected award is not analyzable.
which one?
from researchmap.
I know that you're not a fan of pop-ups (and if pop-up is blocked on a machine it won't show up).
Scrolling down also has it's drawbacks, since the user has to go up again to select another award.
I vote for #1 from your choices. Let's wait for @pparsons to come back from lunch ;)
from researchmap.
@pparsons we are waiting for you to cast a vote!
from researchmap.
i think 1 is okay
from researchmap.
Done
from researchmap.
For non-analyzable awards, we still do not clean the analytics panel, and we still do not show the required message.
from researchmap.
We do, at least if my code works correctly it should goto analysis panel and show "Your selected award is not analysable"
from researchmap.
Just tried it with latest version and nope!
Also on dbclick on non analyzables, we do not empty the panel.
from researchmap.
It had a small bug. Now it should works
from researchmap.
👍
from researchmap.
Related Issues (20)
- grant circle size and amount HOT 5
- Message box when award is not analyzable, or when _error is 1 HOT 2
- error after deselecting co-authors HOT 12
- Inactive Publications Keywords Not Showing HOT 16
- Wrong parameters on function calls HOT 4
- Removing all authors/keywords HOT 11
- publication info for analysis view HOT 10
- publication years not correct in analysis view HOT 13
- submit button stays after switching grants HOT 11
- investigator-author mismatch HOT 9
- keyword matching blank view HOT 4
- Parameters not showing change in results HOT 2
- Remove Analysis_test branch HOT 1
- password is too easy to hack HOT 10
- Package.json jQuery HOT 11
- Award related information box HOT 33
- Consistency problem with the list of co-authors HOT 17
- Commit: Increase the gap between grant and publications to fix overlap #1 HOT 17
- Broken view after latest commits on December 31 at around 19:55 HOT 18
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from researchmap.