Non-analyzable awards

[arashsoft]

Non-analyzable awards

[pparsons]

maybe should provide a message in that empty space: Analysis on this grant is not available

[armandidandeh]

Should it scroll down and show the message down there?
In that case, the user has to scroll up again to choose another award proposal.

[pparsons]

I don't think it really matters. Whatever is easiest. It's just for the demo. We'll tell Kamran to click only on the black squares anyway.

[arashsoft]

Ok I will disable Non-analyzable awards, but I guess it will slow the double-click reaction because for each dbl-click I should check if the selected grant is analyzable or not.

[armandidandeh]

If it is possible to assign two classes, or something like that, then once the first function is called and returned, we can assign a class to all those awards and solve this issue this way.
Otherwise, we can add a boolean flag and set it to 1 once that award is analyzable (based on the result of the first function).
Hence dbclick checks for flag==1.

[arashsoft]

OK I will do it after loading treemaps (it increase the loading time around 4sec in my laptop but it happen only at the beginning)

[armandidandeh]

I think a lot of objects that are loading at the beginning are not necessary, and thus creating that lag at the start. Maybe those should also go.

About the first function call, also maybe we can call it when the page is loaded (at the end of the page load) and run the code in background to find those awards that need to be highlighted as black. Then once the user clicks the checkbox, we do not need to wait anymore.

[arashsoft]

That is true but the problem is java-script works in parallel way and I really do not know when the treemap loading finish. And I cannot start this process before loading treemap.
We can find end of loading by making a callback functions but it requires to change large parts of code. So I cannot do it after loading treemaps (my previous comment does not work). I have to handle it in double-click.

Also, it cannot run in background because it freeze the screen.

[arashsoft]

Done, but I could not test it.

[armandidandeh]

We still don't show that message, and the previous analysis is not cleared from the page:

[arashsoft]

I think it is not necessary to show a message for Non-analyzable awards. I just deactivated the double-click. And we should not clean the screen after double-click on inactive award.

[pparsons]

but the user should have some way to know what's going on. otherwise it is confusing...

[armandidandeh]

When you choose an award (that is non-analyzable, as you can see in the picture), that award also gets yellow-highlighted. If you have not yet selected a black award, then you are not scrolled down yet and everything is fine. However the user dbclicks and nothing happens (no feedback).

On the other hand, if you have previously selected a black award, and hence are scrolled down, if you select a non-black award now, it again gets yellow, but nothing happens and the result of an analysis is on the screen.

There should be something that informs the user that this award returns no analysis. Otherwise, performing the same action in these two scenarios leaves the user with two different screens, which is confusing.

[arashsoft]

Ok it makes sence. now I have two option to handle it in my mind.
1- Goto analysis panel and show a message there.
2- pop out a message on double-click which state that selected award is not analyzable.
which one?

[armandidandeh]

I know that you're not a fan of pop-ups (and if pop-up is blocked on a machine it won't show up).
Scrolling down also has it's drawbacks, since the user has to go up again to select another award.

I vote for #1 from your choices. Let's wait for @pparsons to come back from lunch ;)

[armandidandeh]

@pparsons we are waiting for you to cast a vote!

[pparsons]

i think 1 is okay

[arashsoft]

Done

[armandidandeh]

For non-analyzable awards, we still do not clean the analytics panel, and we still do not show the required message.

[arashsoft]

We do, at least if my code works correctly it should goto analysis panel and show "Your selected award is not analysable"

[armandidandeh]

Just tried it with latest version and nope!

Also on dbclick on non analyzables, we do not empty the panel.

[arashsoft]

It had a small bug. Now it should works

[armandidandeh]

👍