Giter Site home page Giter Site logo

Comments (7)

EugenMayer avatar EugenMayer commented on May 25, 2024 1

Thanks for coming back to this, but since i forked of, i did not want to invest here, someone lese should so it makes sense for you to put work into that.

I assume that it is the right call to let it where it is until someone else need it, which i entirely cannot understand i this should not be the case ( IMHO ). Thanks

from concourse-slack-alert-resource.

EugenMayer avatar EugenMayer commented on May 25, 2024

Considering that you have all the meta-data already in https://github.com/arbourd/concourse-slack-alert-resource/blob/master/concourse/build.go#L42 this seems to be an easy job. sure we jsut should use gotemplate for the template langauge {{}} but other then that, that might be close to a one liner

from concourse-slack-alert-resource.

arbourd avatar arbourd commented on May 25, 2024

When I first conceived this resource, I never really wanted (or considered) templating. It's a possibility but it's a large overhaul at the moment. I think one way this can be solved in the future is with #36 to allow custom messages to be set.

from concourse-slack-alert-resource.

EugenMayer avatar EugenMayer commented on May 25, 2024

Well setting the message by file and using template placeholders are not the same thing, but for sure expanding templates which are from files the same way would make sense.

So i would say that those are 2 entirely different features which may though be enriched by this, being it a normal string message or a file based one

from concourse-slack-alert-resource.

arbourd avatar arbourd commented on May 25, 2024

Maybe if we only exposed the BUILD variables that would be okay because they aren't available in tasks.

from concourse-slack-alert-resource.

arbourd avatar arbourd commented on May 25, 2024

@EugenMayer Where would you want these custom links anyways? They already exist in the footer.

from concourse-slack-alert-resource.

arbourd avatar arbourd commented on May 25, 2024

I'm assuming for the time being that you wanted this because of Mattermost, but the link does exist for Slack at the current time. I'm going to close this for now unless there is another reason why we might want those variables.

from concourse-slack-alert-resource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.