Comments (6)
i think you are most probably right, if you are not interested in having this one supporting both a dedicated way, i might just for your project for mattermost. I love the way you architectured it, it's already go and not some bashism like most other slack resources - lovely.
But before i fork, i usually talk to the author to see if forking or sticking heads is the best way - both ways are legitimate.
Thanks for your effort!
from concourse-slack-alert-resource.
checking https://github.com/arbourd/concourse-slack-alert-resource/blob/master/out/alert.go i cannot see how this is actually the case ever? Seeing the screenshots in the readme it seems to be the case though. Am i missing something?
from concourse-slack-alert-resource.
Ok if found
- https://github.com/arbourd/concourse-slack-alert-resource/blob/master/concourse/build.go#L52
- which is then consumed in https://github.com/arbourd/concourse-slack-alert-resource/blob/master/out/main.go#L21
And footer is part of the payload i guess ( and might not be properly supported by mattermost )
from concourse-slack-alert-resource.
Yes, found the official statement for that: https://docs.mattermost.com/developer/message-attachments.html#known-issues
Asking myself if:
- introducing a new
source
optionapi_type
which is be default of courseslack
but can be set tomattermost
- the use
title_link
for the link option
I understand this could probably become fairly spagetty and considering how this resource is named, maybe not perfect either.
On the other side, the link is probably the only reason one would reconsider using this resource for mattermost - other then that it is plain awesome.
Maybe even addig title_link
in general, without a switch, would work, since Slack will most probably just ignore that field
from concourse-slack-alert-resource.
I don't want to support Mattermost, as this is built for Slack first and foremost. Feel free to fork this and make a Mattermost alert resource :)
If you have any suggestions that work for both Slack and Mattermost that's okay too, but I don't want to support two APIs at the same time.
from concourse-slack-alert-resource.
Thanks for understanding and I appreciate the nice comments :D
from concourse-slack-alert-resource.
Related Issues (20)
- Instance vars with an array panics the resource HOT 4
- version is missing from previous step HOT 2
- This resource is compatible with mattermost HOT 3
- Provide some basic template variable expansion? HOT 7
- latest docker image tag is broke HOT 2
- Need ability to mark slack server as insecure HOT 2
- fixed/broke AUTH not working with oauth2/oidc HOT 4
- Broken OAuth in fixed/broke notifications for Concourse >= 6.0 HOT 8
- Error Authenticating with Concourse 6.5.0 HOT 6
- Dependabot can't resolve your Go dependency files
- Encountering 'Invalid client credentials' in Concourse 6.0 HOT 8
- Message param does not recognize concourse parameters HOT 2
- Require image for ARM64 architecture HOT 3
- fixed/broke AUTH not working with oauth2 HOT 7
- Alert types `fixed` and `broke` fail for instanced pipelines with `error getting last build status: error requesting Concourse build status: unexpected status code: 404` HOT 9
- can we use env vars in message and text ?
- put command HOT 2
- Looking for a new maintainer HOT 3
- Add retry logic for Slack http requests HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from concourse-slack-alert-resource.