Giter Site home page Giter Site logo

Comments (6)

EugenMayer avatar EugenMayer commented on May 23, 2024 1

i think you are most probably right, if you are not interested in having this one supporting both a dedicated way, i might just for your project for mattermost. I love the way you architectured it, it's already go and not some bashism like most other slack resources - lovely.

But before i fork, i usually talk to the author to see if forking or sticking heads is the best way - both ways are legitimate.

Thanks for your effort!

from concourse-slack-alert-resource.

EugenMayer avatar EugenMayer commented on May 23, 2024

checking https://github.com/arbourd/concourse-slack-alert-resource/blob/master/out/alert.go i cannot see how this is actually the case ever? Seeing the screenshots in the readme it seems to be the case though. Am i missing something?

from concourse-slack-alert-resource.

EugenMayer avatar EugenMayer commented on May 23, 2024

Ok if found

And footer is part of the payload i guess ( and might not be properly supported by mattermost )

from concourse-slack-alert-resource.

EugenMayer avatar EugenMayer commented on May 23, 2024

Yes, found the official statement for that: https://docs.mattermost.com/developer/message-attachments.html#known-issues

Asking myself if:

  • introducing a new source option api_type which is be default of course slack but can be set to mattermost
  • the use title_link for the link option

I understand this could probably become fairly spagetty and considering how this resource is named, maybe not perfect either.

On the other side, the link is probably the only reason one would reconsider using this resource for mattermost - other then that it is plain awesome.

Maybe even addig title_link in general, without a switch, would work, since Slack will most probably just ignore that field

from concourse-slack-alert-resource.

arbourd avatar arbourd commented on May 23, 2024

I don't want to support Mattermost, as this is built for Slack first and foremost. Feel free to fork this and make a Mattermost alert resource :)

If you have any suggestions that work for both Slack and Mattermost that's okay too, but I don't want to support two APIs at the same time.

from concourse-slack-alert-resource.

arbourd avatar arbourd commented on May 23, 2024

Thanks for understanding and I appreciate the nice comments :D

from concourse-slack-alert-resource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.