argelius/react-onsenui-redux-weather

Onsen UI sample app using Redux and React

react-onsenui-redux-weather's Issues

Monaca CLI

It would be great if you add support for monaca cli

How to build it ?

Hello, I liked the app. I've downloaded and I'm able to run it locally with the commands on README. I would like to know how to build this in two ways: 1. Integrate with https://monaca.io/ 2. Build by cordova.

Thanks in advance if you can help me.

Build failed, @import 'onsenui/stylus/components

npm install
nom start

ERROR in .//css-loader!.//postcss-loader!./~/stylus-loader?paths=node_modules!./stylus/index.styl
Module build failed: Error: reWeather/stylus/index.styl:69:9
65| $material-tabbar-highlight-color = #26a69a
66| $fab-text-color = #ffffff
67| $fab-background-color = #13bde2
68|
69| @import 'onsenui/stylus/components'
---------------^
70|
71| .list__item__subtitle
72| opacity 1

failed to locate @import file onsenui/stylus/components.styl

Error running npm start

Hi All,

just cloned this repo and ran 'npm start' after 'npm install'. Its failing with this:

ERROR in .//css-loader!.//postcss-loader!./~/stylus-loader?paths=node_modules!./stylus/index.styl
Module build failed: Error: /Users/ishtiaquelatif/Desktop/atb/atb-onsen/stylus/index.styl:69:9
65| $material-tabbar-highlight-color = #26a69a
66| $fab-text-color = #ffffff
67| $fab-background-color = #13bde2
68|
69| @import 'onsenui/stylus/components'
---------------^
70|
71| .list__item__subtitle
72| opacity 1

failed to locate @import file onsenui/stylus/components.styl

Any help on where 'onsenui/stylus/components.styl' is or how I can get try this boilerplate? Thanks in advance

React Router

Hi @argelius I don't see any example with React Router as you have mentioned in package.json.
It'd be great if you could provide one.

Navigator route stack is not connected to Redux state

It looks like in this app the navigator route stack and the redux state are independently controlled, which seems not to match the redux paradigm as far as I understand it.

For example, running the demo using the Redux DevTools plugin, the following steps produce an error:

1. Start the demo clean
2. Click 'Tokyo'
3. In Redux DevTools, step backwards in the state history (undoing the SELECT_LOCATION action)

That causes a TypeError at WeatherPage.js:95, where country is now undefined but it's attempting to render the WeatherPage anyway because nothing has changed the Navigator's route stack. Since we've undone SELECT_LOCATION, the app should render as though no location was selected, meaning that we should return to the LocationList and WeatherPage should be disconnected. It seems like "what page we're on" should be saved in the app's state, and somehow changes to that part of the state should cause the routes to change.

Another example:

1. Start the demo clean
2. Click 'Tokyo'
3. Click the back icon

In Redux DevTools, note that the navigation change did not trigger an action. The app's state does not reflect the currently-selected page, so if the app were preloaded with this state, we wouldn't be looking at the LocationList, we'd still be looking at Tokyo.

We're supposed to keep all of the app's state in the store. This is something I'm struggling with in my own app, and I don't know yet whether this can be solved with Onsen UI's Navigator, at least as available in the React API. There doesn't appear to be a way to change the route externally, though I might be missing something. I don't consider this a bug in the Weather App as a user would see it, but it's either a paradigmatic problem with the code (if it is possible to fix), or a problem with OnsenUI's Navigator (if not).