armanbilge/porcupine

Skunk-inspired library for SQLite on JVM, Node.js, and Native

porcupine's Issues

"Index out of bounds" when placeholder is repeated

May be I'm holding it wrong, but here's the repro:

//> using lib "com.armanbilge::porcupine::0.0.1"

import porcupine.*, Codec.*
import cats.effect.*

object app extends IOApp.Simple:
  def run =
    Database.open[IO]("test.db").use { db =>
      db.execute(
        sql"drop table if exists help;".command
      ) *>
        db.execute(
          sql"create table if not exists help(id integer primary key not null, test text)".command
        ) *>
        db.unique(
          sql"insert into help(id, test) values ($integer, $text) returning id * 100"
            .query(integer),
          25L -> "howdy"
        ).flatMap(IO.println) *> // OK
        db.unique(
          sql"begin; update help set test = 'bye' where id = $integer; insert into help(id, test) values ($integer, $text); commit;".command,
          (25L, 25L, "howdy")
        ).flatMap(IO.println) // NOT OK
    }

Output:

2500
java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
	at org.sqlite.core.CorePreparedStatement.batch(CorePreparedStatement.java:105)
	at org.sqlite.jdbc3.JDBC3PreparedStatement.setLong(JDBC3PreparedStatement.java:299)
	at porcupine.DatabasePlatform$$anon$1$$anon$2.cursor$$anonfun$1$$anonfun$1(dbplatform.scala:50)
	at main$ @ app$.main(test.scala:6)
	at main$ @ app$.main(test.scala:6)
	at main$ @ app$.main(test.scala:6)

Consider special-casing "database is locked" exception

Differentiating this particular error condition from sqlite from all other errors (foreign keys, constraints, schema mismatch) is important, because the usual response to it is to retry.

So it would make sense to give these types of errors an ADT but still surface them to the user immediately as they occur

Use `fs2.concurrent.Channel` for interacting with SQLite

By redirecting through a Channel we can ensure that queries are handled on a persistent blocking instead of forcing the query to always block the current thread.