Patch struct causes errors when making requests

[arnavion]

Patch struct causes errors when making requests

[Arnavion]

As a workaround until then, you can take the http::Request<Vec<u8>> that you get from Ingress::patch_namespaced_ingress and replace its body with a body containing a serde_json::Value of your choice.

[Arnavion]

With 36334e6, Patch is now emitted as the enum I showed above, and all operations set the Content-Type header in the generated request.

[Arnavion]

This was fixed in 79185b3 It'll be in 0.5.0

[JoshMock]

Thank you @Arnavion! I'll give this a shot.

[Arnavion]

Note that you'll also need to set the Content-Type header to one of application/json-patch+json, application/merge-patch+json or application/strategic-merge-patch+json depending on what type of patch you're sending.

---

These are listed in the spec but I can't think of a way to easily surface this choice to the API user. Maybe something like

-struct Patch(serde_json::Value);
+enum Patch {
+    Json(serde_json::Value),
+    Merge(serde_json::Value),
+    StrategicMerge(serde_json::Value),
+}

and then have every API operation that takes a &Patch have special codegen.

It does look like patch operations are the only place where this kind of Content-Type choice matters, and it's always these three types, so it doesn't seem like a bad idea to have special codegen for it...