affordances for the toggle-modes menu (checkboxes)

[lansingthomas]

affordances for the toggle-modes menu (checkboxes)

[aadcg]

I think that this is a general issue, and not only related to toggle-modes.

The general formulation of the issue then becomes: how do we display marked suggestions in the prompt buffer? As of today, we use theme:secondary as a background color for the marked suggestion.

The proposed solution is to add checkboxes in addition to the background color. Then, we must justify the need for a second solution to achieve the goal.

I'm leaning towards thinking that the background color suffices and that the checkboxes will amount to visual clutter, but I'm happy to be convinced otherwise! CC @jmercouris.

[jmercouris]

I think the checkboxes are an easy way for people to understand what is and is not selected. It is in my opinion superior to simply a color. If you overcommunicate something visually, it is probably better than undercommunicating it.

[aadcg]

On second thoughts, I'm convinced. It will also help users mark suggestions with the mouse. There's an important requirement: when prompter:enable-marks-p is t, all suggestions must have empty checkbox as soon as the prompt buffer pops up.