Ignore single key binding (in CUA mode) in text inputs

[MaxGyver83]

Ignore single key binding (in CUA mode) in text inputs

[aadcg]

@MaxGyver83 could you open two issues on that? Just copy and paste. I think that the modality of VI mode is lacking.

[MaxGyver83]

New issues: #3190 and #3191.

[jmercouris]

What you need are modal bindings. For this reason either you can model your own mode off of vi, or you can make your mode aware of the state. I think it is easier to just modify the vi bindings to suit you :-)

[MaxGyver83]

But how is it possible that it works for the n in the CUA keybindings? Is this modal, too?

[MaxGyver83]

OK, I have searched the source code: the n keybindings is only valid in help-mode:

nyxt/source/mode/help.lisp

Line 20 in 3cb7dcc

"n" 'nyxt/mode/document:next-heading

[MaxGyver83]

I think it is easier to just modify the vi bindings to suit you :-)

It doesn't sound so easy to me. How would I do this practically? The best way I can come up with is to grep the source/mode directory of the repository for all lines between keyscheme:cua and keyscheme:emacs (hoping that it's always in this order) and add them to the configuration snippet above.

[MaxGyver83]

This way I can get all CUA keybindings:

cd ~/repos/nyxt/source/mode
fd -e lisp -d 1 -x awk '/:cua/,/:emacs/' | rg '^ +"' | tr -d ')' | sort

I have tried it. But actually I don't want to have a normal mode when I enter text. I'd rather use no single-key bindings.

[jmercouris]

I really don't understand what your end state is, sounds like you'll need to write a rather extensive configuration. Sorry about that :-(, we can try to help when we have some time.

[MaxGyver83]

Thank you! I also want to understand better how the keybindings (and Common Lisp in general :-) ) work. Maybe it's somehow possible to detect when a text input has focus and have a mode that gets disabled then.

[jmercouris]

That's exactly what vi mode does!

[MaxGyver83]

I have changed this in the source code:

diff --git a/source/mode/vi.lisp b/source/mode/vi.lisp
index d2b0409b7..ec4281c7d 100644
--- a/source/mode/vi.lisp
+++ b/source/mode/vi.lisp
@@ -22,10 +22,10 @@ the web page.

 See also `vi-insert-mode'."
   ((glyph "vi:N")
-   (keyscheme keyscheme:vi-normal)
+   (keyscheme keyscheme:cua)
    (keyscheme-map
     (define-keyscheme-map "vi-normal-mode" ()
-      keyscheme:vi-normal
+      keyscheme:cua
       (list
        "i" 'vi-insert-mode
        "v" 'nyxt/mode/visual:visual-mode)))))

And this in my config.lisp:

(define-configuration buffer
  ((default-modes
    (pushnew 'nyxt/mode/vi:vi-normal-mode %slot-value%))))

(define-configuration base-mode
  "Bind some custom keys in CUA map."
  ((keyscheme-map
    (keymaps:define-keyscheme-map "custom" (list :import %slot-value%)
      nyxt/keyscheme:cua
      (list
       "f" 'nyxt/mode/hint:follow-hint
       "{" 'previous-heading
       "}" 'next-heading)))))

This is close to what I want. But I always have to change to vi-insert mode after C-space. When I enter text inputs in HTML documents, I'm directly in insert mode. But I couldn't find a way to unfocus without using the mouse. Escape just switches to vi-normal mode. Sometimes I can't scroll with the arrow keys after unfocusing with a mouse click. Sometimes I can't focus the text input with Alt-i anymore.

[aadcg]

My personal conclusion on this issue follows.

All default keyschemes could have been modal since the web factors into two modes, a mode for input and another for non-input. Instead, we decided that vi is the only default modal keyscheme that follows that strategy. CUA's case is debatable since modality could trip users. On the other hand, I believe it would be more efficient and our users could have embraced the idea.

@MaxGyver83 I still think that you're be better off using the vi keyscheme and binding commands to your personal preferences in the config file. You're going against the tide by trying to make CUA modal, see #2956.

[MaxGyver83]

I still have two issues with using the vi keyscheme:

1. When I type f (to follow links), I can't type the hint letters next. The prompt ("Interact with element") is in normal mode then and I have to switch to insert mode first, before I type the hint letters. What's the benefit of normal mode in such a case? Is this configurable?
2. When I focus a text input on a web page with Alt+i, I'm directly in insert mode and can enter some text. But then I'm caught in this text input. How can I unfocus (without using the mouse)? Esc brings me to normal mode but never out of the text input.