Giter Site home page Giter Site logo

Comments (3)

anacierdem avatar anacierdem commented on July 2, 2024 2

This is by design. See the selector docs here as well. The output of the selectors undergo a shallow equality check. I also missed this previously when I opened this issue and proposed that maybe exposing the equality function might be useful. On the other hand at this point I'm pretty much convinced that keeping it opinionated is safer for the health of the library.

from react-sweet-state.

albertogasparin avatar albertogasparin commented on July 2, 2024 1

From a dev expectation pov, 99% of the times selectors returning same data wrapped in a different object instance mean nothing has changed. So a re-render is pointless. I understand that there might be cases where this behaviour is unwanted, but the workaround is fairly simple and cheap (as you described, just add a nested object) that I feel expanding the API has not much value.
However if you feel like docs should make a better job highlighting this behaviour, I welcome suggestions 😉

from react-sweet-state.

bcytrowski avatar bcytrowski commented on July 2, 2024 1

I totally agree with you guys - I just shared my observations of a dev coming from redux/reselect world. I believe aligning the current behavior with react-redux useSelector would be a breaking one. I'm totally fine with the outcome of this thread and the workaround is perfect for me :) Thanks

from react-sweet-state.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.