Giter Site home page Giter Site logo

Comments (3)

theKashey avatar theKashey commented on July 20, 2024 1

Errors in general should not happen, but if they do - I think it's important to break things at the right place.

Personally - I prefer when things breaks and I "see" it, not then they break silently and I have to idea why UI became glitchy

from react-sweet-state.

albertogasparin avatar albertogasparin commented on July 20, 2024

Good observation, didn't realise that.
The difference is indeed that onInit is called as part of a hook initialisation while onUpdate is called by the subscription, so as part of the schedule/batching process.
I'm not sure however that onInit behaviour is what we should normalise. The reason is that being able to catch it via error boundary is possible only for sync actions. Async actions will always need to be manually caught.

So my worry is that devs might not realise they need an error boundary in the first place. I feel having an out of render error is slightly more annoying to catch but less fatal. And if you use async actions you need to manually handle it regardless.
But open to hear your counter arguments :)

from react-sweet-state.

obweger avatar obweger commented on July 20, 2024

Agree with @theKashey here - my philosophy is also that if something breaks, it should break fully.

For async actions @albertogasparin, I personally think it's fine for these to not trigger the error boundary; after all, I can also trigger any async stuff in a render function and it would also not trigger the error boundary.

My 2c.

from react-sweet-state.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.