Comments (3)
Errors in general should not happen, but if they do - I think it's important to break things at the right place.
Personally - I prefer when things breaks and I "see" it, not then they break silently and I have to idea why UI became glitchy
from react-sweet-state.
Good observation, didn't realise that.
The difference is indeed that onInit
is called as part of a hook initialisation while onUpdate
is called by the subscription, so as part of the schedule/batching process.
I'm not sure however that onInit
behaviour is what we should normalise. The reason is that being able to catch it via error boundary is possible only for sync actions. Async actions will always need to be manually caught.
So my worry is that devs might not realise they need an error boundary in the first place. I feel having an out of render error is slightly more annoying to catch but less fatal. And if you use async actions you need to manually handle it regardless.
But open to hear your counter arguments :)
from react-sweet-state.
Agree with @theKashey here - my philosophy is also that if something breaks, it should break fully.
For async
actions @albertogasparin, I personally think it's fine for these to not trigger the error boundary; after all, I can also trigger any async stuff in a render
function and it would also not trigger the error boundary.
My 2c.
from react-sweet-state.
Related Issues (20)
- Typescript: Can't use container without explicitly declared prop 'children' on it HOT 1
- [Documentation request] Comparison of bundle sizes HOT 2
- The useHook with selector does not trigger rendering properly HOT 3
- [Documentation request] - Example with Next.js SSR
- Possibly incorrect type definition for `ActionThunk` HOT 2
- Incorrect selector behaviour with promises
- Input caret will jump to end of string when using store HOT 4
- better type/name for dispatched actions HOT 1
- Persistent global scoped stores HOT 2
- "Families" containers HOT 7
- Ability to pass callback function during store creation for store initialisation and updates HOT 3
- Non global states HOT 4
- Container cleanup occurs after remounting, clearing state set by onInit HOT 1
- Hook mount/unmount time depends at number of hooks on page HOT 1
- New major HOT 2
- Move from .js to .ts HOT 1
- Uncaught TypeError: Cannot read properties of null (reading 'unsubscribe') HOT 6
- Unstable scheduling behavior
- Unexpected change in behaviour beween React 17 and 18 HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-sweet-state.