Comments (4)
So for reference we are talking about flushSync in react
.
Given the setState
interface is already analogous to react
then it's important to keep using react
paradigms as much as possible. To avoid confusion and to take advantage of existing familiarity with react
.
Having a function scope where the synchronous event occurs is useful in that arbitrary other operations can be located there be known to be synchronous.
In comparison the additional arguments on the setState()
is less elegant IMO. Fails interface segregation principle adding a bunch more "options" to achieve what can be done by composition.
from react-sweet-state.
You can also see this behaviour with the advanced-scoped-flow in it's stock form while using the input component.
from react-sweet-state.
Ha, good catch, I've never known of this gotcha. It's related to facebook/react#955
React tracks the cursor position only for sync re-renders 😞 so, since we moved RSS updates to be scheduled by default (even if with a duration of just one tick), it loses the cursor position.
Quite tricky. Not sure how to handle this 🤔
from react-sweet-state.
What do you think about a flushSync
API (similar to the react-dom v18 util) to force updates to be dispatched synchronously?
const actions = {
setName:
(name: string): Action<State> =>
({ setState }) => {
flushSync(() => {
setState({ name: name });
});
},
};
Or an alternative could be adding a second, optional argument to setState
:
const actions = {
setName:
(name: string): Action<State> =>
({ setState }) => {
setState({ name: name }, { sync: true });
},
};
from react-sweet-state.
Related Issues (20)
- The useHook with selector does not trigger rendering properly HOT 3
- [Documentation request] - Example with Next.js SSR
- Possibly incorrect type definition for `ActionThunk` HOT 2
- Incorrect selector behaviour with promises
- better type/name for dispatched actions HOT 1
- Persistent global scoped stores HOT 2
- "Families" containers HOT 7
- Ability to pass callback function during store creation for store initialisation and updates HOT 3
- Non global states HOT 4
- Container cleanup occurs after remounting, clearing state set by onInit HOT 1
- Hook mount/unmount time depends at number of hooks on page HOT 1
- New major HOT 2
- Move from .js to .ts HOT 1
- Uncaught TypeError: Cannot read properties of null (reading 'unsubscribe') HOT 6
- Unstable scheduling behavior
- Unexpected change in behaviour beween React 17 and 18 HOT 14
- Discussion: Should an error in onUpdate trigger the container's error boundary? HOT 3
- Using container on update hook causes React 16 errors to be printed HOT 5
- createActions helper HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-sweet-state.