auru/redux-unity-router

Router, that syncs history with store and provides React bindings

redux-unity-router's Issues

Merge routes data

Merge data from nested routes with their parents'

Using CMD/CTRL to open in new tab on <Link> doesn't work as expected

Rename Fragment

We should rename Fragment to except collision with Fragment from React 16.2

@TimeRaider @Blackheart340 what do you think about it?

Redirect fired before url parse

If you create Link to Fragment with some params in url and redirect property, you will get an error with param.name is undefined

Example:

// render of your component
<Link to={{ id: 'Task', params: { id: 42 } }} />

// router
const { params } = this.props; // select params from state

<Fragment id={'Task'} component={Task} redirect={{ id: 'TaskView', params }}>
     <Fragment id={'TaskView'} component={TaskView}/>
</Fragment>

Error happened because redirect fired by router before new url will be parsed.

Support basePath

Replace reducers on the fly with router

Tests needed

needs moar tests

Warning: Unknown props `activeMatch`, `activeClass` on <a> tag. Remove these props from the element.

introduced in 1374311

<Link> doesn't render when prop 'to' is changed

Error after go back

If you have required parameter in your route and you will try to go back. You'll get an error.
I'll try to investigate it later.

Error:

{name: "RouterError", message: "TypeError: Expected "hash" to be defined"}

auto-prefix root routes with '/'

SSR

[META] Split router into several packages

This is my 2.0.0 release proposal:

Split this package into 3 separate packages:

• redux-unity-router: syncs history with store
• redux-unity-router-react: provides react components
• redux-unity-router-example: example app showcasing the router

this will:

• decouple history logic from components, allowing custom react implementations
• reduce the package size
• independent test coverage and dependencies
• better treatment of examples

we can achieve this with lerna and semantic releases

thoughts?

history packages

@TimeRaider Hey, fellow.

We're using history package and two days ago was published new version 4.6.0.
And we've caught side effect linked with that.
We had components:

<Link to={{ id: 'Page', query: { paths: '/some/path' } }} />

And expected to get url /page?path=%2Fsome%2Fpath. But after patch we've got string like /page?path=%252Fsome%252Fpath. It's happening 'cause we're escaping string twice.

I thought the fastest solution would be fix version of that package on 4.5.1, but I don't think it's a good way.
Or we can remove escaping from our component, I mean .

It's up to you.

Imposible to import { actions } from module

import { actions } from 'redux-unity-router'; and import actions from 'redux-unity-router/actions'; both have undefined value. Seems that these modules don't exports properly.

README.md

Things to mention:
Hot to build paths
Check your paths

TypeScript definitions

Time-travel does not work

time-travel with redux dev-tools doesn't work

Version 10 of node.js has been released

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml
• The new Node.js version is in-range for the engines in 1 of your package.json files, so that was left alone

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

More information on this issue

Greenkeeper has checked the engines key in any package.json file, the .nvmrc file, and the .travis.yml file, if present.

• engines was only updated if it defined a single version, not a range.
• .nvmrc was updated to Node.js 10
• .travis.yml was only changed if there was a root-level node_js that didn’t already include Node.js 10, such as node or lts/*. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.

For many simpler .travis.yml configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴