auru / redux-unity-router Goto Github PK
View Code? Open in Web Editor NEWRouter, that syncs history with store and provides React bindings
Router, that syncs history with store and provides React bindings
introduced in 1374311
This is my 2.0.0 release proposal:
Split this package into 3 separate packages:
this will:
we can achieve this with lerna and semantic releases
thoughts?
needs moar tests
If you have required parameter in your route and you will try to go back. You'll get an error.
I'll try to investigate it later.
Error:
{name: "RouterError", message: "TypeError: Expected "hash" to be defined"}
import { actions } from 'redux-unity-router';
and import actions from 'redux-unity-router/actions';
both have undefined
value. Seems that these modules don't exports properly.
@TimeRaider Hey, fellow.
We're using history
package and two days ago was published new version 4.6.0
.
And we've caught side effect linked with that.
We had components:
<Link to={{ id: 'Page', query: { paths: '/some/path' } }} />
And expected to get url /page?path=%2Fsome%2Fpath
. But after patch we've got string like /page?path=%252Fsome%252Fpath
. It's happening 'cause we're escaping string twice.
I thought the fastest solution would be fix version of that package on 4.5.1
, but I don't think it's a good way.
Or we can remove escaping from our component, I mean .
It's up to you.
Things to mention:
Hot to build paths
Check your paths
To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:
.travis.yml
package.json
files, so that was left aloneIf you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.
Greenkeeper has checked the engines
key in any package.json
file, the .nvmrc
file, and the .travis.yml
file, if present.
engines
was only updated if it defined a single version, not a range..nvmrc
was updated to Node.js 10.travis.yml
was only changed if there was a root-level node_js
that didn’t already include Node.js 10, such as node
or lts/*
. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.For many simpler .travis.yml
configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
Merge data from nested routes with their parents'
We should rename Fragment to except collision with Fragment from React 16.2
@TimeRaider @Blackheart340 what do you think about it?
If you create Link
to Fragment
with some params in url and redirect property, you will get an error with param.name is undefined
Example:
// render of your component
<Link to={{ id: 'Task', params: { id: 42 } }} />
// router
const { params } = this.props; // select params from state
<Fragment id={'Task'} component={Task} redirect={{ id: 'TaskView', params }}>
<Fragment id={'TaskView'} component={TaskView}/>
</Fragment>
Error happened because redirect fired by router before new url will be parsed.
time-travel with redux dev-tools doesn't work
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.