awkward/beam

Beam: the open source Reddit client for iOS

beam's Issues

Add support for /r/popular

Currently, Beam doesn't support /r/popular introduced by Reddit. This is one of the bigger features we'd love to implement.

Add support for /r/friends

We've seen a lot of requests for supporting posts made by friends. It is not our intention to implement the friends system, but we do want to add support for /r/friends, which shows posts made by your friends.

Bug - App becomes a complete black screen exiting app's modal style pop-up menus

User feedback

Upon navigating to ‘profile’ > ‘settings (gear on top right)’, the app background goes completely black. Exiting the settings will cause the previous screen to appear for a split second before going all black again. At this point I’m unable to use the app until after I force close it.

Edit 1: The same seems to occur when I swipe right on a comment to reply. Both actions result in 'beam' launching the app's own modal style pop-up menu.

Troubleshooting: Reboot of device does not prevent this from happening.

Device information

Device model: iPad Mini 4
iOS version: 11.2.1 (15C153)
App version: 2.6 (384)
Compiled the app yourself: No

Screenshot/video (optional)

The state of Beam

Some have noticed that the Beam app is no longer available in the app store. Here is why.

Awkward the company behind Beam (and my previous employer) closed down in April 2020. You can read more about it here: https://medium.com/madeawkward/closing-down-awkward-a8b8f1ea722f.

We decided during the closure that the app would stay in the App Store, however the person responsible for the developer account forgot to pay the yearly fee and the app was pulled from the store. Bringing it back would require an update, which requires work because it needs to be built with the latest iOS SDK.

I personally wanted to keep Beam alive and vouched for it as well, however due to a number of unforeseen circumstances my free time to work on these kinds of projects is limited. At some point I would love to pick Beam back up, but Reddit is also changes at a rapid pace now, meaning that I might not be able to do so.

For now I'm trying to focus on keeping Tatsi, Trekker and Ocarina up to date, they are dependencies of Beam(ish) and are used by other projects as well.

If anyone wants to update the app for use with the iOS 14 SDK I would be happy to check and accept pull request and maybe get the app back in to the app store.

Swift Compiler Error - Missing Classes

User feedback

On the latest master, the following classes are missing from the project causing a Swift compilation error:

• ProfileViewController.swift
• CurrentUserProfileViewController.swift
• ProfileSwitchButton.swift

Am I missing something in the setup process?

Device information

Xcode 9.4.1

Screenshot/video (optional)

Warning

Files greyed out

Resolve warnings when compiling with iOS 13 SDK

When compiling for iOS 13, we get a huge amount of warnings. Let's try to get rid of them all.

TTTAttributedLabel crash when calculating size for some content

Steps to reproduce:

• Browse any reddit content on iOS 13.3
• At some point, the app crashes with the following stacktrace:

Thread 1 Queue : com.apple.main-thread (serial)
#0	0x00000001b298dec4 in __pthread_kill ()
#1	0x00000001b28ad724 in pthread_kill$VARIANT$armv81 ()
#2	0x00000001b27fd844 in abort ()
#3	0x00000001b29567d4 in abort_message ()
#4	0x00000001b29569c4 in demangling_terminate_handler() ()
#5	0x00000001b28be258 in _objc_terminate() ()
#6	0x00000001b2963304 in std::__terminate(void (*)()) ()
#7	0x00000001b2962c58 in __cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) ()
#8	0x00000001b2962c18 in __cxa_throw ()
#9	0x00000001b28be0d0 in objc_exception_throw ()
#10	0x00000001b2a9a5a8 in -[NSObject(NSObject) doesNotRecognizeSelector:] ()
#11	0x00000001b2b9aaf4 in ___forwarding___ ()
#12	0x00000001b2b9ca7c in _CF_forwarding_prep_0 ()
#13	0x00000001b3895b60 in TAttributes::HandleUnderlineAttribute(void const*, TAttributes::AttributeHandlerContext*) ()
#14	0x00000001b6135600 in -[NSAttributeDictionary __apply:context:] ()
#15	0x00000001b38951b0 in TAttributes::ParseAttributes(__CFDictionary const*, __CTFont const*, void const*&, TInlineVector<std::__1::function<void (TAttributes&)>, 30ul>&, std::__1::pair<bool, LigatureSetting>*) ()
#16	0x00000001b38949ec in TAttributes::ApplyFont(__CFDictionary const*, __CTFont const*, void const**) ()
#17	0x00000001b389482c in TAttributes::TAttributes(__CFDictionary const*) ()
#18	0x00000001b383e74c in TTypesetterAttrString::Initialize(__CFAttributedString const*) ()
#19	0x00000001b383e5c8 in TTypesetterAttrString::TTypesetterAttrString(__CFAttributedString const*, __CFDictionary const*) ()
#20	0x00000001b383a98c in TCFRef<CTFramesetterAttrString*> TCFBase_NEW<CTFramesetterAttrString, __CFAttributedString const*&>(__CFAttributedString const*&) ()
#21	0x00000001b383a8c4 in CTFramesetterCreateWithAttributedString ()
#22	0x00000001017af9c0 in -[TTTAttributedLabel framesetter] at /Users/robin/Development/Awkward/beam/TTTAttributedLabel/TTTAttributedLabel/TTTAttributedLabel.m:407
#23	0x00000001017b7d30 in -[TTTAttributedLabel sizeThatFits:] at /Users/robin/Development/Awkward/beam/TTTAttributedLabel/TTTAttributedLabel/TTTAttributedLabel.m:1333
#24	0x00000001017b7efc in -[TTTAttributedLabel intrinsicContentSize] at /Users/robin/Development/Awkward/beam/TTTAttributedLabel/TTTAttributedLabel/TTTAttributedLabel.m:1350
#25	0x00000001b6fc80d4 in -[UIView(UIConstraintBasedLayout) _generateContentSizeConstraints] ()
#26	0x00000001b6fc7dbc in -[UIView(UIConstraintBasedLayout) _updateContentSizeConstraints] ()
#27	0x00000001b6fd19bc in -[UIView(AdditionalLayoutSupport) _updateSystemConstraints] ()
#28	0x00000001b6fd0750 in -[UIView(AdditionalLayoutSupport) _sendUpdateConstraintsIfNecessaryForSecondPass:] ()
#29	0x00000001b6fd0c1c in -[UIView(AdditionalLayoutSupport) _updateConstraintsIfNeededCollectingViews:forSecondPass:] ()
#30	0x00000001b6fd0b00 in -[UIView(AdditionalLayoutSupport) _updateConstraintsIfNeededCollectingViews:forSecondPass:] ()
#31	0x00000001b2e6e06c in -[NSISEngine withBehaviors:performModifications:] ()
#32	0x00000001b6fd0e3c in -[UIView(AdditionalLayoutSupport) _recursiveUpdateConstraintsIfNeededCollectingViews:forSecondPass:] ()
#33	0x00000001b6fd0b00 in -[UIView(AdditionalLayoutSupport) _updateConstraintsIfNeededCollectingViews:forSecondPass:] ()
#34	0x00000001b6fd12f8 in __100-[UIView(AdditionalLayoutSupport) _updateConstraintsIfNeededWithViewForVariableChangeNotifications:]_block_invoke ()
#35	0x00000001b6fd0f30 in -[UIView(AdditionalLayoutSupport) _updateConstraintsIfNeededWithViewForVariableChangeNotifications:] ()
#36	0x00000001b6fcb8bc in -[UIView(AdditionalLayoutSupport) _systemLayoutSizeFittingSize:withHorizontalFittingPriority:verticalFittingPriority:hasIntentionallyCollapsedHeight:] ()
#37	0x00000001b6d7f574 in -[UITableViewCell systemLayoutSizeFittingSize:withHorizontalFittingPriority:verticalFittingPriority:] ()
#38	0x00000001b6df60d4 in -[UITableView _heightForCell:atIndexPath:] ()
#39	0x00000001b6dde428 in __53-[UITableView _configureCellForDisplay:forIndexPath:]_block_invoke ()
#40	0x00000001b7091e68 in +[UIView(Animation) performWithoutAnimation:] ()
#41	0x00000001b6ddd938 in -[UITableView _configureCellForDisplay:forIndexPath:] ()
#42	0x00000001b6deeca0 in -[UITableView _createPreparedCellForGlobalRow:withIndexPath:willDisplay:] ()
#43	0x00000001b6dbc2c4 in -[UITableView _updateVisibleCellsNow:] ()
#44	0x00000001b6dcf3dc in -[UITableView _visibleCellsUsingPresentationValues:] ()
#45	0x00000001009c6e84 in StreamViewController.updateGifPlayingState() at /Users/robin/Development/Awkward/beam/Beam/UI/Subreddits/Posts Stream/StreamViewController.swift:890
#46	0x00000001009df8d8 in StreamViewController.scrollViewDidScroll(_:) at /Users/robin/Development/Awkward/beam/Beam/UI/Subreddits/Posts Stream/StreamViewController.swift:913
#47	0x00000001009dfda4 in @objc StreamViewController.scrollViewDidScroll(_:) ()
#48	0x00000001b702fc60 in -[UIScrollView _notifyDidScroll] ()
#49	0x00000001b6dbcff8 in -[UITableView _notifyDidScroll] ()
#50	0x00000001b7019e70 in -[UIScrollView setContentOffset:] ()
#51	0x00000001b6ddbafc in -[UITableView setContentOffset:] ()
#52	0x00000001b70195a0 in _UIScrollViewAdjustForOverlayInsetsChangeIfNecessary ()
#53	0x00000001b7034a3c in -[UIScrollView setSafeAreaInsets:] ()
#54	0x00000001b65e4658 in -[UIViewController _updateViewSafeAreaInsetsAndEagerlyUpdateContentScrollView:] ()
#55	0x00000001b65e4d9c in -[UIViewController _setContentOverlayInsets:andLeftMargin:rightMargin:] ()
#56	0x00000001b65e674c in __121-[UIViewController __updateContentOverlayInsetsWithOurRect:inBoundsOfAncestorViewController:viaImmediateChildOfAncestor:]_block_invoke ()
#57	0x00000001b65e6558 in -[UIViewController __updateContentOverlayInsetsWithOurRect:inBoundsOfAncestorViewController:viaImmediateChildOfAncestor:] ()
#58	0x00000001b65e57b0 in -[UIViewController _updateContentOverlayInsetsFromParentIfNecessary] ()
#59	0x00000001b65e5008 in -[UIViewController _updateContentOverlayInsetsForSelfAndChildren] ()
#60	0x00000001b65f1944 in -[UIViewController _updateLayoutForStatusBarAndInterfaceOrientation] ()
#61	0x00000001b65f64e4 in -[UIViewController viewDidMoveToWindow:shouldAppearOrDisappear:] ()
#62	0x00000001b70961a8 in -[UIView(Internal) _didMoveFromWindow:toWindow:] ()
#63	0x00000001b7095f88 in -[UIView(Internal) _didMoveFromWindow:toWindow:] ()
#64	0x00000001b708a334 in __45-[UIView(Hierarchy) _postMovedFromSuperview:]_block_invoke ()
#65	0x00000001b708a21c in -[UIView(Hierarchy) _postMovedFromSuperview:] ()
#66	0x00000001b7098b24 in -[UIView(Internal) _addSubview:positioned:relativeTo:] ()
#67	0x00000001b7058c88 in -[UINavigationTransitionView transition:fromView:toView:] ()
#68	0x00000001b6562290 in -[UINavigationController _startTransition:fromViewController:toViewController:] ()
#69	0x00000001b65626f4 in -[UINavigationController _startDeferredTransitionIfNeeded:] ()
#70	0x00000001b6563a34 in -[UINavigationController __viewWillLayoutSubviews] ()
#71	0x00000001b6546eb8 in -[UILayoutContainerView layoutSubviews] ()
#72	0x00000001b709f3d0 in -[UIView(CALayerDelegate) layoutSublayersOfLayer:] ()
#73	0x00000001b96027dc in -[CALayer layoutSublayers] ()
#74	0x00000001b9608958 in CA::Layer::layout_if_needed(CA::Transaction*) ()
#75	0x00000001b9613578 in CA::Layer::layout_and_display_if_needed(CA::Transaction*) ()
#76	0x00000001b955bf1c in CA::Context::commit_transaction(CA::Transaction*, double) ()
#77	0x00000001b9585c08 in CA::Transaction::commit() ()
#78	0x00000001b6c32b08 in _afterCACommitHandler ()
#79	0x00000001b2b13e68 in __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ ()
#80	0x00000001b2b0ed54 in __CFRunLoopDoObservers ()
#81	0x00000001b2b0f320 in __CFRunLoopRun ()
#82	0x00000001b2b0eadc in CFRunLoopRunSpecific ()
#83	0x00000001bca94328 in GSEventRunModal ()
#84	0x00000001b6c09ae0 in UIApplicationMain ()
#85	0x00000001008897d8 in main at /Users/robin/Development/Awkward/beam/Beam/AppDelegate.swift:37
#86	0x00000001b2998360 in start ()

Add support for iCloud Drive

Creating an issue is easy! Here are some steps to help you:

User feedback

I was wondering if you were planning on adding iCloud Drive support so that filter lists are saved across devices. What I like best about your app is the unlimited number of subreddits I can block from All, but whenever I get a new device adding everything back can be time-consuming.

https://secure.helpscout.net/conversation/513279347/1890?folderId=356571

Device information

Device model: iPhone8,1
iOS version: 11.2.5
App version: 2.6.1

Bug - Gifs from i.reddit.it fail to play

User feedback

Gifs from https://i.redd.it fail to play.
Ex. https://i.redd.it/avciwqgatry31.gif

Reproduction steps:

1. Go /r/gifs
2. Find a gif hosted on i.reddit.it
3. Beam opens the gif but the screen is black

Device information

Device model: iPhone X
iOS version: 13.1.3
App version: 2.6.1
Compiled the app yourself: Yes

Screenshot/video

White border on link preview dark mode

User feedback

There's a white border on a link preview in dark mode. After scrolling down it disappears.

Device information

Device model: iPhone X
iOS version: iOS 13.3
App version: v2.7 (390)

Screenshot/video

Downloading submodules failed

Hi

When I try to download the git with submodules or submodules by themselves it says it failed. It also says make sure the repository exists or you have the correct rights.

Development moved to PowerMobileTeam/beam?

I love this app and am hoping to contribute to it when I get some free time. This morning when I checked the trending swift repos on GitHub I saw that there is now this repo, which is newer than this one.

Should I submit my changes there? Has Awkward sold beam?

Thanks

Blocked in Germany

Can't find in the iOS App Store.

Don't have rights to recursive submodules

User feedback

The command to recursive submodules failed: git submodule update --init --recursive
Am I missing something?

Device information

Device model: macOS 10.13

Screenshot/video (optional)

Gifs won't play in the image detail view

User feedback

Gifs won't play in the image detail view.

Steps to reproduce:

1. Open a subreddit
2. Find a GIF
3. Tap the GIF
4. The image detail view will open but the view stays empty

Device information

Device model: iPhone X
iOS version: iOS 13.3.1
App version: v2.7 (390)

Screenshot/video

Beam stops allowing touch feedback

Creating an issue is easy! Here are some steps to help you:

User feedback

Beam stops allowing touch feedback. Cannot click, go back, upvote, etc. until I close the app and reopen. Happens very often since new app update 2.6.1

Device information

Device model: iPhone X
iOS version: 11.2.2
App version: 2.6.1
Compiled the app yourself: No

Support systemwide dark mode

Beam currently has its custom dark mode implementation. I think it would be a good idea to use the system implementation instead, and use system dark mode colors.

"Unixporn" search keyword is blocked due to it containing "porn"

Creating an issue is easy! Here are some steps to help you:

User feedback

Keyword "unixporn" should be whiteisted

Device information

Device model: iPhone 7 Plus
iOS version: iOS 11.2.2
App version: v2.6
Compiled the app yourself: No

Screenshot/video (optional)

Support for iOS 11 and iPhone X

If you currently compile Beam against the iOS 11 SDK you will see a lot of things break. This is mostly due to changes to contentInset in iOS 11 and a few workarounds no longer working. Here is a list of some of the stuff that is currently broken:

• Stars on the subscription lists are in the incorrect position
• The sort bar in subreddits, profiles and other places is in the wrong position
• The sort bar in subreddits is extremely high
• The sort bar in subreddits, profiles and other places appears empty
• The tabbars do not show correctly on the iPhone X
• Some posts have white stripes on the left and ride side
• Swiping back or down from a subreddit does not work correctly
• Search on a subreddit does not work

There are probably more bugs in the app on iOS 11 and iPhone X, but feel free to discuss them in this issue.

Remove spaces from directory names

Beam has a fantastic code base for testing tools at scale. There aren't many open-source apps of that size. However, it breaks tools like https://github.com/peripheryapp/periphery when there's a space in a source code directory name, e.g. Beam/UI/Generic UI. It would be great for all the spaces to be removed.

Custom transition results in black screen

Steps to reproduce:

• Open the frontpage
• Open a subreddit from a post
• Close the subreddit

The app now displays a black screen, instead of being back at the frontpage

Add support for galleries

Creating an issue is easy! Here are some steps to help you:

User feedback

I’m not sure if that’s what it’s called, but when scrolling through /r/rateme for example I don’t see the galleries but links instead

Device information

Device model: iPhone 8
iOS version: 14.6
App version: 2.6.1
Compiled the app yourself: no

Screenshot/video (optional)

Bug - Enabling system dark mode while using default theme causes some areas to appear dark

User feedback

If you enable dark mode on your phone but use light mode in Beam, some areas of the app will appear dark.

Reproduction steps

1. Enable dark mode in iOS
2. Enable light mode in Beam
3. Some areas of the Beam app appear in dark mode

Device information

Device model: iPhone X
iOS version: 13.1.2
App version: 2.6.1
Compiled the app yourself: Yes

Screenshot/video

Add visual indication for stickied comments

Beam supports stickied comments, but it doesn't visually indicate that it's a stickied comment. We'd like to implement the same visual as for stickied posts.

Add support for Reddit video

Beam currently supports links to YouTube videos, which are handled as links. However, Reddit introduced their own video service and we'd love to play these videos in Beam.

Text in cells is cut off

User feedback

Text in cells is cut off.

Device information

Device model: 12.9" iPad Pro 3rd gen
iOS version: iOS 13.3.1
App version: Simulator build

Screenshot/video (optional)

In-app purchases: should we keep them in?

Beam has been open source for a few months now. The first question [1] we got was about the in-app purchases.

Although it's unsure whether people want to help out continuing the development of Beam, there is something to say about the in-app purchases not making sense anymore... especially when there's a possibility that it's holding people back to help out.

But if we remove in-app purchases, how does it work with the functionality provided within the packs? Do we remove packs and add everything on by default? Or how would that work.