beverloo/peter.sh

Source-code for http://peter.sh/.

peter.sh's Issues

Highlighted commits per Chrome release

It's been on my list for quite a while (and @addyosmani keeps nagging me about it) to enable viewing highlighted commits per Chromium release, rather than just those in the last 14 days.

In order to implement this accurately, I'd need a commit hook monitoring BUILD updates to //chrome/VERSION. This gives us the SHA for Chromium at that revision. For Blink, Skia and v8, I need to parse the //DEPS file at that revision and find the current revisions for these repositories. This should be stored as a set of {build, repository, revision} records in the database.

Then we need to know the BUILD that's associated with a Chrome release. This will have to be a manual process. My current idea is to have a JSON file here on GitHub (so that anyone can update it) mapping major Chrome versions to branches -- Chrome 40 would be BUILD 2214. OmahaProxy can provide this information.

Displaying them, assuming an URL similar to https://commits.peter.sh/chrome/40/, would then require mapping 40 to the BUILD (2214) and finding the BUILD for the previous release (39 -> 2171). Then, for each repository, select the highlighted commits where the commit date is between those of the revisions mentioned in the BUILD records in the database.

Addy mentions it might be nice to have diffs between multiple releases, e.g. between 40 and 37, but I'm not sure there's a valid use-case for that so I'd like to keep it out for now.

Another edge-case are merged commits. There are cases where an interesting commit gets merged to a release branch. This should be fairly rare for Web Exposed changes, but we'd miss out on these changes for now.

Background fetch abort in progress job button

It would be great if we could have a button next to an in-progress download that calls abort().

Tag flags that only apply to certain environments

Some command line flags in Chrome are not available for the entirety of the project, but rather only in specific environments, e.g. Mojo. Take the following flag:

https://code.google.com/p/chromium/codesearch#chromium/src/mojo/runner/switches.cc&q=kUseTemporaryUserDataDir&sq=package:chromium&type=cs&l=49

This is being presented as follows:

http://peter.sh/experiments/chromium-command-line-switches/#use-temporary-user-data-dir

.. yet is only available in the Mojo runner. A tag would significantly help in clarifying this.

[Context: https://crbug.com/529837]

Support in page notificationis

The page only provides service worker notifications, it would be good to support in page notifications as well.

Add endpoint that slowly returns response body, for testing Background Fetch progress

Problem and error 401

HI,
I have a problem, error:
POST https://www.xxxx.fr/notif2/push.php 401 (anonymous) @ VM107 push_generator.js:787 Promise.then (async) PushGenerator.sendMessage @ VM107 push_generator.js:778
And line 778 to 787:
`.then(function(request) {
var headers = new Headers();
Object.keys(request.headers).forEach(function(headerName) {
headers.append(headerName, request.headers[headerName]);
});

// Proxy everything through a PHP script to get around CORS restrictions.
headers.append('X-Endpoint', request.url);

return fetch('https://www.xxxx.fr/notif2/push.php', {
  method: 'POST',
  headers: headers,
  body: request.body
});`

I can't find where is the problem. Can you help me ?
Thank you

Java command line flags are omitted

There are lots of useful Android-only Chrome command line flags handled in Java, for example --disable-fre skips the First Run Experience (useful for testing).

These flags are currently omitted from https://peter.sh/experiments/chromium-command-line-switches/ (without any warning that the page is incomplete).

They can be found in files ending in Switches.java, for example:

• android_webview/java/src/org/chromium/android_webview/AwSwitches.java
• android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellSwitches.java
• base/android/java/src/org/chromium/base/BaseSwitches.java
• chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
• chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastSwitches.java
• content/public/android/java/src/org/chromium/content/common/ContentSwitches.java

Chromium Switches: Last update in August 2020

Thanks a lot for your List of Chromium Command Line Switches - as the main developer of qutebrowser, it's a very useful reference!

Unfortunately, it looks like the page says:

Last automated update occurred on 2020-08-12.

Yet says:

Based on top-of-tree Chromium code, updated daily

So I assume something broke at some point?

Add Mozilla push staging server to whitelist

I see you have the Mozilla push production server at

peter.sh/tests/push.php

Line 22 in 78e4648

'https://updates.push.services.mozilla.com/push/',

. Could you add https://updates-autopush.stage.mozaws.net? It'll ease testing new clients, like the Firefox for Android implementation I'm working on.

Thanks for a great testing resource!

/cc @jrconlin @bbangert

Background Fetch title checkbox

BackgroundFetchSettledEvent JS error

In the new version of the spec, getting the fetches from the event returns a Promise.

event.fetches.forEach(...)

should become something like

(await event.fetches.values()).forEach(...);

Command line flag parser is flaky

http://peter.sh/experiments/chromium-command-line-switches/

Yesterday there were >1000, now there are 418.

/cc @phistuck

Commit RSS feed should move to feeds.peter.sh

Right now, the commit RSS feed is available on the following URL:
https://commits.peter.sh/?rss

It should move to https://feeds.peter.sh/ so that it can share the code for generating the feed, and eventually benefit from the same level of caching and monitoring as the other feeds.

Add a remove all notifications button

This would help with testing but also exercise the getNotifications method of the API

The DevTools feed should include commits from v8/src/inspector

https://chromium.googlesource.com/v8/v8/+/master/src/inspector/ includes code that was up until a few months ago in the Chromium/Developer Tools repository. This code affects the backend of the Developer Tools (now shared with NodeJS). I think it should be included in the field as well.

Any example with FCM?

Missing --log-file Switch

https://cs.chromium.org/chromium/src/content/public/common/content_switches.cc?type=cs&l=574

How to close notification after reply?

Steps to reproduce:

1. Open https://tests.peter.sh/notification-generator/
2. Allow to show notifications in the browser permission prompt
3. Select "One action (type text)" in the "Actions" dropdown menu
4. Click "Display the notification" button
5. Receive the notification and click "Reply" action button
6. Type something
7. Click "Send" icon

Expected behavior:

The notification should close after clicking on "Send" icon

Current behavior:

If "Close it?" checkbox is unchecked, after clicking on "Send" icon it becomes a spinner that spins endlessly. The notification won't close.

If "Close it?" checkbox is checked, after clicking on "Send" icon the typed text is added at the top, you can click "Reply" action button again, type something, and click "Send" icon, this text is also added at the top. The notification won't close.

Question

How to close the notification after reply? Should I return a promise in notificationclick event listener in addition to event.notification.close() or something else?

Is it a bug in Chrome for Android? The notification successfully closes in Chrome on Windows after clicking "Reply" action button (in both cases, if "Close it?" checkbox is checked or unchecked):

@beverloo @gauntface @anitawoodruff Please help me figure it out. 😉

The fetch requests with relative paths are returning 404

For example:
'/resources/icons/15.jpg' tries to load the asset at https://peter.sh/tests/random/resources/icons/15.jpg
The actual asset is at https://peter.sh/tests/resources/icons/15.jpg on the server.

Network switches (eg --disable-http2) are excluded

https://source.chromium.org/chromium/chromium/src/+/master:components/network_session_configurator/common/network_switch_list.h defines a few switches

but they're not listed in https://peter.sh/experiments/chromium-command-line-switches/

I see the the .cc is listed in the blocklist: https://github.com/beverloo/peter.sh/blob/master/services/services/command-line-flags/blacklist.txt

but ideally the switches defined in the header file would be included, right?

Show notification settings not supported by Firefox

Currently the page only shows what isn't supported by Chrome.

Support for delayed notifications

We need some kind of "wait X seconds to notify" so we can test notifications while chrome/the tab is in the background.

Add a splash screen to the notification generator

See title. +@mvano

Web-Push-Javascript

Web-Push-Php send webpush via php.
I would to use client javascript to send webpush.
Do I can to use this library to get it?
How to have to set the value?
in Web-Push-Php I have in server:
vapid public.kye and private.key
and when register I get:
endpoint, publicKey, authToken, "contentEncoding":"aesgcm".

Do it is possible to use a hxr javascript instead of push.php?

Update git hashes of Blink commits

Now that the Chromium and Blink repositories merged, all Blink commits are linking to an unused repository. While @primiano tells me that it'll stick around, I'd rather remove the repository from the code entirely and link to the new SHAs.

Example:
https://chromium.googlesource.com/chromium/blink/+/134c13894bf5fb087f9017698547ec12c963bfa6

Should instead link to:
https://chromium.googlesource.com/chromium/src/+/87ca9556952b5570a2f1c0cb8035bb87602f790b

Identify command line flags only available to certain shells

http://peter.sh/experiments/chromium-command-line-switches/

Certain flags, e.g. --run-layout-test, are only available in certain shells rather than in all of Chrome. This could be determined based on the path of the file, which starts with //content/shell/ in case of the aforementioned flag.

Identifying them using either a new conditional, or a separate new flag, would increase clarify about the applicability.

Thanks to @Jip-Hop for the suggestion :-).