Giter Site home page Giter Site logo

Comments (7)

colinvwood avatar colinvwood commented on September 16, 2024 1

Changes in q2-assembly are (at least partially) blocked by bokulich-lab/q2-assembly#66

from q2-types-genomics.

gregcaporaso avatar gregcaporaso commented on September 16, 2024

@ebolyen pointed out that we can add a method on the format that gives us tuples or a dict mapping sample ids to relative filepaths in the Archive, so that will achieve the same goal without having to create new manifest formats. So we should do that for the next release (2023.11), and take a pass to use these throughout in places where we're parsing filenames to access the sample ids.

from q2-types-genomics.

misialq avatar misialq commented on September 16, 2024

Sounds good - thanks @gregcaporaso and @ebolyen! 🙏

from q2-types-genomics.

gregcaporaso avatar gregcaporaso commented on September 16, 2024

Since this issue was opened in the context of the ContigSequencesDirFmt, let's update all code that is using that format (e.g., here) as needed to use the lookup that @colinvwood added in #57, and then close this one out.

@colinvwood, could you put this on your list? It's a nice-to-have for the 2023.11 release, but not essential.

from q2-types-genomics.

colinvwood avatar colinvwood commented on September 16, 2024

@gregcaporaso what about other formats that could use this approach, e.g. the PR @misialq linked above--should we open separate issues? that is in fact its own issue not a PR, whoops

from q2-types-genomics.

colinvwood avatar colinvwood commented on September 16, 2024

After looking at the places in q2-assembly where we could use this new approach, I think that things will be much more refactorable once we have corresponding functionality for the mag directory format(s).

from q2-types-genomics.

gregcaporaso avatar gregcaporaso commented on September 16, 2024

Ok, makes sense. Do we have an issue for updating the MAG directory format(s)? Could you create one if not?

from q2-types-genomics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.