Giter Site home page Giter Site logo

Comments (14)

shortstuffsushi avatar shortstuffsushi commented on August 16, 2024

Hey @RishabhTayal, sorry about that. I'm assuming you're running into the issue that is fixed in #27, but could be more sure if you provided me with the error you're seeing.

from branch-ios-invite-sdk.

RishabhTayal avatar RishabhTayal commented on August 16, 2024

@shortstuffsushi I don't have much information. It just says HMSegmentControl.h not found.

from branch-ios-invite-sdk.

shortstuffsushi avatar shortstuffsushi commented on August 16, 2024

Oh, my mistake. I thought you were saying that you were seeing an error while executing pod install.

I'm unsure why you wouldn't see that file come through, but I'm thinking the easiest thing to do would be just to clean your project in Xcode (try cmd+option+shift+k). If that doesn't do it, try removing the Podfile.lock and Pods directory again, and then rerun pod install.

Perhaps there is an error being emitted by Cocoapods while it tries to pull HMSegmentedControl that is causing those files to never make it to Xcode. Sorry I can't give much more info, but I think you're seeing an issue with Cocoapods, and not the Invite SDK itself. Let me know if those steps give you any more insight.

from branch-ios-invite-sdk.

francisjervis avatar francisjervis commented on August 16, 2024

Hi Rishabh, I’ve had some experience implementing Branch invite in Swift. This may be a header file issue - can you post the relevant lines from your bridging.h (or whatever) file?

The installation is a little non-standard in that it seems to want each of the headers to be imported separately, like so:

#import <Branch/Branch.h>
#import <BranchInvite/BranchInvite.h>
#import <BranchInvite/BranchInviteViewController.h>
#import <BranchInvite/BranchInviteTextContactProvider.h>
#import <BranchInvite/BranchInviteEmailContactProvider.h>
#import <BranchInvite/BranchWelcomeView.h>
#import <BranchInvite/BranchWelcomeViewController.h>
#import <BranchInvite/BranchWelcomeControllerDelegate.h>
#import <BranchInvite/BranchWelcomeDefaultView.h>

My guess is that you didn’t import InviteViewController correctly, and that is causing the dependency not to be found. Just a guess tho!
Good luck
Francis

On Aug 11, 2015, at 2:44 PM, Graham Mueller [email protected] wrote:

Oh, my mistake. I thought you were saying that you were seeing an error while executing pod install.

I'm unsure why you wouldn't see that file come through, but I'm thinking the easiest thing to do would be just to clean your project in Xcode (try cmd+option+shift+k). If that doesn't do it, try removing the Podfile.lock and Pods directory again, and then rerun pod install.

Perhaps there is an error being emitted by Cocoapods while it tries to pull HMSegmentedControl that is causing those files to never make it to Xcode. Sorry I can't give much more info, but I think you're seeing an issue with Cocoapods, and not the Invite SDK itself. Let me know if those steps give you any more insight.


Reply to this email directly or view it on GitHub #29 (comment).

from branch-ios-invite-sdk.

RishabhTayal avatar RishabhTayal commented on August 16, 2024

@shortstuffsushi Please the attached gif. I have created a swift project from scratch. Let me know if you need more detail. The project builds fine when only Branch module is imported but gives an error when BranchInvite module is imported.

untitled

from branch-ios-invite-sdk.

RishabhTayal avatar RishabhTayal commented on August 16, 2024

@francisjervis There is no requirement for a bridging header file since I am using use_frameworks! in my Podfile. Although I have also tried adding the import statements to the bridging header file.

from branch-ios-invite-sdk.

francisjervis avatar francisjervis commented on August 16, 2024

That may be the problem, in fact. Have you tried to replicate this not using frameworks?

On Aug 11, 2015, at 4:24 PM, Rishabh Tayal [email protected] wrote:

@francisjervis https://github.com/francisjervis There is no bridging header file since I am using use_frameworks! in my Podfile.


Reply to this email directly or view it on GitHub #29 (comment).

from branch-ios-invite-sdk.

RishabhTayal avatar RishabhTayal commented on August 16, 2024

@francisjervis I am sure it will work fine when not using frameworks option. But that is the issue here. The library gives error when used as a framework in swift.

from branch-ios-invite-sdk.

shortstuffsushi avatar shortstuffsushi commented on August 16, 2024

Unfortunately, I'm not very familiar with the use_frameworks options, or what the implications of that are with this SDK. Is there something that we would need to do differently to support it?

from branch-ios-invite-sdk.

RishabhTayal avatar RishabhTayal commented on August 16, 2024

@shortstuffsushi I might be able to help you fix this issue.

from branch-ios-invite-sdk.

francisjervis avatar francisjervis commented on August 16, 2024

Yes but I don’t know what ;) It’s also highly possible this is an issue with HMSegmentedControl.

I haven’t found use_frameworks has enough advantages to justify dealing with issues like this, so I don’t use it. I think I did in a side-project that only used Swift-based libraries, and that worked OK. But IIRC setting that flag in your podfile breaks FBSDK and/or Google Analytics too, so this is not a rare issue with ObjC based SDKs.

On Aug 11, 2015, at 4:35 PM, Graham Mueller [email protected] wrote:

Unfortunately, I'm not very familiar with the use_frameworks options, or what the implications of that are with this SDK. Is there something that we would need to do differently to support it?


Reply to this email directly or view it on GitHub #29 (comment).

from branch-ios-invite-sdk.

RishabhTayal avatar RishabhTayal commented on August 16, 2024

@francisjervis it's happening when you use use_frameworks but the underlying error is not something related to swift or frameworks. I think it's the way file is imported. Eventually most of the people are using frameworks in cocoapods.

from branch-ios-invite-sdk.

francisjervis avatar francisjervis commented on August 16, 2024

There is an ongoing issue with frameworks, see for example CocoaPods/CocoaPods#3194 CocoaPods/CocoaPods#3194

Seems like a CocoaPods issue, but this thread is somewhat beyond my comfort zone…I just went with the use_libraries workaround.

On Aug 11, 2015, at 4:43 PM, Rishabh Tayal [email protected] wrote:

@francisjervis https://github.com/francisjervis it's happening when you use use_frameworks but the underlying error is not something related to swift or frameworks. I think it's the way file is imported. Eventually most of the people are using frameworks in cocoapods.


Reply to this email directly or view it on GitHub #29 (comment).

from branch-ios-invite-sdk.

RishabhTayal avatar RishabhTayal commented on August 16, 2024

Just FYI, this merge will fix this issue. #30

from branch-ios-invite-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.