branchmetrics/branch-ios-invite-sdk

The purpose of the Branch iOS Invite SDK is to provide an out-of-the-box functional 'invite feature' for apps consuming the Branch SDK that want to utilize a standard invite feature in their app. Branch helps mobile apps grow with deep links that power referral systems, sharing links and invites with full attribution and analytics.

branch-ios-invite-sdk's Issues

De-hardcode myself as the inviting user in the example app.

Currently, the example app simply always uses my information as the 'inviting user.' This is confusing to anyone trying to use the app, though, and should instead be something the user can specify.

ABRecordRef depreciated in iOS 9

ABRecordRef and a few others have been depreciated. Perhaps add a check in one of the next versions so the pod compiles without warning.

Thanks

BranchInviteControllerDelegate Swift

Error Message: ViewController.swift: Type 'ViewController' does not conform to protocol 'BranchInviteControllerDelegate'

However I implemented both required methods like so:
class ViewController : UITableViewController, UITextFieldDelegate, BranchInviteControllerDelegate {
func inviteControllerDidFinish() {
print("inviteControllerDidFinish")
}

func inviteControllerDidCancel() {
print("inviteControllerDidCancel")
}
}
Still getting this compiler error. I closed and reopen Xcode to no avail.

Branch (0.12.2)
Xcode 7.3

Missing iPad xibs

Not sure if a PR is the best way to submit a file name change...but iPad Pro crash is fixed by appending ~ipad to the XIB file names which don't have ~ipad appended now.

Properly track channel of invite

Right now, you're specifying channel as "invite". Can you specify it according to the mechanism used to message the person? It's meant to represent that channel that the link was released from the app.

Invite controller also broken for iPad

Just saw this one:

Fatal Exception: NSInternalInconsistencyException
Could not load NIB in bundle: 'NSBundle </var/containers/Bundle/Application/32579E05-90AB-4C3F-9D9E-E86FE2FFCB04/TimesFree.app/BranchInvite.bundle> (not yet loaded)' with name 'BranchInviteViewController'

Not able to integrate in Swift

I have been trying hard to follow the documentation, but facing tough issues.

Check out the screenshot

I just copy pasted the given code and got these errors. Tried to follow what xcode suggested which led to the error message shown in the screenshot.

Please suggest solutions.

Add the Welcome Screen

When a User opens the app after being Invited, they should see a Welcome screen showing a message saying who invited them, a picture of that user (optional), and should have an ability to continue or cancel the welcome flow.

Some design work

Love the experience but needs a little bit of appearance touch up - should probably think through themes. Do you want to do that?

Pod Integration, no visible interface

Hello, I am trying to integrate BranchInvite along with Branch in my swift project. I am using cocoapods -v 1.0.1, Branch 0.12.4 and BranchInvite 0.3.8. The error I am getting is on a function in BranchInviteViewController in the screenshot bellow. I have cleaned, deleted derived data, reintegrated and integrated pods to no avail. Have you guys seen this before ?

Update to support 0.12.4

Need to replace getReferralUrlWithParams with updated methods.

Add Hooks to Invite Controller to Allow Dev to Specify Providers

Getting build error when added through pods in Swift

Here is my podfile. Gives error on #import "HMSegmentControl.h" statement in BranchInviteControllerDelegate.h file.

source 'https://github.com/CocoaPods/Specs.git'

platform:ios, '7.0'

inhibit_all_warnings!
use_frameworks!

pod 'Branch'
pod 'BranchInvite'

Contacts should be filtered when Provider is changed

Currently, when a user switches contact providers (say, from Email to SMS), the filter text is not cleared, but the full contact list is shown.

When the contact provider is changed, the filter itself either needs to be cleared, or the contact list needs to be cleared. I'm of the opinion that as a user, I would prefer to keep my filter text and just see my contacts filtered accordingly.

Provide UI Hooks for Welcome Screen

Getting Error Loading Invite View

Hello,
I used the invite view the exact same way as the example project and Im getting this error

Any clues? thanks

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not load NIB in bundle: 'NSBundle </private/var/mobile/Containers/Bundle/Application/FAE52CEC-CBBE-4F92-A5D3-F8E68CA049AF/MyApp.app> (loaded)' with name 'BranchInviteViewController'Hello,

Resizing Labels for Welcome Screen on pre-iOS 7

6 is supported, so the logic to resize them manually needs to be there. Ought to be fun...

Black welcome screen when use_frameworks! set in Podfile

Edit: this appears to be a resource bundle issue:
https://guides.cocoapods.org/syntax/podspec.html#resource_bundles

(based on this CocoaPods/CocoaPods#2408 )

BranchInviteDefaultContactCell make Xcodebuild error

when I use --xcodebuild build a ipa, sometimes this command error at BranchInviteDefaultContactCell.xib
Environmental:Xcode 9.1

Create an example contact provider in the sample project

Create Twitter Contact Provider

Add support for small profile screenshot

Add Proper Params to Invite Link

Currently the links created for invites have no params, which isn't correct at all. Trying to figure out what should be in there still.

Will not build in Swift

Hi, I get the following error when trying to build.

Add some alphabetized index on the name list

'Could not build Obj-C module 'BranchInvite'

I've been following the instructions for implementing this SDK... below is what I have in my Podfile:

platform :ios, '8.0'

use_frameworks!

target 'My-App' do

pod 'BranchInvite'

end

And here is the error I'm getting... I've done a lot of troubleshooting to try and figure out the problem, looked at past issues of this sort, and for some reason I cannot get "BranchWelcomeViewController" (nor BranchInvite) to be recognized/imported. Any idea what I'm doing wrong here? Do I need to populate my bridging-header?

PS: I'm using Xcode 7, Swift 2, OS X 10.10.5, and the latest version of Cocoapods.

Thanks

Crash after app went in brackground

Hey, I noticed a crash. It looks like it comes from the close request. It happens after the app went in background

Proactively Load Provider Contacts

Currently, contacts are only loaded when the tab is selected. This works ok for Email and Text since they're loaded from the device, but for remote contacts, like Facebook, there will be some time delay in them loading. Might as well start loading them as soon as possible, so there isn't any disruption in the UX.

Add a search bar for plain text name search

Create Facebook Contact Provider

Ability to invite Facebook friends is one of the most desired features I believe. I have a local patch that attempts to accomplish the work, but have run into a wall in several areas.

• Actually getting contacts is not as simple as /me/friends, as the Graph API v2 only includes friends who've already installed the app, which doesn't seem to cover the base use case (inviting other users who aren't currently in the app to the app).
  ** The /me/invitable_frends API would be perfect, but is only available to Facebook game apps with a canvas presence.
  ** The /me/taggable_friends end point also returns useful information, but without the actual friend IDs (and I'm pretty sure this would be an abuse of their API).
• There are a number of different dialogs available for sending various messages. I'm not sure which is the correct one, but I'm leaning towards 'AppRequests' dialog.

Modify project structure

Can we make the Github project and testbed project self contained? Mainly because I think this project will downloaded and played with a lot, mostly by devs that don't use Cocoapods. I often checkout repos on Github and lose my attention when the Test project doesn't build right away. What do you think?

Contact Table should support Multi Selection

Provide UI Hooks for Invite Screen