Giter Site home page Giter Site logo

Comments (4)

aaustin avatar aaustin commented on July 17, 2024

I just added xibs for ipad specifically in this commit and updated cocoapods. I couldn't get it to crash on an iPad, but can you give the latest a try? 0324253

from branch-ios-invite-sdk.

francisjervis avatar francisjervis commented on July 17, 2024

Looking good! Found one issue: the controller dismisses when the "done" button is tapped with the "Text" tab selected (ie sending iMessage/SMS). The app does not crash, though. This does not happen on small screens. Email functionality works works fine on all devices.

Should this release fix #49?

from branch-ios-invite-sdk.

aaustin avatar aaustin commented on July 17, 2024

So, it doesn't actually send SMS even when contacts are selected? Hmm and this only happens on iPad?

Somehow I missed the #49 issue. Did you test it and it worked?

from branch-ios-invite-sdk.

francisjervis avatar francisjervis commented on July 17, 2024

Ha I found what it was - the iPad in question didn't have iMessage activated!! This causes the invite controller to dismiss silently.

Ideally I'd like to handle this differently from user-initiated cancels (ie the invitesCanceled delegate method). Arguably the SDK should alert the user in the case of failure as it does when loadContactsFromAddressBookIfPossible fails. Low priority tho!

from branch-ios-invite-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.