Giter Site home page Giter Site logo

Comments (12)

hyanwong avatar hyanwong commented on September 27, 2024 1

I can replicate this on my M2 when installing cyvcf2 via pip (python 3.10, 3.11, and 3.12).

I have cyvcf2 working via another route. I'll see if I can figure out how I did that, and post here.

from cyvcf2.

hyanwong avatar hyanwong commented on September 27, 2024 1

I can get a working cyvcf2 by compiling via pip --no-binary=cyvcf2. This requires both autoconf and automake. Make sure you python -m pip uninstall cyvcf2 first if you have previously installed a non-working version:

mamba install automake autoconf  # or could equivalently use conda
python -m pip install cyvcf2 --no-binary=cyvcf2 

it might be that you also require htslib for compilation: I didn't try it on a completely clean OS install. Let me know if there are still compilation failures and I can see what else I previously installed to get it to work.

from cyvcf2.

brentp avatar brentp commented on September 27, 2024 1

I pushed a new tag for this with the fix from @graphenn . v0.31.0

from cyvcf2.

brentp avatar brentp commented on September 27, 2024 1

🥳 thanks @graphenn

from cyvcf2.

jmarshall avatar jmarshall commented on September 27, 2024 1

Sounds a lot like you were running into a similar problem to pysam-developers/pysam#1231, which we too worked around by ensuring we were compiling on e.g. ARM macOS rather than cross-compiling from a different architecture.

from cyvcf2.

brentp avatar brentp commented on September 27, 2024

@graphenn do you have an idea about this?

from cyvcf2.

graphenn avatar graphenn commented on September 27, 2024

I don't have a Mac either. Additionally, the GitHub action can't test with macOS ARM. We need someone with this environment to assist.

from cyvcf2.

jeromekelleher avatar jeromekelleher commented on September 27, 2024

@hyanwong or @tomwhite - would either of you be able to replicate? I think this is going to hit us downstream so it's would be great if we could track down the issue and hopefully fix the wheels.

from cyvcf2.

jeromekelleher avatar jeromekelleher commented on September 27, 2024

Looking at the wheel building, it seems like we're cross-compiling for ARM on a macos-12 host. Would it be simpler to use the newer macos-14 GitHub actions runner and compile natively?

from cyvcf2.

jeromekelleher avatar jeromekelleher commented on September 27, 2024

Or maybe use cibuildwheel directly? I don't know what the history of the wheel building process is here, sorry if we're going over old ground!

from cyvcf2.

graphenn avatar graphenn commented on September 27, 2024

Looking at the wheel building, it seems like we're cross-compiling for ARM on a macos-12 host. Would it be simpler to use the newer macos-14 GitHub actions runner and compile natively?

Yes, the new macos-14 action runner makes it much easier. I create a PR for changing macos ARM to this runner.
#306

NO cp38 wheel for macos arm

@hyanwong Could you test with the building wheel? https://github.com/graphenn/cyvcf2/actions/runs/9229532344
artifact-cp3xx-macosx_arm64

from cyvcf2.

jeromekelleher avatar jeromekelleher commented on September 27, 2024

Confirmed packages are working on macos-14 GitHub Action runner! Thanks very much!

from cyvcf2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.