Comments (6)
OHHHHH I GET WHAT YOU MEAN BY TEMPLATES, it's a literal template that github lets you create for issues and PRs. OK. I didn't know those existed. I will add some tomorrow
Edit: also, I am purposefully not tagging issues with "hacktoberfest" to reduce our project's traffic until we figure out a more solid process
from metric_units_reddit_bot.
Here are my general opinions on the stuff that needs to be worked out in this repo, hope they help, maybe not all of them are on topic, but I think they should be addressed:
- Instead of using Pivotal Tracker, switch to Github issues exclusively, maybe keep the "ice box" section from pivotal tracker. Since it is not possible for unpaid users to write comments/responses there, it's suboptimal to use that.
- In most repos I've seen, it is fine to keep assigned for at least 7 days, if someone responds with unwilling-ness, or runs into too many problems to continue, un-assign. Maybe, in case of large tasks, any minor updates in 7 days should continue issue assignment.
- When merging PRs, squash them into neater single commits with PR number etc., so that it's easier to trace back code from commits to PRs and so on. For example, let summary be something like
Feature name(PR #number)
and description contain the list of all commits made. I personally prefer this, I don't know about others. - Maybe come up with a standard-ish template for PRs(and issues, if needed) where-in it makes sure future readers can easily infer the necessary details of a PR.
from metric_units_reddit_bot.
I think you're right, stories should be moved out of Pivotal Tracker so people can comment on them. I also agree with your other points, some guidelines for what information a PR should contain is a great idea! (This is my first open source project, if you can't tell :P)
from metric_units_reddit_bot.
@nalinbhardwaj Can you provide an example of what you mean by "a template for issues/PRs"?
I made a first draft of a CONTRIBUTING.md file.
Any comments about the specific text (wording, typos, etc) can be made on the PR.
Any comments about overarching ideas or process-related things can be continued in this thread.
from metric_units_reddit_bot.
@nalinbhardwaj Can you provide an example of what you mean by "a template for issues/PRs"?
I meant, for issues, we should have some definite fields in title like [bug report], [feature request] etc. in which, an example(for bug report, a link to reddit comment or such), expected behaviour details.
For PRs, a checklist for common things, tested code
, reviewed code
, follows style guide
or similar that can be modified by maintainers etc. You can see PRs like this for example, I like having the Related issues and discussions etc.
I made a first draft of a CONTRIBUTING.md file.
I like the version. By the way, I suggest adding a new file src/testing.js
to replicate a reddit comment(body, subreddit etc.) and prints a response as comment with all relevant fields to the console. I don't think it should be hard to write, but it would make manual testing much easier.
from metric_units_reddit_bot.
Thank you for the link to the PR and repo, I have stolen some ideas from them :D
I have added "lifecycle of an issue" and "lifecycle of a PR" to the CONTRIBUTING.md doc (which is now merged into master) to describe some flows. I don't think we need tags for PRs because our PRs are generally small, but we can always iterate if we find the current process not working.
I'll leave this issue open for a few more days, if anyone else would like to chime in on process :)
from metric_units_reddit_bot.
Related Issues (20)
- Refactor number parsing HOT 1
- Bug report: Add ignore keywords to "cups" for gaming sub reddits
- Feature request: Add unit `qt` = 1/4 gallon HOT 3
- Range conversion "30-50lb" converted to "30 lb50 lb ≈ 1423 kg"
- Scan the r/homebrewing thread and post constructive feedback in r/metric_units HOT 2
- Move documentation to /docs folder HOT 5
- bot off HOT 1
- Discussion - Discussions HOT 2
- Handle commas better HOT 16
- Always add L/100km conversion
- "oz" is not being converted to "troy oz" in subreddit /r/Pmsforsale HOT 27
- Ignore all nba subreddits for mpg HOT 10
- Ignore "cup" measurements over 100 HOT 2
- Feature request: Convert lbs/inch to kg/mm and N/m HOT 4
- Handle close numbers better HOT 1
- Conversions architecture overhaul
- Modify pressureMap to convert 10^5 pa to bar HOT 4
- Improve rounding HOT 4
- Bot should sass users who edit their comments to remove values HOT 7
- change footer links and text HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metric_units_reddit_bot.