Comments (7)
- No, because a class is both a type and a value, whereas
const Response = globalThis.Response
is just a value. To get the type ofResponse
, you'd need to usetypeof Response
, which breaks the usual expectation for classes. That's an okay tradeoff for functions, because you needtypeof
for functions anyway (I'm pretty sure, at least). - Yes, this would be just another option
from workers-types.
Does Frankenstein's approach work for the other types as well? Any reason not to do that and be consistent on everything?
from workers-types.
Additionally, can we keep the global types for those that want to continue using workers-types in the v2 way?
from workers-types.
If we publish an ambient index.d.ts
and an importable index.ts
, existing code should keep working, and you'll also be able to import. Something to consider (cc @mrbbot), do we also want to try and publish to a @types/cloudflare-workers
or something like that?
from workers-types.
Hey @jacob-ebey, we're thinking about publishing importable Workers runtime types, as well as continuing to offer the global types. Do you have any thoughts on this? Would there be interest in using the importable types in the Remix packages/templates? Or does it make sense only for users to use directly themselves?
from workers-types.
We should be able to close all these issues if we do this:
from workers-types.
I'm going to close this, as you can now import type { ... } from "@cloudflare/workers-types"
as of @cloudflare/workers-types
version 4.
from workers-types.
Related Issues (20)
- Missing properties on IncomingRequestCfPropertiesBotManagement HOT 1
- Incorrect D1 types HOT 2
- RequestInit is missing some properties like 'cache' HOT 3
- Generate types from `workerd` RTTI HOT 1
- Fix `request.cf` types
- Generate exportable version of `workers-types` HOT 1
- add JSDocs documentation in types
- Move overrides to `workerd` C++ source code HOT 1
- Include C++ parameter names in types generated from JSG RTTI HOT 2
- Get type hints on incoming Request object HOT 4
- IncomingRequestCfPropertiesGeographicInformation makes geo property access an error (regression from 3.17.0) HOT 7
- HtmlRewriter ElementHandler methods can only accept strings (not general Content) HOT 1
- (3.18.0) IncomingRequestCfPropertiesGeographicInformation is the wrong type HOT 2
- Class 'Request<ParamKeyType, Data>' incorrectly extends base class 'Body' HOT 1
- `new Request` bad type HOT 8
- addEventListener has a broken type definition HOT 1
- NPM Release @cloudflare/worker-types 4.20221111.0 HOT 2
- Add Symbol.iterator to WebScoketPair HOT 1
- What is Fetcher for? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from workers-types.