Giter Site home page Giter Site logo

Comments (4)

thexeos avatar thexeos commented on July 18, 2024

Also, not sure if related, but after forcing the type with const cf = (event.request as any).cf as IncomingRequestCfProperties, trying to access cf.country leads to

Property 'country' does not exist on type 'IncomingRequestCfProperties<unknown>'.
  Property 'country' does not exist on type 'IncomingRequestCfPropertiesBase & IncomingRequestCfPropertiesBotManagementEnterprise & IncomingRequestCfPropertiesCloudflareForSaaSEnterprise<...> & IncomingRequestCfPropertiesCloudflareAccessOrApiShield'.

Note how IncomingRequestCfPropertiesGeographicInformation is not included in the derived type definition, yet I see it included in this repo.

Is this something that you can reproduce?

from workers-types.

thexeos avatar thexeos commented on July 18, 2024

Upon some further investigation, it seems like Request from lib.dom.d.ts always takes precedence.

image

Even though the custom Request is defined in the same file, as it is not namespaced in any way, the custom definition is not used.

from workers-types.

philipatkinson avatar philipatkinson commented on July 18, 2024

I have a feeling that this is the same issue as #311 (certainly the 'country does not exist' error is the same one you get with the most recent release). #310 (my pull request with the fix) might therefore be the solution.

from workers-types.

mrbbot avatar mrbbot commented on July 18, 2024

Hey! 👋 @cloudflare/workers-types is not compatible with lib.dom.d.ts. Make sure you're tsconfig.json looks something like:

{
  "compilerOptions": {
    ...
    "lib": ["ES2020"],
    "types": ["@cloudflare/workers-types"]
  }
}

from workers-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.