`new Request` bad type

[probablykasper]

`new Request` bad type

[probablykasper]

I think it might be caused by the Svelte VSCode extension, so filed an issue there for now: sveltejs/language-tools#1733

Thanks for the help on figuring it out !! ❤️

[eugene1g]

This is hit&miss, but in some cases, it worked for me when to add /// <reference types="@cloudflare/workers-types" /> as the very first line in the TypeScipt file, to help it reference CF types vs lib.dom.

[penalosa]

It seems like you might be trying to use workers-types in combination with libdom? That's generally not a path we recommend (see the README on npm for the recommended setup). However, with the just-released workers-types@4, you're able to import the types, which may help:

import type { Request as WorkersRequest } from "@cloudflare/workers-types"

[eugene1g]

It's probably fine to close this, but the problem is caused by two nuances so I'll leave further notes here -

1. IDEs often include TypeScript's lib.dom.d.ts for all .ts files even if tsconfig.json has a narrow list of libs like "lib": ["ES2020"]
2. When the code references global objects like new Request(url), the IDE will use the definition of Request from lib.dom.d.ts that ships with TypeScript, which has incorrect types (for example, the cf parameter is missing). Importing the custom type for Request from @cloudflare/workers-types will not help because the code uses the actual new Request() runtime object which cannot be (reasonably) changed in type via TS type hints.

That's why the workaround is to tell TypeScript to use @cloudflare/workers-types for that file as I showed in the example above. In theory, doing this override in tsconfig.json with the types directive works the same (as is explained in the README), but that didn't do the trick for me several times.

[probablykasper]

@penalosa I don't have libdom anywhere. My tsconfig.json is the same as what's suggested in the README, except I have "module": "esnext" instead of "CommonJS".

@eugene1g Adding /// <reference types="@cloudflare/workers-types" /> to the start of the file doesn't seem to fix it unfortunately. Also, the cf parameter isn't missing for me - I have both cf and mode, etc.

[penalosa]

@probablykasper If you're seeing cf and mode, that's definitely unexpected behaviour. It's most likely that libdom or libwebworker is being included somewhere (perhaps by a framework you're using?), but could you clarify the version of the types you're using, and whether @cloudflare/workers-types@4 fixes the issue?

[probablykasper]

I'm using v4 now, but it was also an issue on v3

[penalosa]

Would you be able to set up a reproduction repository?