colinoflynn/dp832-gui

Rigol DP832 GUI Example

dp832-gui's Issues

Address documentation

Hi, I wanted to point out that the address string is on the "utilities" page of the power supply itself, so you don't have to get it from Ultra Sigma if you don't want to. This is especially handy for people who aren't running Windows, or people who don't want to download 200MB just to copy an address.

Points Spinbox and Channel ComboBox only affect the last graph

Great project, thanks for sharing.

I am novice but made several changes to support running on Pyton3 so may have broken it and the issue below maybe my doing.

I was working on changes to display all channels at once and finally discovered that you already have this feature. I just needed to change the initial gui spinbox to 3.

However, after selecting 3 in the spinbox in the connect gui, any changes to any Points spinbox or Channel dropbox only effect the last graph.

If I print the graphnum value that is passed to def setPoints(self, graphnum, points): it always produces as "2" regardless of which spinbox I am spinning.

I thought it may have been the missing self on these lines

        sbPoints = QtWidgets.QSpinBox()
        sbPoints.setMinimum(1)
        sbPoints.setMaximum(500000)
        sbPoints.setValue(self.graphsettings[-1]["points"])
        sbPoints.valueChanged.connect(lambda x: self.setPoints(i, x))

as these lines have a self

       self.cbChannel = QtWidgets.QComboBox()
        self.cbChannel.addItem("CH1")
        self.cbChannel.addItem("CH2")
        self.cbChannel.addItem("CH3")
        self.cbChannel.setCurrentIndex(i)
        self.cbChannel.currentIndexChanged.connect(lambda x :self.setChannel(i, "CH%d"%(x+1)))

I will continue to track down the issue and update if I find the cause.