Giter Site home page Giter Site logo

Comments (3)

EduEyras avatar EduEyras commented on August 13, 2024

from suppa.

mikelove avatar mikelove commented on August 13, 2024

Ah that's good to know. So there is not correction across genes, just within. Maybe suggest putting this statement in the docs, because users shouldn't expect FDR control across genes.

A few more suggestions: I think where you have family wise error rate in the docs, I think you should put something like "within-gene false discovery rate", because BH doesn't provide FWER control.

I think that you can drop alpha as an argument. It's not used by multipletests unless method='fdr_twostage':

https://github.com/statsmodels/statsmodels/blob/942fa69230944705f8072e9c338120455b7015a0/statsmodels/stats/multitest.py#L108-L109

I'm going to try out computing p-values per isoform, and then do my own aggregation. Interesting to know about the method differences also, I'll try out empirical vs classical.

from suppa.

EduEyras avatar EduEyras commented on August 13, 2024

from suppa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.