cpettitt/cp-data

A JavaScript library for a simple Set data structure.

cp-data's Issues

Set.union method breaks in Chrome

Hi,

The "keys" method is also available for native arrays in chrome. That is why the union method will fail in Chrome browsers, when one of the sets is a native array (seen in your dagre-d3 project).

Orig Method:
Set.union = function(sets) {
var totalElems = sets.reduce(function(lhs, rhs) {
return lhs + (rhs.size ? rhs.size() : rhs.length);
}, 0);
var arr = new Array(totalElems);

var k = 0;
for (var i = 0, il = sets.length; i < il; ++i) {
var cur = sets[i],
keys = cur.keys ? cur.keys() : cur;
for (var j = 0, jl = keys.length; j < jl; ++j) {
arr[k++] = keys[j];
}
}

return new Set(arr);
};

When I changed the following check from:
var cur = sets[i],
keys = cur.keys ? cur.keys() : cur;

to

var cur = sets[i],
keys = cur instanceof Set ? cur.keys() : cur;

it works.

Best regards
Tino