Comments (9)
Can you provide the snippet of code where you manually combined estimatestruct + mle_estimateparams? And what indicated that lg_estimatebn() was not performing skel.toporder()?
from libpgm.
[old comment]
from libpgm.
I tested your scenario and noticed that repeatedly running toporder() on a GraphSkeleton produced different topological orderings. This would explain some of your issue. I believe all the orderings were still valid, but since it's confusing behavior I pushed up a change to make the results of toporder() consistent.
from libpgm.
In response to the second question: currently the library can calculate the likelihood of specific outcomes only for discrete Bayesian networks. Are you looking for similar functionality for linear Gaussian Bayesian networks?
from libpgm.
[old comment]
from libpgm.
Glad to help and thanks for the submission. We have no plans as of now to implement that functionality, but we'll keep the feature in mind, and we are happy to accept pull requests if you or others would like to contribute.
from libpgm.
Hey Charlie,
Thanks! Many thanks for your suggestions, I am definitely interested to implement that, as I will need to use that in my research anyway. I am just wondering if there is any way I could be credited if I were to develop that?
I also confirmed that the discrepancy is resolved. However, I find that, as the order is fixed now, the structure learning depends on the order given in the data. In other words, if I were to rearrange my columns, I could get different fitting, some of which are better than the other. Since there is no way to evaluate the maximum likelihood in each case, I haven't found a way to compare them automatically (i.e. randomize the order and find a heuristic best fitting).
Thank you!
Cheers,
Yuan-Sen
from libpgm.
Yuan-Sen,
We would be happy to credit your enhancement. We should proceed as follows:
- fork our repo (into your personal area)
- Make your changes. Provide tests and documentation.
- Issue a pull-request through github
- We will review your changes and merge
Cheers!
Mike
Mike West
CyberPoint Labs
direct +1 410 779 6757
mobile +1 443 520 3950
CyberPoint International
621 East Pratt Street, Suite 300
Baltimore MD 21202-3140
phone +1 410 779 6700
www.cyberpointllc.com http://www.cyberpointllc.com/
If you believe you received this e-mail in error, please notify the sender
immediately, delete the e-mail from your computer and do not copy or
disclose it to anyone else.
The information in this email constitutes the proprietary information of
Cyber Point International, LLC (DBA CyberPoint), and should be accessed only
by the individual to whom it is addressed. The information in this email and
any attachments may not be used, copied or disclosed without the consent of
CyberPoint. CyberPoint is not responsible for any damages caused by your
unauthorized use of the materials in this email.
From: Yuan-Sen Ting [email protected]
Reply-To: CyberPoint/libpgm
<reply+00322f49fda165789d13c3d54419940fef5f78048be0e35292cf00000001112bca3f9
[email protected]>
Date: Thursday, March 26, 2015 at 9:23 AM
To: CyberPoint/libpgm [email protected]
Subject: Re: [libpgm] old comment
Hey Charlie,
Thanks! Many thanks for your suggestions, I am definitely interested to
implement that, as I will need to use that in my research anyway. I am just
wondering if there is any way I could be credited if I were to develop that?
I also confirmed that the discrepancy is resolved. However, I find that, as
the order is fixed now, the structure learning depends on the order given in
the data. In other words, if I were to rearrange my columns, I could get
different fitting, some of which are better than the other. Since there is
no way to evaluate the maximum likelihood in each case, I haven't found a
way to compare them automatically (i.e. randomize the order and find a
heuristic best fitting).
Thank you!
Cheers,
Yuan-Sen
‹
Reply to this email directly or view it on GitHub
#7 (comment) .
from libpgm.
Thank you, Mike for the information. Hopefully I will get back to you on
the upgrade in the near future :).
On Thu, Mar 26, 2015 at 9:26 AM, mike [email protected] wrote:
Yuan-Sen,
We would be happy to credit your enhancement. We should proceed as follows:
- fork our repo (into your personal area)
- Make your changes. Provide tests and documentation.
- Issue a pull-request through github
- We will review your changes and merge
Cheers!
MikeMike West
CyberPoint Labs
direct +1 410 779 6757
mobile +1 443 520 3950CyberPoint International
621 East Pratt Street, Suite 300
Baltimore MD 21202-3140
phone +1 410 779 6700
www.cyberpointllc.com http://www.cyberpointllc.com/
If you believe you received this e-mail in error, please notify the sender
immediately, delete the e-mail from your computer and do not copy or
disclose it to anyone else.The information in this email constitutes the proprietary information of
Cyber Point International, LLC (DBA CyberPoint), and should be accessed
only
by the individual to whom it is addressed. The information in this email
and
any attachments may not be used, copied or disclosed without the consent of
CyberPoint. CyberPoint is not responsible for any damages caused by your
unauthorized use of the materials in this email.From: Yuan-Sen Ting [email protected]
Reply-To: CyberPoint/libpgm<reply+00322f49fda165789d13c3d54419940fef5f78048be0e35292cf00000001112bca3f9
[email protected]>
Date: Thursday, March 26, 2015 at 9:23 AM
To: CyberPoint/libpgm [email protected]
Subject: Re: [libpgm] old commentHey Charlie,
Thanks! Many thanks for your suggestions, I am definitely interested to
implement that, as I will need to use that in my research anyway. I am just
wondering if there is any way I could be credited if I were to develop
that?I also confirmed that the discrepancy is resolved. However, I find that, as
the order is fixed now, the structure learning depends on the order given
in
the data. In other words, if I were to rearrange my columns, I could get
different fitting, some of which are better than the other. Since there is
no way to evaluate the maximum likelihood in each case, I haven't found a
way to compare them automatically (i.e. randomize the order and find a
heuristic best fitting).Thank you!
Cheers,
Yuan-Sen‹
Reply to this email directly or view it on GitHub
#7 (comment) .—
Reply to this email directly or view it on GitHub
#7 (comment).
from libpgm.
Related Issues (19)
- dev_struct_finding : typo + bug HOT 1
- Lgandd with discrete parents only HOT 2
- TableCPDFactorization.specificquery() for Discrete BN throws Value Error HOT 4
- Problematic 'utils' module at top level root in site-packages
- Issue with setting the seed for experiment replication HOT 1
- discrete_constraint_estimatestruct assert Graph contains a cycle
- Integer values HOT 4
- Compatability with Python 3 HOT 3
- compatablity with python3.4
- The build directory should probably be empty
- Method choose from Discrete node not working HOT 4
- Soft evidence in libpgm
- Support for learning hybrid network parameters from data?
- Multiple specific queries? HOT 5
- Why was the lastest update three years ago? HOT 8
- Error while importing DiscreteBayesianNetwork on Colaboratory
- [old comment]
- lg_constraint_estimatestruct does not give the same ordering
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libpgm.