darvaza-proxy/slog

structured logger adaptors

slog's Issues

tests

$ make test
▶ generating subproject rules
▶ test: root
?       github.com/darvaza-proxy/slog   [no test files]
?       github.com/darvaza-proxy/slog/internal  [no test files]
▶ test: logrus
?       github.com/darvaza-proxy/slog/logrus    [no test files]
▶ test: zap
?       github.com/darvaza-proxy/slog/zap       [no test files]
▶ test: zerolog
?       github.com/darvaza-proxy/slog/zerolog   [no test files]
▶ test: cblog
?       github.com/darvaza-proxy/slog/cblog     [no test files]

we need to find a way to test implementation and compliance of each adaptor we implement. currently reduced to zerolog and cblog, but also the *log.Logger writer at the top level and the internal/ helpers

zerolog: Fatal() and Panic() continue

The following, using zlog.Fatal() or zlog.Panic() ends before the unreachable mark

package main

import (
	"os"

	"github.com/rs/zerolog"
)

func main() {
	zlog := zerolog.New(zerolog.ConsoleWriter{
		Out: os.Stderr,
	})
	zlog.Fatal().Msg("Fatal")
	panic("unreachable")
}

�[90m<nil>�[0m �[1m�[31mFTL�[0m�[0m Fatal

Program exited.

but when using our wrapper, it doesn't.

package main

import (
	"os"

	slog "github.com/darvaza-proxy/slog/handlers/zerolog"
	"github.com/rs/zerolog"
)

func main() {
	zlog := zerolog.New(zerolog.ConsoleWriter{
		Out: os.Stderr,
	})
	log := slog.New(&zlog)
	log.Fatal().Print("Fatal")
	panic("unreachable")
}

�[90m<nil>�[0m �[1m�[31mFTL�[0m�[0m Fatal
panic: unreachable

goroutine 1 [running]:
main.main()
	/tmp/sandbox1363277814/prog.go:18 +0x15b

Program exited.

Log back-end location

I was thinking if we should not have a backends folder for the log backends. Having them all in root seems a bit messy.
Something like

mkdir -p backends
git mv zerolog backends/zerolog

It will make #12 a bit easier to implement.