Giter Site home page Giter Site logo

dcir's Introduction

dcir's People

Contributors

decipher avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

dcir's Issues

Change Dockerfile source

Currently the Dockerfile uses drupalci/web-5.6, however there is a lot of stuff in that image that is not currently in use.

Add ability to execute specific runners

Currently DCIR will run Code review followed by Simpletest, it would be preferable if you could specify which runners you want in the .dcir.yml, as well as pass an argument into the docker run command to trigger an specific runner.

Don't error when no tests found

Currently with the automagic discovery, if there are no tests to run DCIR will error:

ERROR: No valid tests were specified.

PHPCS: Make verbose

If PHPCS doesn't find any issues it doesn't produce any output. Ideal if run as verbose.

Improved bash code styling

I suggest following https://google.github.io/styleguide/shell.xml#Variable_Names

Currently, global constants, env variables and one-time variables that can be local are using the same UPPERCASE format. Would be nice to have local vars as lowercase.

Also, lots of functionality is executed in global context without being split into functions. I suggest moving some functionality into functions to make contribution and debugging easy.

Add '--no-dependencies' flag

In the case of custom modules/features, the dependencies might not be accessible via drupal.org and therefore they can't be enabled.

Adding a '--no-dependencies' flag will allow DCIR to still be run regardless.

Replace PHPCS with DCR

To compensate for things like Features and other such code that shouldn't be considered as a Failure, PHPCS should be replaced with DCR.

Fix typos/mistakes in documentation.

So there's a few typos/mistakes the the documentation. One was more critical than the others and has been hotfixed, the other's can wait till 0.7.0 ideally.

Add Drush as a requirement.

Currently the DCIR Dockerfile is installing Drush, where in reality it should be a requirement of this package.

Get (test) module dependencies.

Before running simpletest, DCIR needs to enable the module via Drush to ensure that any dependencies are available.

It will also need to ensure that any test dependencies are present.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.