digitalcraftsman/hugo-agency-theme

Port of Startbootstrap's Agency theme to Hugo

hugo-agency-theme's Issues

page-scroll in class with more than one class does not work

I can't get page-scroll to work in links that has more than one class:

this works:

<a class="page-scroll" href="{{ .Site.BaseURL }}#services">{{ with .Site.Params.navigation.services }}{{ . | markdownify }}{{ end }}</a>

But not this:

<a class="page-scroll btn btn-primary btn-block uppercase" href="{{ .Site.BaseURL }}#services">Weitere Informationen</a>```

JQuery Error: Syntax error, unrecognized expression: http://localhost:1313/#services

Font Awesome Icons are not shown in IE and Chrome

Font Awesome Icons are not shown in IE and Chrome from Windows and MacOS.

They are shown fine in Safari, and Chrome from iOS though.

Template is missing: _internal/google_analytics.html

This is referenced in layout partials in the js.html file:
{{ template "_internal/google_analytics.html" . }}

But there is no such file.

I can, of course, whip one up myself, but how should it look like?

Fix various issues with current PoC aka dev

• /index/ rendered -> should return 404
• /de/index/ rendered -> should return 404
• index partials show up within sitemap -> workaround added (custom sitemap template)
• index partials show up within sitemap -> native hugo solution similar to '_index' for multiple files
• index partials create rss index -> workaround added (custom rss.xml template)
• index partials create rss index -> native hugo solution

Move content into separate files

The first idea is to have the following content structure:

content/page/$single_pages.md
content/elements/service/$serviceA.md
content/elements/contact.md

Services and other elements could be sorted by weight first and by date second.
Each element or item within a frontpage element has its own file. Global settings like disabling elements would still live in config.toml, but usual default would be, if a file is available for an element it is considered enabled and needs to optionally be disabled in config.toml.

Furthermore the email and contact form provider could be considered global settings and be kept in config.toml.

As this will break compatibility a major version change should occur.

Fix menu.prepend/.postpend

I'm new to Hugo, so it's possible I'm just doing something wrong, but when uncommenting the examples of [[menu.prepend]] and [[menu.postpend]] in the config.toml file, nothing changes with regard to the menu on the site.

Additionally: {{ printf "%#v" .Site.Menus.prepend }} in index.html prints "<nil>" as does {{ printf "%#v" .Site.Menus.prepend.HasChildren }}

Relevant section of the config:

  # prepended links
  [[menu.prepend]]
    url = "http://gohugo.io"
    name = "Hugo"
    identifier = "hugo"
    weight = 11

  # postpended links
  [[menu.postpend]]
    url = "http://gohugo.io"
    name = "Test"
    weight = 10

I'd love to find out the error is on my end if anyone has a fix!

[Question] Disable scroll on clicking menu

Hello,

Thanks for your great work. I wonder if there's configuration to disable scrolling on clicking menu just like the demo site?

Thanks,
Tom

Update jQuery to more recent version

Currently, this theme uses jquery-1.12.4. The lastest versions are around v3... Some testing needs to be done before updating.

description can only write in one line? and how to insert image?

hello, can you tell me how to edit my article in multi-line ? and how to insert a image in my article since including description of *.yaml file.

Add versioning using Git tags

Contact form submission button not displaying any message

When I am clicking on "Send Message" button of contact form, it is not showing any error or thank you message but I am able to receive the message in my email. I tried it in multiple browsers but the behaviors is same.

Easy way to change colors?

I'm not a web developer so bear with me. Is there an easy way to change the color scheme? I see there's a bunch of css in agency.css that references the yellow color (#fed136) for instance. I would like to replace it. Is there a better way than just search and replacing them? Thanks!

contact form not working

I can't seem to get the contact form to work on my site (lizmillerfit.com). I received 1 confirmation email (and confirmed it), but I cannot submit any messages via this form. Does anyone have a solution to this? Thanks

safehtml not defined

When I use the template with hugo binary 0.13 I get the below errors

hugo server
ERROR: 2015/06/23 template: theme/partials/about.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/clients.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/contact.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/footer.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/head.html:8: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/hero.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/js.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/modals.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/nav.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/portfolio.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/services.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 template: theme/partials/team.html:1: function "safeHTML" not defined
ERROR: 2015/06/23 html/template: "theme/partials/head.html" is an incomplete template in theme/partials/head.html
ERROR: 2015/06/23 html/template: "theme/partials/nav.html" is an incomplete template in theme/partials/nav.html
ERROR: 2015/06/23 html/template: "theme/partials/hero.html" is an incomplete template in theme/partials/hero.html
ERROR: 2015/06/23 html/template: "theme/partials/services.html" is an incomplete template in theme/partials/services.html
ERROR: 2015/06/23 html/template: "theme/partials/portfolio.html" is an incomplete template in theme/partials/portfolio.html
ERROR: 2015/06/23 html/template: "theme/partials/about.html" is an incomplete template in theme/partials/about.html
ERROR: 2015/06/23 html/template: "theme/partials/team.html" is an incomplete template in theme/partials/team.html
ERROR: 2015/06/23 html/template: "theme/partials/clients.html" is an incomplete template in theme/partials/clients.html
ERROR: 2015/06/23 html/template: "theme/partials/contact.html" is an incomplete template in theme/partials/contact.html
ERROR: 2015/06/23 html/template: "theme/partials/footer.html" is an incomplete template in theme/partials/footer.html
ERROR: 2015/06/23 html/template: "theme/partials/modals.html" is an incomplete template in theme/partials/modals.html
ERROR: 2015/06/23 html/template: "theme/partials/js.html" is an incomplete template in theme/partials/js.html
0 of 1 draft rendered
0 future content
0 pages created
0 paginator pages created
0 tags created
0 categories created
in 16 ms
Serving pages from /Users/ajay/hugo/site1/public
Web Server is available at http://localhost:1313/
Press Ctrl+C to stop

Add favicon config

Custom SVG for param.services.row.list

Hi,

I'd like to use a SVG file which is not available from fontawesome.io ( The Angular Library icon).
Is there a recommended guideline i could follow to use it ?

Thanks x. 👍

fix oddly asymmetric layout of team

this looks weird to me because it is not centered. Feels like there should be 3 per row perhaps?

oddly, upstream at https://blackrockdigital.github.io/startbootstrap-agency/ the layout IS symmetric with 3 per row:

Add version to fonts and js

During the versioning maybe update the used scripts and fonts aka font-awesome, jquery etc..

Add multi-language support

I customize some months ago your awesome template to fix some of the things that the last 50 mails have notified me, and to add multi-language support.

In 2-3 months I will have enough spare time to adapt my code to the new commits and clean it up to make a pull-request, if you don't mind.

I open the issue so if in this 2-3 months anybody wants to do it, 2 months earlier for everybody to have the feature.

Some inconsistency between themes

In Creative it's called /img/header.jpg

Here it's called something else.

It would be nice if there were some naming conventions among these similar themes.

include CC license in footer

it would be nice to have a properly formatted CC license in the footer, perhaps in the style of the social links.
CC provides nice html for this purpose, like so, from: https://creativecommons.org/choose/

<a rel="license" href="http://creativecommons.org/licenses/by-nc-nd/4.0/"><img alt="Creative Commons Lizenzvertrag" style="border-width:0" src="https://i.creativecommons.org/l/by-nc-nd/4.0/88x31.png" /></a><br />Dieses Werk ist lizenziert unter einer <a rel="license" href="http://creativecommons.org/licenses/by-nc-nd/4.0/">Creative Commons Namensnennung - Nicht kommerziell - Keine Bearbeitungen 4.0 International Lizenz</a>

Prevent body from scrolling to top when modal is opened.

@digitalcraftsman In the online demo of the theme (https://themes.gohugo.io/theme/agency/) the body element does not scroll at all when the portfolio modal is opened.

But when running the example site locally (without any modifications) I have run into the following:

When the modal is opened the body scrolls to the top as the modal-open class is being added to it and then when the modal is closed the body scrolls down again roughly (but not exactly) to the point where it was when the modal was first opened.

It's a bit of a distracting animation and I would like to get rid of it. Any pointers?

Add description to team members

Wanted to log this idea upstream instead of just on our internal tracker.

Basically give members the ability to add a description about themselves and about what they do.

Successfully submittied form causes an error message

For some reason successfully submitted message always returns an error message. This was previously not the case, the formspree thanks page was shown instead. I guess, it has something with the migration to jquery.form-validator, but I am not sure how to nail it down.
Using standard configuration, no modifications made to any involved files.

Add option to disable or exchange contacts provider

Not sure on the implementation yet, but wanted to log the issue upstream already.

A way to turn off sections

This is a very nice theme; I had a super-good-looking site up and running in two languages in no time.

But, I'm not ready with all the sections yet -- and I may not need them all, so it would be nice to have a config options to turn off a section.

What I have done now is to just copy the index.html and comment out the sections not neede - but some flags and I wouldn't have to do that.

Best way to add disclaimer / impress

What is the best way to add an extra page for additional content like a disclaimer or an impress?

Add language switcher

Have a look at the dev branch which adds support for i18n.

add testimonials to main page

I know this isn't part of the original, upstream agency theme, but I thought I'd add this here anyway as a suggestion.

Two validations errors

Hello DigitalCraftsman. I’m trying to use your exellent theme. It works fine except when I run it through the very useful html5 validator, it throws two erros:

1. Line 15 in your head partial should really be on two lines, with your quotation marks fixed, so that:

   <link href="https://fonts.googleapis.com/css?family=Kaushan+Script" rel="stylesheet" type="text/css'>" link href="https://fonts.googleapis.com/css?family=Droid+Serif:400,700,400italic,700italic" rel="stylesheet" type="text/css">

   becomes:

   <link href="https://fonts.googleapis.com/css?family=Kaushan+Script" rel="stylesheet" type="text/css">

   <link href="https://fonts.googleapis.com/css?family=Droid+Serif:400,700,400italic,700italic" rel="stylesheet" type="text/css">

2. Between line 24 and line 25 in you team partial:

   you should insert a </div> in there (you omitted to close your <div class="row"> that was openned on line 10

3. Also in that same file at line 19 you omitted to close the <li> so that:

   <li><a href="{{ index . 1 }}"><i class="fa {{ index . 0 }}"></i></a>

   should become:

   <li><a href="{{ index . 1 }}"><i class="fa {{ index . 0 }}"></i></a></li>

   (Note: the html5 validator did not complain about that last one, it’s just something I noticed.)

That’s it, thanks!

Fix member formatting

With #39 a regression was introduced for vastly differently sized member items.
3 items should always define a row, with a set size of the biggest element.

Might be able to solve #36 in the process.

How to include/exclude features from a Portfolio page

Hi!

I'm trying to make sure that the Portfolio entry displays a YouTube video or photo if there is one specified in the .yaml file, and excludes the field if there isn't anything specified.

I'm bringing in the YouTube videos like this in the .yaml file:

youTube = [unique ID here]

.. and including in the modal.html file like this:

<iframe width="560" height="315" src="https://www.youtube.com/embed/{{ .youTube }}?rel=0" frameborder="0"></iframe>

Which works great. However, if there isn't a YouTube video for this portfolio item I want to skip this section when it's rendered.

How do I specify "If this field exists in the .yaml file, render these lines of HTML"? I've tried {{ if (isset .Params "youTube") }} and the like but I'm sure my syntax is wrong.

Thanks for any tips, and for an excellent theme! :)

Changes not apply

Hi,

I'm using your theme and I follow the steps of the Readme but when I launch my website, the text fields are empty :

Did I do something wrong ?
Thanks for the help!

Used contact form validation library does not support new TLDs

Switch to another validation library. Maybe after moving to the latest bootstrap version.

Relevant issue:
ReactiveRaven/jqBootstrapValidation#185

Possibility to use captchas for contact form

Focus on recaptcha2 first and maybe provide another captcha solution as further iteration.

Update documentation in the README for new version

Team members section broken

Whenever the teams member number is not 3, 6, 9... the team members section keeps the members aligned to the left, leaving gaps or free space on the right side, instead of centering them.

add image credit for background images

It would be really nice if the backround images could support an image credit and url field, sometimes important for licensing stuff etc.

The Jekyll template Minimal Mistakes as implemented this quite nicely via YAML front matter.

contact form fails when recaptcha challenge is returned

Hi,

I successfully configured theme(It's great, thanks!), but encountered problem - when formspree thinks that I'm a bad guy, sends me back an recaptcha on their site - but site doesn't notice about it(even warning message isn't displayed), so it's seems unresponsible.

Hotfix? It works better when appropriate function from agency.js is removed, but maybe some response-dependent logic is necessary if async form is priority.

#61

Height of background image

The theme looks great on a laptop/desktop - thank you!
On a mobile display, the hero background however does not extend to the height of the screen, and it looks a little strange.
Is there a way to increase the height of the image please?

Does description in the portfolio part support markdown?

Does description in the portfolio part support markdown syntax? For example, I want to type following format in the project description align left

• 2131
• 1313
• 1312

Quick question re: blog

Just checking that the best way to add a blog is to run another Hugo instance in a subdir/subdomain (thinking of using Detox theme for the moment) and add an external link?

If there's another way to add posts, I'm all ears.

Thanks for the theme, it's great.

Only show non empty contact form fields

Hi,

When I comment out the phone field in the contact fom as

# [params.contact.form.phone] # text = "Your Phone *" # warning = "Please enter your phone number."

it still shows as in attachment.
Plz guide how to remove it completely.

Thanks in advance.

Using inline tables in configs.toml

Currently Hugo's used TOML package does not support inline tables. See issue #70.

Switch after the integration to inline tables and remove the work around.

404 page template

Add minimal 404 page.

Make text and maybe image customizable.

Reuse nav and footer partials.

add powered by Hugo, digitalcraftsman in footer

I'd like to give a shoutout to Hugo and @digitalcraftsman and the upstream creators in my usage of the theme. Could you add something like that to the footer properly designed? I'd love that.
Thanks for the great work.

Add link/url property to Services items?

I would love it if the services items could be clickable links to other pages. Most obvious would be pages with more in-depth descriptions of what the services are.

Obviously Agency itself wouldn't be creating those pages, but it would be nice to have the option.

status of dev branch

hi there, I remember a while back that the dev branch wasn't recommended for production, but I'm eager to try out some of the new stuff and fixes on dev.

Any news on the status?

Get rid of less files etc in /static

/static is pretty heavy data wize -- you should consider to get the CSS only dist version of Font Awesome etc.

Single page layout

Add single page layout. Usable for things like "about us", "disclaimer", "terms" etc.

Optional contacts form, which can be enabled per page.

Stretch: Use for blog layout: #22