Feature request: support running project version of tsc instead of global version

[dmmulroy]

Feature request: support running project version of tsc instead of global version

[dmmulroy]

Hey thanks for the feedback and issue, you aren't the first to request this - it's heard and I'm planning on working on that early this week 🚀

[mmirus]

Super appreciative of the plugin! I've been waiting for something like this for a long time. Hopefully in the long run we can get it from the language server, but this is a great step forward in the meanwhile.

PS - totally unrelated, but in case anyone wants to have the results automatically open in Trouble: folke/trouble.nvim#70 (comment)

[mmirus]

Awesome! Happy to help test when the time comes. Thank you!

[dmmulroy]

Super appreciative of all feedback, support, and help 🙏

[ecosse3]

@dmmulroy It works great now, thanks!

[dmmulroy]

Hey @mmirus - the fix/feature should be merged into main and should work. Wanna give it a test run?

[mmirus]

It finds the local binary now. TY!

I did have this weird experience with the notifications, where it showed many of them instead of a single one that updates. I'll see if I can pinpoint anything in my config that causes it / a way to fix it, and if not I'll open a new issue.

Thank you again for for the quick work on this one!

[ecosse3]

@dmmulroy I have this issue now and I am unable to run TSC command in Neovim v0.10.

.local/share/nvim/lazy/tsc.nvim/lua/tsc.lua:71: attempt to call field 'get_tsc_cmd' (a nil value)

I have node_modules/.bin/tsc:

◌ tsc ➛ node_modules/typescript/bin/tsc

TSC Version 4.9.5

[mmirus]

From a quick glance it looks like it can't find the get_tsc_cmd method from the utils module, not like it can't find the tsc binary. But you would think that if it has the new code that calls get_tsc_cmd, you would also have the new utils file. Maybe some weird caching thing or something? Just spitballing.

[ecosse3]

@mmirus @dmmulroy Yeah, that looks super weird. I reviewed code and it looks fine. Can it be an issue that in my nvim lua config I have file names utils? So it conflicts with plugin? I am not sure. Maybe pcall should be made on require? After I reverted to the previous commit it works again:

lazy.nvim

{
  "dmmulroy/tsc.nvim",
  cmd = "TSC",
  commit = "80c1839071443a7139cd8e1c93c6f78e35e5cf8f",
  config = true
},

[dmmulroy]

@mawkler's PR #8 hopefully resolves the utils issue. Try updating to main and see if that worked.

[mmirus]

Oh yeah, that could do it! 🤞

[mmirus]

PS - this still works for me after pulling in the changes from #8.