Comments (3)
@marwie do you feel that the message is inaccurate or shouldn't be a warning? Or just that the logging is too noisy? Note that sparse()
will detect these and remove them.
from gltf-transform.
It feels noisy
I'm also not sure how/why the percentage rate increases - is this expected?
Regarding sparse: would you recommend that I add a call to sparse()
by default?
from gltf-transform.
Current behavior is that for each accessor marked as sparse, I/O will log a warning if the % of non-zero values in the accessor is above the threshold at which use of sparse accessors increases final file size:
glTF-Transform/packages/core/src/io/writer.ts
Lines 271 to 275 in 759bfd7
Perhaps I've got the threshold slightly wrong though, there's a (small) file size increase if we make these accessors non-sparse. In general there's no harm including sparse()
by default, it should only change accessors if they benefit. It's included in the CLI 'optimize' command for example:
glTF-Transform/packages/cli/src/cli.ts
Line 396 in 759bfd7
This does require a pass over ever element of every accessor, so if you're really tight on the processing time budget, maybe better to do something targeted only to morph target accessors.
In any case, I'm open to making this logging less noisy.
from gltf-transform.
Related Issues (20)
- An option to keep separate buffer views when doing `meshopt` HOT 7
- Unexpected handling of `generator` during `merge` HOT 3
- Race condition in toKtx.ts HOT 3
- Merging documents with extensions HOT 7
- Cache cleanup HOT 2
- Draco compression may produce an UNSIGNED_SHORT index buffer with vertex count > 65535 HOT 3
- Change default compression with 'optimize' CLI to Meshopt
- `partition` command is slow for large models HOT 6
- Simplify Draco and Meshopt compression implementations
- Prune fails to clean up accessors referenced by non-root properties HOT 2
- VRM gets treated as glTF instead of GLB HOT 11
- Serialization format for transforms HOT 2
- Roadmap for '@gltf-transform/view' package
- Quantization creates invalid skinning weights for CesiumMan.glb HOT 3
- Support transforms reporting a 'skip' result
- Minor glitch in documentation typings HOT 1
- implements meshoptimizer -sv HOT 1
- sharp error HOT 9
- Improving website credits
- CLI 'validate' command should use exit codes and stderr properly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gltf-transform.