dotvhs/shine-unofficial

Unofficial fork of SHINE for Reddit.

SHINE for Reddit (unofficial)

Download for Chrome | Download for Firefox

SHINE for Reddit was originally Chrome Extension made by u/TheTyGoss. This fork was created right after the extension was sold to another dev who immediately pushed update that was tracking all user activity in the internet.

What is SHINE?

Experience reddit with new modern list and grid view interfaces that focus on bringing the content to you.

What are the differences between original and fork?

First of all this is clutter-free version, all tracking was removed as well as Google Analytics. This version is also full-featured with all premium features unlocked.

Features

• Fixes for imgur photos and gifs
• Support for many new video sources (v.redd.it, clips.twitch.tv and streamable.com - thanks to u/itzblitz94)
• Basic theme support
• Firefox version

Authors

• TheTyGoss - Original author
• vhs - Current maintainer

See also the list of contributors who participated in this project.

shine-unofficial's Issues

Blank "expand" panel when using uAutoPagerize addon to autoload next page

As far as I can see there are no buttons to manually load next page in SHINE. Also, I'm using Firefox which has a bug that prevents RES "neverending Reddit" (next page autoloader) to work (sometimes it works, sometimes don't). So, I tried to use uAutoPagerize extension to do the same thing, which works (autoloads Reddit pages), but there is an issue: SHINE won't load information into "expando" on the second and subsequent (autoloaded)pages - expando opens blank only with the "Hide Child Comments" button on the bottom. I tried all three available "views" in SHINE - the result is the same. Maybe you can take a look when you have time. thank you.

Edit: when "neverending Reddit" is working as intended, and automatically loads next page, SHINE working just fine. The issue appears only on the pages that were loaded using uAutoPagerize.

Firefox 58.0.2
SHINE 1.6.1
RES 5.10.3
uAutoPagerize 0.1.4.1

Support for Microsoft Edge

This isn't exactly an issue, but still… Do you plan on releasing a Microsoft Edge version? I know the userbase is reduced, but this extension is so amazing, it would be great if it was available on Microsoft's browser.

Missing text for radio buttons

Missing text in the settings
This is in the develop branch

shine redirect to wrong url

hello

due to change on reddit , there is a bug (on Firefox) that redirect all picture to a wrong URL

this seem to be a redirect probleme in the extension

can you update your extension please .as i really love it , especially the grid layout

more info here :
it concerne the extension old reddit redirect but i think it's the same thing with shine
https://old.reddit.com/r/help/comments/15kwhgy/why_is_every_image_link_i_click_on_directing_me/

_**It's your old Reddit redirect extension/userscript.

I had the same issue and tracked it down using the Network tab of the browser's developer tools. Here's what's happening. Reddit has replaced the normal showing of images with their own shitty image viewer. URLs which used to go directly to images now get redirected to a special Reddit page. For example, if your image URL is https://i.redd.it/image.jpg, your browser receives a redirect to https://www.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Fimage.jpg. However, your extension sees this URL and immediately rewrites it to https://old.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Fimage.jpg. But there's no media viewer at the old.reddit.com domain, so instead Reddit sends you a post in /r/funny whose ID happens to be media.

The fix is to modify whatever old Reddit extension or userscript you're using to exclude https://www.reddit.com/media from its URL rewriting. You can either do this yourself, ask the developer, or switch to an extension whose developer has already applied a fix.**_

thank you

Saved icon missing on state

I've created a patch that will show when an item as been saved.
`
diff --git a/shine-grid.css b/shine-grid.css
index 7f3ef01..d613f25 100644
--- a/shine-grid.css
+++ b/shine-grid.css
@@ -231,6 +231,10 @@ html.SHINE.shine-grid body > .content #siteTable .thing ul.flat-list li.save-but
background-size: 18px;
}

+html.SHINE.shine-grid body > .content #siteTable .thing.saved ul.flat-list li.save-button a{

• background-image: url(data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz48c3ZnIHZlcnNpb249IjEuMSIgaWQ9IkxheWVyXzEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHg9IjBweCIgeT0iMHB4IiB2aWV3Qm94PSItMzEzIDQwMy43IDIwIDE5IiBzdHlsZT0iZW5hYmxlLWJhY2tncm91bmQ6bmV3IC0zMTMgNDAzLjcgMjAgMTk7IiB4bWw6c3BhY2U9InByZXNlcnZlIj48cGF0aCBkPSJNLTMwMyw0MTguOWw2LjIsMy43bC0xLjYtN2w1LjUtNC43bC03LjItMC42bC0yLjgtNi42bC0yLjgsNi42bC03LjIsMC42bDUuNSw0LjdsLTEuNiw3TC0zMDMsNDE4Ljl6IiBmaWxsPSJyZ2IoMjU1LDIxNSwwKSIvPjwvc3ZnPg==);
  +}

html.SHINE.shine-grid body > .content #siteTable .thing ul.flat-list .hide-button a{
width: 15px;
text-indent: 100%;
`

Font change

Is it possible to have an option to easily change the font?

Settings modal not styled properly

Not sure if intended, but settings window does not use selected theme.

Please add an option to change the (k-J) hotkeys because it interfers with video playback hotkeys

Video player uses the K key to play/pause, so user has to select the next post by mouse.
If possible make it A + D like playing video games (WSDA), or leave an option to user to change it.

Add support for new Reddit Redesign

Will the new redesign ever be supported? It was a huge overhaul so I am not expecting anything, but it would be wonderful if you could make it happen, thanks!

No thumbnail for v.redd.it or gfycat in grid view

In grid view, there are never any thumbnails for videos from v.redd.it (https://i.imgur.com/IrlQUqb.png) or gfycat (https://i.imgur.com/fTqXm5e.png)

While in list view, they do have thumbnails: https://i.imgur.com/jta9LPd.png, https://i.imgur.com/iAuDAdb.png

Icons are slightly off to the bottom

Using commit 463764c
Using List View, let me know if you require any more details :)

None of the sections under /user/ are styled correctly

Issue

None of the pages under the /user/ section are styled correctly when using Shine.

Examples:

• https://www.reddit.com/user/{USERNAME}/posts/
• https://www.reddit.com/user/{USERNAME}
• https://www.reddit.com/user/{USERNAME}/comments/

Expectation

If I set a color theme to Shine, that it would be used on all pages of Reddit.

Unstyled action buttons on self posts

Removed from addons.mozilla.org?

Why? Anywhere can install it now?

Conflict and its markers left in base.js

Looks like there was a conflict left in the base.js file along with its conflict markers. Seems to have come from the last commit merging develop into master. The link below takes you straight to the line in question.

base.js#L107

Manifest.json contains git conflict lines

<<<<<<< HEAD
   "version": "1.5.0.3",
=======
   "version": "1.6.0",
>>>>>>> develop

Customisable tile spacing

In grid view I feel there is bit too much space between tiles. I worked it around by setting page zoom to 90% and decreasing number of columns by one. My suggestion is to add margin settings. Google calendar uses something like that, where you can choose from 3 types of "density" comfortable, compact and cozy. I don't feel like this is necessary feature, because there is perfectly fine workaround, but since you wanted suggestions. Here you go :)

Now breaks moderator toolbox for reddit search feature on profile page

This addon is great but it has now started to break the profile page search feature provided by the 'Moderator toolbox for reddit' extension. I'd like to keep using both extensions as both are very useful but one may have to go with this issue. Thanks.

Nothing is appearing, based on master branch

Disabling styling for the new design

I love shine for Reddit, thanks for maintaining it. I use it daily with old.reddit.com and everything looks fine. But when a link is opened form google search, Reddit defaults to the latest design and everything looks bad. Making it compatible is hard, can we at least disable the styling in the latest design. lemme know if this is okay. I'll send PR.

image not showing

hello, black space instead of displaying the image and once you click on that post it generate hundred of errors :

shine
<div class="large-image" style="background-image:url(undefined);"></div>

full page:

<div class="media-preview-content"><a href="https://i.redd.it/8vqoz72k97o01.gif" class="may-blank"><video class="preview" preload="auto" autoplay="autoplay" muted="muted" loop="loop" webkit-playsinline="" style="width: 560px; height: 560px;"><source src="https://g.redditmedia.com/Q0eR1enY4QINcggsJJS5K2tJqfFapqOkBfr3z32H3Sw.gif?w=560&amp;fm=mp4&amp;mp4-fragmented=false&amp;s=cf950131be383f5a1c6a7415f84a3835" type="video/mp4"></video></a></div>

Disable shortcuts

I use extensions for my web-browser to make it vim-like (keyboard oriented controls), and shine for reddit's keybinds conflict with these. It would be great to have a setting to disable shine's keybindings.

Master has a bunch of merge conflicts making the chrome extension not work.

Mod Settings

Further to what was mentioned in #15 about the modmail, a lot of the moderator functionality just straight up doesn't work if Shine is enabled. Things like changing the flair of a post and reviewing the modqueue are either much harder to do or just aren't possible. It means every time I need to do mod work I have to disable Shine which gets tiresome 😕

click on image in comment opens new tab instead of expando.

when I have the 2 column mode with comment on the right, when I click on 'view' near an image link ,it opens link in a new tab instead of showing it in expando.

firefox 59.0a1 (2018-01-15)
SHINE for reddit (unofficial) 1.6.0
RES 5.10.2

Double lock icons showing up before a user Authenticates

Issue

Currently the user sees two lock icons before they log in. Both seem to open the same panel.

Expectation

I should only see one lock "Log In" button.

Gifs are black image

gifs are just a black image.

See Image:

(also on frontpage, not only /r/gifs)

But, opening any link plays the gif just fine.
See here:

Enhancement - Mark as read

Love the extension, used the old one, and wondered why there was no updates.

Would love to see an option where when clicking on an image, it will mark it as read.

Thanks!

Subscribe Button Issue

https://github.com/voythas/shine-unofficial/blob/6cb28be5525c69a1c31b383cae4b5c96b2ce5384/base.css#L2215

Please assign the appropriate element class to this. RES subscribe button in /r/all and /r/popular gets messed up because it's a 'button.

'.

Don't Act on Modmail

Shine appears to be trying to change the styling of the modmail page, which is a fools errand since it uses completely different styling to the rest of Reddit. Easy fix would be be to exclude pages matching mod.reddit.com/*

This extension violates the Chrome Web Store policy.

SHINE for reddit (unofficial) 1.7.2

Any chance this extension will be updated to not violate Chrome Web Store Policy, so my browser will stop deactivating it?

Support for v.redd.it etc in Grid View

Currently I added support for new sources only for List View. I need to add the same for Grid View.

Note to self: look into moving support for sources into one single file instead.

Tile recycling

Hi,
after a time shine becomes slow and unresponsive. After short testing it seems it's memory issue (the more I scroll, the more memory tab takes). I presume this could be fixed by recycling tiles that are not on screen. By the way great job maintaining shine after the official fiasco :).

Clicking "edit" on a comment opens a blank new tab

When attempting to edit a comment from the listing page; clicking the edit link under the comment opens a new, blank tab.

Attempting to load this extension manually into Chrome is not working?

Hi, I'd been using this unofficial fork of the old extension for at least a couple years and been absolutely loving it. Since I reset my system, however, I can't seem to be able to get it working again with my new Chrome browser.

I'm sure this might be a dumb question, but when I'm trying to load this extension into Chrome it doesn't seem to work. I downloaded the code from here, unzipped it, and then clicked "load unpacked extension" in my chrome extensions and selected the "shine unofficial" folder. However, when I do that, I get an error that says "Manifest is not valid JSON. Line: 72, column: 1, Dictionary keys must be quoted."

I saw a guy saying that we could load this extension manually on another issue thread, so I feel like I must be missing something?

[Suggestion] Option to set a custom accent colour.

The option to set custom colours using hex values would be great to have.

/subscriptions/ shows stack of unlabeled unscribe buttons when hovering over the shine button

When viewing /subreddits/, the shine menu button shows a stack of the unsubscribe buttons. These are all unlabeled so they are not very useful and if you are subscribed to a large number of subreddits the menu becomes cluttered.

I think that blacklisting the /subreddits/ URI so the icons don't get displayed in there would likely be the best option since that feature should probably be limited to actual subreddits.