dotvhs / shine-unofficial Goto Github PK
View Code? Open in Web Editor NEWUnofficial fork of SHINE for Reddit.
Unofficial fork of SHINE for Reddit.
hello
due to change on reddit , there is a bug (on Firefox) that redirect all picture to a wrong URL
this seem to be a redirect probleme in the extension
can you update your extension please .as i really love it , especially the grid layout
more info here :
it concerne the extension old reddit redirect but i think it's the same thing with shine
https://old.reddit.com/r/help/comments/15kwhgy/why_is_every_image_link_i_click_on_directing_me/
_**It's your old Reddit redirect extension/userscript.
I had the same issue and tracked it down using the Network tab of the browser's developer tools. Here's what's happening. Reddit has replaced the normal showing of images with their own shitty image viewer. URLs which used to go directly to images now get redirected to a special Reddit page. For example, if your image URL is https://i.redd.it/image.jpg, your browser receives a redirect to https://www.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Fimage.jpg. However, your extension sees this URL and immediately rewrites it to https://old.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Fimage.jpg. But there's no media viewer at the old.reddit.com domain, so instead Reddit sends you a post in /r/funny whose ID happens to be media.
The fix is to modify whatever old Reddit extension or userscript you're using to exclude https://www.reddit.com/media from its URL rewriting. You can either do this yourself, ask the developer, or switch to an extension whose developer has already applied a fix.**_
thank you
Video player uses the K
key to play/pause, so user has to select the next post by mouse.
If possible make it A
+ D
like playing video games (WSDA), or leave an option to user to change it.
I've created a patch that will show when an item as been saved.
`
diff --git a/shine-grid.css b/shine-grid.css
index 7f3ef01..d613f25 100644
--- a/shine-grid.css
+++ b/shine-grid.css
@@ -231,6 +231,10 @@ html.SHINE.shine-grid body > .content #siteTable .thing ul.flat-list li.save-but
background-size: 18px;
}
+html.SHINE.shine-grid body > .content #siteTable .thing.saved ul.flat-list li.save-button a{
html.SHINE.shine-grid body > .content #siteTable .thing ul.flat-list .hide-button a{
width: 15px;
text-indent: 100%;
`
I love shine for Reddit, thanks for maintaining it. I use it daily with old.reddit.com and everything looks fine. But when a link is opened form google search, Reddit defaults to the latest design and everything looks bad. Making it compatible is hard, can we at least disable the styling in the latest design. lemme know if this is okay. I'll send PR.
when I have the 2 column mode with comment on the right, when I click on 'view' near an image link ,it opens link in a new tab instead of showing it in expando.
firefox 59.0a1 (2018-01-15)
SHINE for reddit (unofficial) 1.6.0
RES 5.10.2
When viewing /subreddits/, the shine menu button shows a stack of the unsubscribe buttons. These are all unlabeled so they are not very useful and if you are subscribed to a large number of subreddits the menu becomes cluttered.
I think that blacklisting the /subreddits/ URI so the icons don't get displayed in there would likely be the best option since that feature should probably be limited to actual subreddits.
The option to set custom colours using hex values would be great to have.
Love the extension, used the old one, and wondered why there was no updates.
Would love to see an option where when clicking on an image, it will mark it as read.
Thanks!
Why? Anywhere can install it now?
When attempting to edit a comment from the listing page; clicking the edit link under the comment opens a new, blank tab.
This isn't exactly an issue, but still… Do you plan on releasing a Microsoft Edge version? I know the userbase is reduced, but this extension is so amazing, it would be great if it was available on Microsoft's browser.
Hi, I'd been using this unofficial fork of the old extension for at least a couple years and been absolutely loving it. Since I reset my system, however, I can't seem to be able to get it working again with my new Chrome browser.
I'm sure this might be a dumb question, but when I'm trying to load this extension into Chrome it doesn't seem to work. I downloaded the code from here, unzipped it, and then clicked "load unpacked extension" in my chrome extensions and selected the "shine unofficial" folder. However, when I do that, I get an error that says "Manifest is not valid JSON. Line: 72, column: 1, Dictionary keys must be quoted."
I saw a guy saying that we could load this extension manually on another issue thread, so I feel like I must be missing something?
Further to what was mentioned in #15 about the modmail, a lot of the moderator functionality just straight up doesn't work if Shine is enabled. Things like changing the flair of a post and reviewing the modqueue are either much harder to do or just aren't possible. It means every time I need to do mod work I have to disable Shine which gets tiresome 😕
hello, black space instead of displaying the image and once you click on that post it generate hundred of errors :
shine
<div class="large-image" style="background-image:url(undefined);"></div>
full page:
<div class="media-preview-content"><a href="https://i.redd.it/8vqoz72k97o01.gif" class="may-blank"><video class="preview" preload="auto" autoplay="autoplay" muted="muted" loop="loop" webkit-playsinline="" style="width: 560px; height: 560px;"><source src="https://g.redditmedia.com/Q0eR1enY4QINcggsJJS5K2tJqfFapqOkBfr3z32H3Sw.gif?w=560&fm=mp4&mp4-fragmented=false&s=cf950131be383f5a1c6a7415f84a3835" type="video/mp4"></video></a></div>
I use extensions for my web-browser to make it vim-like (keyboard oriented controls), and shine for reddit's keybinds conflict with these. It would be great to have a setting to disable shine's keybindings.
<<<<<<< HEAD
"version": "1.5.0.3",
=======
"version": "1.6.0",
>>>>>>> develop
Will the new redesign ever be supported? It was a huge overhaul so I am not expecting anything, but it would be wonderful if you could make it happen, thanks!
In grid view, there are never any thumbnails for videos from v.redd.it (https://i.imgur.com/IrlQUqb.png) or gfycat (https://i.imgur.com/fTqXm5e.png)
While in list view, they do have thumbnails: https://i.imgur.com/jta9LPd.png, https://i.imgur.com/iAuDAdb.png
In grid view I feel there is bit too much space between tiles. I worked it around by setting page zoom to 90% and decreasing number of columns by one. My suggestion is to add margin settings. Google calendar uses something like that, where you can choose from 3 types of "density" comfortable, compact and cozy. I don't feel like this is necessary feature, because there is perfectly fine workaround, but since you wanted suggestions. Here you go :)
None of the pages under the /user/ section are styled correctly when using Shine.
Examples:
If I set a color theme to Shine, that it would be used on all pages of Reddit.
Shine appears to be trying to change the styling of the modmail page, which is a fools errand since it uses completely different styling to the rest of Reddit. Easy fix would be be to exclude pages matching mod.reddit.com/*
Looks like there was a conflict left in the base.js file along with its conflict markers. Seems to have come from the last commit merging develop into master. The link below takes you straight to the line in question.
This addon is great but it has now started to break the profile page search feature provided by the 'Moderator toolbox for reddit' extension. I'd like to keep using both extensions as both are very useful but one may have to go with this issue. Thanks.
Currently I added support for new sources only for List View. I need to add the same for Grid View.
Note to self: look into moving support for sources into one single file instead.
SHINE for reddit (unofficial) 1.7.2
Any chance this extension will be updated to not violate Chrome Web Store Policy, so my browser will stop deactivating it?
As far as I can see there are no buttons to manually load next page in SHINE. Also, I'm using Firefox which has a bug that prevents RES "neverending Reddit" (next page autoloader) to work (sometimes it works, sometimes don't). So, I tried to use uAutoPagerize extension to do the same thing, which works (autoloads Reddit pages), but there is an issue: SHINE won't load information into "expando" on the second and subsequent (autoloaded)pages - expando opens blank only with the "Hide Child Comments" button on the bottom. I tried all three available "views" in SHINE - the result is the same. Maybe you can take a look when you have time. thank you.
Edit: when "neverending Reddit" is working as intended, and automatically loads next page, SHINE working just fine. The issue appears only on the pages that were loaded using uAutoPagerize.
Is it possible to have an option to easily change the font?
Using commit 463764c
Using List View, let me know if you require any more details :)
Hi,
after a time shine becomes slow and unresponsive. After short testing it seems it's memory issue (the more I scroll, the more memory tab takes). I presume this could be fixed by recycling tiles that are not on screen. By the way great job maintaining shine after the official fiasco :).
Not sure if intended, but settings window does not use selected theme.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.