eelcohoogendoorn/numga

Geometric algebra in JAX and numpy

numga's Issues

'tuple index out of range' in NumpyMultiVector.__len__

When I tried to run the 'run_chain_numpy.py' example, I got the following error:

NumpyMultiVector.__len__(self)
     45 def __len__(self):
---> 46 	return self.shape[0]

IndexError: tuple index out of range

I was able to fix this by returning 1 if it self.shape is an empty tuple:

   45  def __len__(self):
   46    if len(self.shape)==0:
   47      return 1
   48    else:
   49      return self.shape[0]

This worked, but I am not sure if self.shape should ever have been an empty tuple to begin with. Maybe the real error is somewhere else?

Have you seen HVM?

https://github.com/HigherOrderCO/hvm-core seems like it could be relevant to you

'divide by zero' warning when running 'test_circle_reflect' test in 'test_conformal.py'

I get the following warning when I run the test_circle_reflect example:

/private/var/mobile/Containers/Data/Application/77881549-3FA6-4E4B-803F-D53B172FC865/Documents/myrepo/
numga/multivector/multivector.py:311: 
RuntimeWarning: divide by zero encountered in divide
  return self.copy(values=self.values / other.values)

This is only a warning, so I am not sure if it is a bug.

I suspect the reason for the 'divide by zero' warning is that the center of one of the mirrored circles is at the origin.
There is also a circle with a radius of 5e14 (presumably infinity) being drawn, and I had to set xlim and ylim to +-40 to zoom in to see the other circles.