Comments (3)
Good spotting, @salutis!
I (over)simplified the function in the README and came up with this:
(defun my-god-mode-update-mode-line ()
(cond (god-local-mode
(progn
(set-face-attribute 'mode-line nil
:foreground "#e9e2cb"
:background "#0a2832")
(set-face-attribute 'mode-line-inactive nil
:foreground "#e9e2cb"
:background "#0a2832")))
(t
(progn
(set-face-attribute 'mode-line nil
:foreground "#0a2832"
:background "#e9e2cb")
(set-face-attribute 'mode-line-inactive nil
:foreground "#0a2832"
:background "#e9e2cb")))))
I feel users can add in other attributes like :box
as they prefer.
Happy to add it in if needed as well.
Keen to hear your thoughts 😄
from god-mode.
I think we should use different colors for active and inactive mode lines. Setting both states to the same color sets a bad example and decreases accessibility of Emacs for no good reason.
Here is a version with properly differentiated active/inactive state:
(defun my-god-mode-update-mode-line ()
(cond
(god-local-mode
(set-face-attribute 'mode-line nil
:foreground "#604000"
:background "#fff29a")
(set-face-attribute 'mode-line-inactive nil
:foreground "#3f3000"
:background "#fff3da"))
(t
(set-face-attribute 'mode-line nil
:foreground "#0a0a0a"
:background "#d7d7d7")
(set-face-attribute 'mode-line-inactive nil
:foreground "#404148"
:background "#efefef"))))
Feel free to swap the colors; the ones above are from Modus Themes.
P.S. progn
is not necessary, as explained to me by Protesilaos Stavrou here:
https://gitlab.com/protesilaos/modus-themes/-/issues/187
from god-mode.
Setting both states to the same color sets a bad example and decreases accessibility of Emacs for no good reason.
Couldn't agree more 👌
progn
is not necessary
Good catch!
This function has been in the README for quite a while and I've been modifying it without really paying attention to that.
It looks like you've picked up a decent amount of Emacs Lisp in a relatively short amount of time 😄
Just like you, I have the awesome Emacs Lisp community to thank for whatever I know!
I'll update the README shortly.
from god-mode.
Related Issues (20)
- The function "my-god-mode-update-modeline" does not work reliably HOT 4
- God mode does not work in Transient UI HOT 8
- god-mode-all doesn't work in shell-mode HOT 4
- Keybinds recommendation
- Use Eldev HOT 1
- Add customisation to disable sticky `god-literal-key` HOT 13
- Idea: One-shot god-mode HOT 3
- [Idea] Disabling god mode after certain functions/key-presses HOT 5
- Have a discussion page for this project? HOT 1
- Extending god-mode system wide outside of Emacs HOT 13
- feature request: make describe-key work with god-mode HOT 10
- Make ESC just enter god-mode HOT 3
- Conflict with lispy-mode HOT 3
- Shifted key translation HOT 5
- Customize option to disable head icon showing on mode-line HOT 7
- god-mode doesn't work in *scratch* buffer
- god-mode does not work with "un-initialized" `projectile-mode-map` HOT 17
- binding for <C-tab> doesn't work in god-mode HOT 10
- Org-mode header navigation. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from god-mode.