Fix mode line suggested in README resulting in unreadable mode line

[rudolf-adamkovic]

Fix mode line suggested in README resulting in unreadable mode line

[darth10]

Good spotting, @salutis!

I (over)simplified the function in the README and came up with this:

(defun my-god-mode-update-mode-line ()
  (cond (god-local-mode
         (progn
           (set-face-attribute 'mode-line nil
                               :foreground "#e9e2cb"
                               :background "#0a2832")
           (set-face-attribute 'mode-line-inactive nil
                               :foreground "#e9e2cb"
                               :background "#0a2832")))
        (t
         (progn
           (set-face-attribute 'mode-line nil
                               :foreground "#0a2832"
                               :background "#e9e2cb")
           (set-face-attribute 'mode-line-inactive nil
                               :foreground "#0a2832"
                               :background "#e9e2cb")))))

I feel users can add in other attributes like :box as they prefer.
Happy to add it in if needed as well.
Keen to hear your thoughts 😄

[rudolf-adamkovic]

@darth10

I think we should use different colors for active and inactive mode lines. Setting both states to the same color sets a bad example and decreases accessibility of Emacs for no good reason.

Here is a version with properly differentiated active/inactive state:

(defun my-god-mode-update-mode-line ()
  (cond
   (god-local-mode
    (set-face-attribute 'mode-line nil
                        :foreground "#604000"
                        :background "#fff29a")
    (set-face-attribute 'mode-line-inactive nil
                        :foreground "#3f3000"
                        :background "#fff3da"))
   (t
    (set-face-attribute 'mode-line nil
			:foreground "#0a0a0a"
			:background "#d7d7d7")
    (set-face-attribute 'mode-line-inactive nil
			:foreground "#404148"
			:background "#efefef"))))

Feel free to swap the colors; the ones above are from Modus Themes.

P.S. progn is not necessary, as explained to me by Protesilaos Stavrou here:

https://gitlab.com/protesilaos/modus-themes/-/issues/187

[darth10]

Setting both states to the same color sets a bad example and decreases accessibility of Emacs for no good reason.

Couldn't agree more 👌

progn is not necessary

Good catch!
This function has been in the README for quite a while and I've been modifying it without really paying attention to that.

It looks like you've picked up a decent amount of Emacs Lisp in a relatively short amount of time 😄
Just like you, I have the awesome Emacs Lisp community to thank for whatever I know!

I'll update the README shortly.